- Changed form_select() to return NULL if called without $options. This should

  not have any impact, and makes things look nicer imo.

1 files changed, 4 insertions, 2 deletions

diff --git a/includes/common.inc b/includes/common.inc
index 081c60ccb..fcb93c618 100644
--- a/includes/common.inc
+++ b/includes/common.inc
@@ -178,8 +178,10 @@ function form_textarea($title, $name, $value, $cols, $rows, $description = 0) {
 }
 
 function form_select($title, $name, $value, $options, $description = 0) {
-  foreach ($options as $key=>$choice) $select .= "<option value=\"$key\"". ($key == $value ? " selected" : "") .">". check_form($choice) ."</option>";
-  return form_item($title, "<select name=\"edit[$name]\">$select</select>", $description);
+  if (count($options) > 0) {
+    foreach ($options as $key=>$choice) $select .= "<option value=\"$key\"". ($key == $value ? " selected" : "") .">". check_form($choice) ."</option>";
+    return form_item($title, "<select name=\"edit[$name]\">$select</select>", $description);
+  }
 }
 
 function form_file($title, $name, $size, $description = 0) {