diff options
| author | Dries Buytaert <dries@buytaert.net> | 2004-05-05 21:12:14 +0000 |
|---|---|---|
| committer | Dries Buytaert <dries@buytaert.net> | 2004-05-05 21:12:14 +0000 |
| commit | 681b26febc6457cf2a532a2d45306bc52de165b4 (patch) | |
| tree | 07fb998921e37b8cb4c2b062d839ab8f06b0a1e7 /includes | |
| parent | 6f2d85186b350e55fbaaf3c1b3bb9bc91ea3c60f (diff) | |
| download | brdo-681b26febc6457cf2a532a2d45306bc52de165b4.tar.gz brdo-681b26febc6457cf2a532a2d45306bc52de165b4.tar.bz2 | |
- Patch #7577 by JonBob: various code style improvements to the statistics
module.
+ Usages of to print titles have been replaced by proper drupal_set_title()
calls.
+ Many arg() usages dropped in favor of meaningful parameters.
+ Doxygen comments standardized and expanded.
+ Some grammatical corrections to help text.
+ Broken /statistics page linked from page navigation restored.
+ Fixed small bug in menu.inc pertaining to menu callbacks without
arguments.
Diffstat (limited to 'includes')
| -rw-r--r-- | includes/menu.inc | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/includes/menu.inc b/includes/menu.inc index 9b9bcec7f..e5ee1a0d4 100644 --- a/includes/menu.inc +++ b/includes/menu.inc @@ -50,6 +50,7 @@ function menu($path, $title, $callback = MENU_FALLTHROUGH, $weight = 0, $visibil /** * Return the menu data structure. * + * @ingroup menu * The returned structure contains much information that is useful only * internally in the menu system. External modules are likely to need only * the ['visible'] element of the returned array. All menu items that are @@ -207,7 +208,7 @@ function menu_execute_active_handler() { if (is_string($menu['items'][$mid]['callback'])) { $arg = substr($_GET['q'], strlen($menu['items'][$mid]['path']) + 1); - if (isset($arg)) { + if (strlen($arg)) { call_user_func_array($menu['items'][$mid]['callback'], explode('/', $arg)); } else { @@ -412,6 +413,7 @@ function menu_build_visible_tree($pid = 0) { /** * Populate the database representation of the menu. * + * @ingroup menu * This need only be called at the start of pages that modify the menu. */ function menu_rebuild() { |