- Simplified the 'anonymous poster settings' of the comment module and

  made it possible to enforce a username/e-mail address.  Based on
  James Seng's work there are now 3 radio buttons:

   ( ) Anonymous users may not enter contact information
   ( ) Anonymous users may leave contact information
   ( ) Anonymous users must leave contact information

- Fixed a bug in the default theme_comment_view() function.

- Added permalinks for comments.  Requested by Michael and Christina.
  Maintainers of contributed themes might want to add permalinks too.

TODO:

- Fix the interaction design of the submission form: the page you are
  directed to and the validation of the contact information.

- Changing the comment viewing options appears to be broken?

3 files changed, 4 insertions, 4 deletions

diff --git a/themes/chameleon/chameleon.theme b/themes/chameleon/chameleon.theme
index c9809e377..6906fbaa8 100644
--- a/themes/chameleon/chameleon.theme
+++ b/themes/chameleon/chameleon.theme
@@ -141,12 +141,11 @@ function chameleon_comment($comment, $link = "") {
   $links = array($link);
 
   $output  = "<div class=\"comment\">\n";
-  $output .= " <h3 class=\"title\">". $comment->subject ."</h3>\n";
+  $output .= " <h3 class=\"title\">". l($comment->subject, $_GET['q'], NULL, NULL, "comment-$comment->cid") ."</h3>\n";
   $output .= " <div class=\"content\">". $comment->comment ."</div>\n";
   $output .= " <div class=\"links\">". theme('links', array_merge($submitted, $links)) ."</div>\n";
   $output .= "</div>\n";
 
   return $output;
 }
-
 ?>
diff --git a/themes/xtemplate/default/xtemplate.css b/themes/xtemplate/default/xtemplate.css
index b2bc4eb31..51dc99cfc 100644
--- a/themes/xtemplate/default/xtemplate.css
+++ b/themes/xtemplate/default/xtemplate.css
@@ -251,8 +251,9 @@ table {
   padding: .5em;
   margin-bottom: 1em;
 }
-.comment .title {
+.comment .title a {
   font-size: 1.1em;
+  font-weight: normal;
 }
 .comment .new {
   text-align: right;
diff --git a/themes/xtemplate/xtemplate.theme b/themes/xtemplate/xtemplate.theme
index 51443403b..3a63e03ee 100644
--- a/themes/xtemplate/xtemplate.theme
+++ b/themes/xtemplate/xtemplate.theme
@@ -99,7 +99,7 @@ function xtemplate_comment($comment, $links = 0) {
     "submitted" => t("Submitted by %a on %b.",
                       array("%a" => format_name($comment),
                             "%b" => format_date($comment->timestamp))),
-    "title"     => $comment->subject,
+    "title"     => l($comment->subject, $_GET['q'], NULL, NULL, "comment-$comment->cid"),
     "author"    => format_name($comment),
     "date"      => format_date($comment->timestamp),
     "content"   => $comment->comment