summaryrefslogtreecommitdiff
path: root/includes/pager.inc
Commit message (Collapse)AuthorAge
* - Patch #520764 by Damien Tournoud, JoshuaRogers, brianV: fixed ↵Dries Buytaert2009-12-05
| | | | SA-CORE-2009-007: request values in URL, including password/username.
* - Patch #648744 by Crell: specified more @return type definitions for ↵Dries Buytaert2009-12-04
| | | | auto-completion in IDEs.
* - Patch #266434 by catch, merlinofchaos, sun: fixed E_NOTICE in ↵Dries Buytaert2009-11-14
| | | | pager_load_array().
* - Patch #321023 by Everett Zufelt, mgifford: improve accesibility in pager.inc.Dries Buytaert2009-10-31
|
* - Patch #572618 by effulgentsia, pwolanin, sun: all theme functions should ↵Dries Buytaert2009-10-09
| | | | take a single argument. Code clean-up and performance improvement. Woot.
* - Patch #578520 by sun | c960657, mfb, Dries, catch, mattyoung: make in ↵Dries Buytaert2009-09-29
| | | | url() only accept an array. Another nice API clean-up!
* #564394 by Berdir and Crell: Removed database BC layer. nah nah nah nah... ↵Angie Byron2009-09-18
| | | | hey hey hey... gooood byeeee...
* #496516 by Crell and Berdir: Moved query_alter() into a preExecute() method, ↵Angie Byron2009-08-26
| | | | so that modules can know the final query/arguments before they are run.
* #326539 by JohnAlbin, sun, cha0s, ultimateboy, Rob Loach, Damien Tournoud: ↵Angie Byron2009-08-22
| | | | Convert 'class' attribute to use an array, not a string.
* #514914 by Gábor Hojtsy: Add back removed pager_limits variable.Angie Byron2009-08-11
|
* - Patch #491556 by Berdir: completed converting core to DBTNG. Oh my. Kudos ↵Dries Buytaert2009-07-28
| | | | to Berdir for this humongous effort.
* - Patch #430904 by Berdir: fixed notice in case there are two pagers on one ↵Dries Buytaert2009-05-12
| | | | page.
* - Patch #330748 by stBorchert: remove from theme_pager*.Dries Buytaert2009-04-26
|
* - Patch #299267 by Crell: add extender support to the SELECT query builder.Dries Buytaert2009-02-22
|
* #282405 by Damien Tournoud, lilou, Dave Reid: Enforce coding standard on elseif.Angie Byron2008-10-12
|
* #196667 (GHOP 45) by fberci: add '@ingroup themeable' to all themeable functionsGábor Hojtsy2007-12-06
|
* - Patch #163508 by profix898: fixed 4 E_ALL notices.Dries Buytaert2007-08-02
|
* - Patch #135931 by EclipseGc: semantic update for core pager.Dries Buytaert2007-05-01
|
* - Patch #111347 by Steven: refactor url() and l().Dries Buytaert2007-02-15
|
* - Patch #87995 by merlinofchaos: added missing css.Dries Buytaert2006-10-15
|
* - Patch #80934 by timnc: more t() fixes.Dries Buytaert2006-08-27
|
* #80200 by gorgen. More strict pager query regexp.Neil Drumm2006-08-24
|
* - Patch #78364 by chx: remove pager cruft.Dries Buytaert2006-08-16
|
* - Patch #72204 by nedjo: upper-cased all TRUE/FALSE/NULL constants.Dries Buytaert2006-07-05
|
* #5371, drupal_get_destination, pager and tablesort array handling, patch by ↵Gerhard Killesreiter2006-04-13
| | | | Steven
* - Patch #44771 by jvandyk: small performance improvement.Dries Buytaert2006-01-15
|
* - #44498: Clean up pager / make more accessibleSteven Wittens2006-01-15
|
* - Patch #44498 by m3vrck: improved HTML generated code for pagers.Dries Buytaert2006-01-14
|
* - Patch #30930 by m3avrck/deekayen: cured PHP5 warnings.Dries Buytaert2005-10-22
|
* - #32603: Clean up theme_pager_link (drumm)Steven Wittens2005-10-21
|
* - Patch #29385 by chx: no ?> add end of files.Dries Buytaert2005-08-25
|
* - Patch #27980 by Neil Drumm: removed unused function.Dries Buytaert2005-08-10
|
* - #24673: Fix deprecated usage of implodeSteven Wittens2005-07-30
|
* - Fix mistakes in pager patch.Steven Wittens2005-05-25
|
* - #23495: Clean up pager code. Now uses $page instead of $from, and counts ↵Steven Wittens2005-05-25
| | | | pages, not items.
* - #18817: Clean up plain-text checking (see drupal-devel!)Steven Wittens2005-03-31
|
* - Patch by Remco: <div> -> </div>.Dries Buytaert2005-01-28
|
* - Patch by Jeremy: fixed unclosed "Dries Buytaert2005-01-27
|
* - Patch by Jeremy: made the diffs more meaningful.Dries Buytaert2005-01-27
|
* - Patch #16273 by Jeremy: improved the themability of the pager.Dries Buytaert2005-01-27
|
* Pager_query's count query was broken if no query arguments were given.Steven Wittens2004-12-06
|
* - Patch by Steven: fixed bug in pager_query().Dries Buytaert2004-12-04
|
* Fix for pager_query() after #13581 (array of query arguments).Steven Wittens2004-12-02
|
* - Patch #13581 by Steven: Db_query() allows a variable amount of parameters ↵Dries Buytaert2004-11-29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | so you can pass the query arguments in. There is however an alternative syntax: instead of passing the query arguments as function arguments, you can also pass a single array with the query arguments in it. For example the following two statements are equivalent: db_query($query, $a, $b, $c); db_query($query, array($a, $b, $c)); This usage is particularly interesting when the query is constructed dynamically, and the amount of arguments to pass varies. In that case we use the second method to avoid using call_user_func_array(). This behaviour is not documented explicitly, but it is used in several places. However, db_query_range() and pager_query() do not support this syntax properly, which means there are several pieces of code which still revert to the ugly call_user_func_array() call. This patch updates db_query_range() and pager_query() so they support the array-passing method. I also added documentation about this method to each of the db functions. I also cleaned up the code for db_query (it was weird and hard to understand) and moved db_query() and db_queryd() from database.xxxxx.inc to database.inc: it was the same between both mysql and pgsql, as it doesn't do anything database specific. It just prefixes the tables and inserts the arguments. The actual db query is performed in _db_query(), which is still in database.xxxxx.inc. Finally, I updated several places with the new syntax, and the code is a lot cleaner. For example: - array_unshift($params, "SELECT u.* FROM {users} u WHERE $query u.status < 3"); - $params[] = 0; - $params[] = 1; - $result = call_user_func_array('db_query_range', $params); + $result = db_query_range("SELECT u.* FROM {users} u WHERE $query u.status < 3", $params, 0, 1); and - return call_user_func_array('db_query_range', array_merge(array($query), $args, array((int)$pager_from_array[$element], (int)$limit))); + return db_query_range($query, $args, (int)$pager_from_array[$element], (int)$limit); I've tested it on mysql. I didn't alter the actual db behaviour, so pgsql should be okay too. This patch is important because many people avoid the call_user_func_array() method and put data directly into the db query. This is very, very bad because the database prefix will be applied to it, and strip out braces. It's also generally bad form as you have to call check_query() yourself. With the new, documented syntax, there is no more excuse to put data directly in the query.
* - Patch #7161 by jhriggs: fixed probem with 'last page' link not being ↵Dries Buytaert2004-10-31
| | | | correct under certain circumstances.
* - Patch #10663 by JonBob: documentation improvements: fixed some typos and ↵Dries Buytaert2004-09-09
| | | | improved consistency to the use of Doxygen/api.module commands in the comments.
* - Patch #7535 by Gerhard: one could not search for the word 'From'.Dries Buytaert2004-08-12
|
* - Patch #9478 by JonBob: allow printf-style arguments in pager_query.Dries Buytaert2004-07-25
| | | | | | Currently pager_query() is the black sheep of the database query family, because it does not allow for printf-style arguments to be inserted in the query. This is a problem because it introduces developer confusion when moving from an unpaged query to a paged one, and it encourages substitution of variables directly into the query, which can bypass our check_query() security feature. This patch adds this ability to pager_query(). The change is backwards-compatible, but a couple calls to the function in core have been changed to use the new capability.
* - #9287: More doxygen/documentation fixes by JonBobSteven Wittens2004-07-22
|
* - Patch #8973 by JonBob: Drupal contains many undefined variables and array ↵Dries Buytaert2004-07-02
| | | | indices, which makes PHP throw a lot of warnings when the reporting level is set to E_ALL. Things run fine with these warnings, but as a matter of code style if nothing else we should probably strive to avoid them. The attached fixes most of the more egregious offenders (about 95% of the warnings when I load /node on my test site).
generated by cgit v1.2.3 (git 2.25.1) at 2025-07-16 21:01:55 +0000