| Commit message (Collapse) | Author | Age |
|
|
|
|
|
| |
Currently pager_query() is the black sheep of the database query family, because it does not allow for printf-style arguments to be inserted in the query. This is a problem because it introduces developer confusion when moving from an unpaged query to a paged one, and it encourages substitution of variables directly into the query, which can bypass our check_query() security feature.
This patch adds this ability to pager_query(). The change is backwards-compatible, but a couple calls to the function in core have been changed to use the new capability.
|
| |
|
|
|
|
| |
'false' in this case)
|
| |
|
| |
|
|
|
|
| |
files consistent with Drupal standards, and adds a wealth of Doxygen-style comments to aid developers in writing solid database access code using the API.
|
|
|
|
| |
additional menu's were never displayed, but were saved. Only the last custom menu was displayed.
|
|
|
|
| |
bootstrap.inc.
|
| |
|
|
|
|
| |
to UTF-8. It also throws a friendlier error message when none of these extensions is installed.
|
|
|
|
| |
devel.module.
|
| |
|
| |
|
|
|
|
| |
pages. Useful to reduce your site's bandwidth.
|
| |
|
|
|
|
|
|
|
|
|
|
| |
http://drupal.org/files/issues/error_messages_list.png (issue #9138).
drupal_set_message() has been changed to group message by type and a
helper function, theme_status_message(), is added to display the messages.
Chameleon and Xtemplate have been updated to use this new function.
- Updated CHANGELOG.txt.
|
|
|
|
| |
- Fixed order of parameters in form_checkboxes() (plural).
|
| |
|
|
|
|
|
|
|
|
| |
system is now using form_set_error() and friends like the rest of Drupal does. This makes for both a consistent user experience and consistent code. It simplifies the forms and validation code, however, it does change the node API slightly:
* The _validate hook and the _nodeapi('validate') hook of the node API (1) no longer take an 'error' parameter and (2) should no longer return an error array. To set an error, call form_set_error().
* The _form hook of the node module no longer takes a form hook and should not worry about displaying errors. Ditto for _nodeapi('form_post') and _nodeapi('form_pre').
|
| |
|
|
|
|
| |
indices, which makes PHP throw a lot of warnings when the reporting level is set to E_ALL. Things run fine with these warnings, but as a matter of code style if nothing else we should probably strive to avoid them. The attached fixes most of the more egregious offenders (about 95% of the warnings when I load /node on my test site).
|
|
|
|
|
| |
as simplifying the theming of local tasks so they can be more easily
rendered in a non-tab manner.
|
|
|
|
| |
database indices.
|
|
|
|
|
|
| |
redirects after form submission to work properly)
- Double-quotes to Single-quotes
|
|
|
|
| |
and forum module.
|
| |
|
|
|
|
| |
correctly.
|
| |
|
|
|
|
|
|
| |
to get of proprietary formats).
- Added forum-sticky.png. Made by Steven.
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
logical name. Requires a database upgrade.
|
|
|
|
|
|
|
|
| |
+ Changed menu.inc to generate two separate lists instead of nested lists:
that seems to be the only alternative to get rid of absolute positioning.
+ Changed the tabs code to be more sexy and put the code in misc/drupal.css
so all themes are automagically updated.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
CHANGES
-------
+ Introduced tabs. First, we extended the menu system to support tabs. Next, a tab was added for every link that was (1) an administrative action other than the implicit 'view' (2) relevant to that particular page only. This is illustrated by the fact that all tabs are verbs and that clicking a page's tab leads you to a subpage of that page.
+ Flattened the administration menu. The tabs helped simplify the navigation menu as I could separate 'actions' from 'navigation'. In addition, I removed the 'administer > configuration'-menu, renamed 'blocks' to 'sidebars' which I hope is a bit more descriptive, and made a couple more changes. Earlier, we already renamed 'taxonomy' to 'categorization' and we move 'statistics' under 'logs'.
+ Grouped settings. All settings have been grouped under 'administer > settings'.
TODO
----
+ Update core themes: only Xtemplate default supports tabs and even those look ugly. Need help.
+ Update contributed modules. The menu() hook changed drastically. Updating your code adhere the new menu() function should be 90% of the work. Moreover, ensure that your modue's admin links are still valid and that URLs to node get updated to the new scheme ('node/view/x' -> 'node/x').
|
|
|
|
| |
and form_radios().
|
| |
|
| |
|
|
|
|
|
| |
- Fixing a copy paste error in file.inc.
- Some double => single quote changes.
|
| |
|
|
|
|
| |
some tablesort glitches.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
+ Introduced two new functions:
1. form_set_error($name, $message): files an error against the form
element with the specified $name.
2. form_has_errors(): returns true if errors has been filed against
form elements.
+ Updated the form handling:
1. The form_ functions will add 'class="error"' when a form field
has been found to be erroneous.
2. The error message is passed to theme_form_element() when the
particular form field has been found to be erroneous.
+ I updated the user and profile module to take advantage of these new
functions.
+ IMPORTANT: the _user() hook changed. The 'validate' case should no
longer retun an error message when something goes wrong but should
set it with form_set_error().
|
|
|
|
| |
the active column.
|
| |
|
|
|
|
| |
tablesorting code.
|
|
|
|
| |
subset of all e-mail addresses was rejected as valid.
|
|
|
|
| |
which is not suitable for the purposes the box is used in. Boxes are used to wrap tables or forms with titles. The comment module uses theme(box, ...) to wrap forms into boxes for example. Therefore using a paragraph does not make the output valid XHTML and a div is needed.
|
|
|
|
| |
can persist when redirection is used.
|