Commit message (Collapse) | Author | Age | |
---|---|---|---|
* | - Patch #45850: it was impossible to create shadow topic. (Today's critical ↵ | Dries Buytaert | 2006-02-23 |
| | | | | bugfix #2.) | ||
* | - Patch #49912: www.drupal.org -> drupal.org. (Today's critical bugfix #5.) | Dries Buytaert | 2006-02-21 |
| | |||
* | - Patch #46743 by Morbus: fixed double encoding issue. | Dries Buytaert | 2006-02-15 |
| | |||
* | - Patch #46743 by m3avrck: clean up forum topic navigation. Bring it in ↵ | Dries Buytaert | 2006-02-10 |
| | | | | line with book.module. | ||
* | - Patch #47691 by Cvbge: quickfix postgresql | Dries Buytaert | 2006-02-09 |
| | |||
* | - Patch #47691 by wtanaka: performance improvement for _forum_topics_read. | Dries Buytaert | 2006-02-09 |
| | |||
* | - Patch #47868 by wtanaka: performance improvement: active topics block ↵ | Dries Buytaert | 2006-02-04 |
| | | | | selects an unused column. | ||
* | - Patch #46864 by stmind: fixed problem with node-level permissions and forums. | Dries Buytaert | 2006-02-01 |
| | |||
* | - Patch #45530 by Morbus: filter_form shouldn't default to #weight 0 | Dries Buytaert | 2006-01-20 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | When a form element doesn't specify a #weight, it is assumed internally as #weight 0. However, to ensure that our form elements display visually *as they were defined in the array* we, in form_builder, count the number of elements, divide by 1000, and set that as the weight: # Assign a decimal placeholder weight to preserve original array order if (!isset($form[$key]['#weight'])) { $form[$key]['#weight'] = $count/1000; } The above code will set the #weights of elements that have not defined a weight to something like 0 (first element in array definition), 0.001, 0.002, and so on. However, anytime a form element *explicitly* defines a #weight of 0, that #weight is kept at exactly 0, which would cause that form element to appear BEFORE the elements that didn't have a #weight defined (and thus received a #weight such as 0.002). Consider the following pseudo example: $form['game_title'] = array( '#type' => 'textfield', ... ); $form['game_description'] = array( '#type' => 'textarea', ... ); $form['game_format'] = filter_form(variable_get('game_format', NULL)); return $form; Here, we're not definiing weights on our two textfields. We then add an filter_form. The second parameter of the filter_form is $weight, which defaults to 0. After this $form hits form_builder, we have weights 0 (game_title), 0.001 (game_description), and 0 (filter_form) respectively. This is then sorted by weight, which causes filter_form (the third element in the array) to appear BEFORE game_description (0 is lighter than 0.001). The short lesson is: explicitly defining #weight 0 for a form element is probably a bad idea. This patch changes the default #weight of filter_form to NULL, instead of 0, and also removes any other explicit setting of #weight to 0 in core. | ||
* | - Patch #45281 by chx: made categories with forum topics work again. | Dries Buytaert | 2006-01-19 |
| | |||
* | - Patch #45349 by Morbus Iff: input filters aren't sorting correctly ↵ | Dries Buytaert | 2006-01-19 |
| | | | | infForms API. | ||
* | - Patch #45301 by Morbus: corrected the weight of form item titles of nodes. | Dries Buytaert | 2006-01-18 |
| | |||
* | - Patch #33747 by Ber and Moshe: bugfix + code improvement: clean up some of ↵ | Dries Buytaert | 2006-01-10 |
| | | | | the taxonomy loading code. | ||
* | - Removed global . | Dries Buytaert | 2006-01-09 |
| | |||
* | - Patch 42591 by Simon/me: fixed problem with deleting forum and book revisions. | Dries Buytaert | 2005-12-31 |
| | |||
* | - Patch #42705 by Cvbge: added missing format_plural(). | Dries Buytaert | 2005-12-31 |
| | |||
* | - Patch 41169 by Chris: got rid of expensvie object 2 array casts. | Dries Buytaert | 2005-12-31 |
| | |||
* | - #42234: Use standardized feed icon for RSS | Steven Wittens | 2005-12-29 |
| | |||
* | - Patch #42343 by wulff: added 2 missing t() functions. | Dries Buytaert | 2005-12-26 |
| | |||
* | - Modified patch #40534: improved themability of forum icons (makes it ↵ | Dries Buytaert | 2005-12-11 |
| | | | | possible to use animated gifs) + removed forum setting. | ||
* | - Patch #40664 by Gerhard: assign default forum when adding a forum topic ↵ | Dries Buytaert | 2005-12-10 |
| | | | | from within a forum. | ||
* | - Patch #39598 by Gerhard: fixed problem with taxonomy terms not being selected. | Dries Buytaert | 2005-12-06 |
| | |||
* | - Patch #31323 by Gerhard: delete extra data when a revision is deleted. | Dries Buytaert | 2005-12-05 |
| | |||
* | - Patch #39778 by chx: obliterate nodeapi op form in favor of the forms ↵ | Dries Buytaert | 2005-12-05 |
| | | | | API's way of doing things. Tested with help from webchick. | ||
* | - Patch #38849 by wtanaka: forum icon does not display as locked (aka ↵ | Dries Buytaert | 2005-12-03 |
| | | | | closed) if comments are "disabled" instead of "read only". | ||
* | - Patch #39667 by killes: fixed typo in function call: _forum_get_vid -> ↵ | Dries Buytaert | 2005-12-02 |
| | | | | _forum_get_vid(). | ||
* | - Patch #39576 by chx: rename '_execute' to '_submit' and '#execute' to ↵ | Dries Buytaert | 2005-12-02 |
| | | | | '#submit'. | ||
* | - Patch #38854 by wtanaka: fixed XHTML validation problem. | Dries Buytaert | 2005-11-26 |
| | |||
* | - Patch #35644 by webchick: fixed the sizes of the textareas on the node ↵ | Dries Buytaert | 2005-11-23 |
| | | | | edit forms. | ||
* | - Patch #35644 by webchick: forms API simplificiations. | Dries Buytaert | 2005-11-12 |
| | |||
* | #36791: node_validate was called twice | Steven Wittens | 2005-11-12 |
| | |||
* | - Patch #36250 by hunmonk: admin batch delete broken, node_delete needs ↵ | Dries Buytaert | 2005-11-04 |
| | | | | | | reworked. This commit changes the node_delete() API. A list of affected modules is available at http://drupal.org/node/36250#comment-52963. | ||
* | - Patch #26139 by webchick / Kieran / documentation team: improved admin ↵ | Dries Buytaert | 2005-11-01 |
| | | | | help of core modules! / | ||
* | - Patch #35205 by stefan: removed some deprecated code from forum.module! Yay. | Dries Buytaert | 2005-10-28 |
| | |||
* | - Patch #35061 by Cvbge/ntosi: fixed SQL query problem on PostgreSQL 8. | Dries Buytaert | 2005-10-28 |
| | |||
* | - #35505: Forum form api typo | Steven Wittens | 2005-10-28 |
| | |||
* | - #26583: Make forum taxonomy links redirect to forums rather than taxonomy ↵ | Steven Wittens | 2005-10-21 |
| | | | | pages. | ||
* | - Patch #33752 by chx, adrian, et al: another batch of form API changes/fixes. | Dries Buytaert | 2005-10-11 |
| | |||
* | - Removing tabs and trailing whitespaces. | Dries Buytaert | 2005-10-07 |
| | |||
* | - Patch #29465: new form API by Adrian et al. | Dries Buytaert | 2005-10-07 |
| | | | | | | | TODO: + The contact.module was broken; a new patch for contact.module is needed. + Documentation is needed. + The most important modules need to be updated ASAP. | ||
* | - Patch #32459 by beardedstoat and tostinni: always add a secondary sort ↵ | Dries Buytaert | 2005-10-01 |
| | | | | order so the newest comments are on top. | ||
* | - Fixed spaces | Dries Buytaert | 2005-09-27 |
| | |||
* | - Patch #28786 by Neil: move pagers out of table. | Dries Buytaert | 2005-09-24 |
| | |||
* | - Patch #10056: allow the node title forms to be customized. | Dries Buytaert | 2005-09-23 |
| | |||
* | - Patch #29102 by menesis: fixed typo/left-over in switch-statement. | Dries Buytaert | 2005-09-08 |
| | |||
* | - Patch #28320 by Neil: improved the HTML/CSS of the user login block. | Dries Buytaert | 2005-09-07 |
| | |||
* | - Usablity improvement: check whether the comment module is enabled. If not, | Dries Buytaert | 2005-09-06 |
| | | | | show an error message. | ||
* | - Patch #7582 by Gerhard: improved node revisions! | Dries Buytaert | 2005-08-30 |
| | | | | | | | | | | All node revisions were stored in a serialized field in the node table and retrieved for _each_ page view although they are rarely needed. We created a separate revisions table which would be in principle identical to the node table, only that it could have several old copies of the same node. This also allows us to revision-related information, and to provide log entries to non-book pages when a new revision is being created. TODO: 1. Provide upgrade instructions for node module maintainers! 2. Upgrade modules that implement node types. 3. Provide an upgarde path for revisions. Dependency on the upgrade system. | ||
* | - Renamed _node() to _node_info()! We reserve _node for _nodeapi. | Dries Buytaert | 2005-08-29 |
| | |||
* | - Patch #29102 by chx: fixed bug in forum module and tidied up the ↵ | Dries Buytaert | 2005-08-28 |
| | | | | taxonomy_save_*() functions. |