- More improvements by Morbus, Goba, TDobes et al:

Per TDobes' comments:

* INSTALL.txt corrected to use 4.3.3, not 4.33.
* .htaccess: removed allow_call_time_pass_reference. two confirmations that a) the setting was wrong in the first place, b) there were no adverse affects for the incorrect setting, c) the PHP docs say it is deprecated.
* .htaccess: removed short_open_tag. Running grep -r "<? " * across the entire directory tree of both core and contributions only brought up contributions and no core. I agree that the fuller form is better. The following contributions will need to be updated: modules/edit_template/edit_template.module, sandbox/garym/themes/marvin_2k/templates/page.tpl.php, sandbox/killes/compare.php, sandbox/paolino/import/click.php, themes/spreadfirefox/block.tpl.php. For error's sake, I also did a manual verification for "<?" (no space) across core and came up against nothing in addition to the above contribs.

Per Goba's comments:

* .htaccess: Moved session.auto_start back.
* sites/default/settings.php: Removed track_vars.

Per mailing list comments:

* INSTALL.txt: Added text about the files/ directory, creating it, and permissions.
* INSTALL.txt: Added an example of why Drupal requires cron (the search.module) in an attempt to justify why a crontab is a good, nay, required step.

And my own further analities:

* .htaccess: cleaned up some whitespace valleys (i hate 'em, hate 'em!) and fixed a few stray colons.
* settings.php: minor whitespace error.

1 files changed, 9 insertions, 13 deletions

diff --git a/.htaccess b/.htaccess
index 241a358d1..614572f38 100644
--- a/.htaccess
+++ b/.htaccess
@@ -18,26 +18,22 @@ ErrorDocument 404 /index.php
 # Set the default handler.
 DirectoryIndex index.php
 
-# Override PHP settings. More overrides exist in
-# sites/default/settings.php, but the following cannot be changed at 
-# runtime. The first IfModule is for Apache 1.3, the second for 
-# Apache 2.
+# Override PHP settings. More exist in sites/default/settings.php, but
+# the following cannot be changed at runtime. The first IfModule is
+# for Apache 1.3, the second for Apache 2.
 <IfModule mod_php4.c>
-   php_value allow_call_time_pass_reference  1
    php_value magic_quotes_gpc                0
    php_value register_globals                0
-   php_value short_open_tag                  1
+   php_value session.auto_start              0
 </IfModule>
 
 <IfModule sapi_apache2.c>
-   php_value allow_call_time_pass_reference  1
    php_value magic_quotes_gpc                0
    php_value register_globals                0
-   php_value short_open_tag                  1
+   php_value session.auto_start              0
 </IfModule>
 
-# Override mod_expires by reducing the time dynamically generated pages
-# are cache-able.
+# Reduce the time dynamically generated pages are cache-able.
 <IfModule mod_expires.c>
   ExpiresByType text/html A1
 </IfModule>
@@ -46,7 +42,7 @@ DirectoryIndex index.php
 <IfModule mod_rewrite.c>
   RewriteEngine on
 
-  # Modify the RewriteBase if you are using Drupal in a subdirectory and 
+  # Modify the RewriteBase if you are using Drupal in a subdirectory and
   # the rewrite rules are not working properly.
   #RewriteBase /drupal
 
@@ -56,13 +52,13 @@ DirectoryIndex index.php
   #RewriteCond %{QUERY_STRING} ^id=([^&]+)$
   #RewriteRule node.php index.php?q=node/view/%1 [L]
 
-  # Rewrite old-style URLs of the form 'module.php?mod=x':
+  # Rewrite old-style URLs of the form 'module.php?mod=x'.
   #RewriteCond %{REQUEST_FILENAME} !-f
   #RewriteCond %{REQUEST_FILENAME} !-d
   #RewriteCond %{QUERY_STRING} ^mod=([^&]+)$
   #RewriteRule module.php index.php?q=%1 [L]
 
-  # Rewrite current-style URLs of the form 'index.php?q=x':
+  # Rewrite current-style URLs of the form 'index.php?q=x'.
   RewriteCond %{REQUEST_FILENAME} !-f
   RewriteCond %{REQUEST_FILENAME} !-d
   RewriteRule ^(.*)$ index.php?q=$1 [L,QSA]