diff options
| author | Dries Buytaert <dries@buytaert.net> | 2003-10-21 18:34:54 +0000 |
|---|---|---|
| committer | Dries Buytaert <dries@buytaert.net> | 2003-10-21 18:34:54 +0000 |
| commit | 1fb82a6ebc65ab00a7dbd86ffef09953c825c46b (patch) | |
| tree | ba9e1bad3d3967d567055085a2b1e9c66d41ae1a | |
| parent | 71db4f261a65bd2b2746335db2422b845d59228c (diff) | |
| download | brdo-1fb82a6ebc65ab00a7dbd86ffef09953c825c46b.tar.gz brdo-1fb82a6ebc65ab00a7dbd86ffef09953c825c46b.tar.bz2 | |
- Bugfix/improvement: the revision table was not using table(). Fixes bug
#3635.
| -rw-r--r-- | modules/node.module | 9 | ||||
| -rw-r--r-- | modules/node/node.module | 9 |
2 files changed, 10 insertions, 8 deletions
diff --git a/modules/node.module b/modules/node.module index 62f7feed7..5acc7c956 100644 --- a/modules/node.module +++ b/modules/node.module @@ -587,12 +587,13 @@ function node_admin_edit($node) { if ($node->revisions) { $output .= "<h3>". t("Edit revisions") ."</h3>"; - $output .= "<table border=\"1\" cellpadding=\"2\" cellspacing=\"2\">"; - $output .= " <tr><th>". t("older revisions") ."</th><th colspan=\"3\">". t("operations") ."</th></tr>"; + + $header = array(t("older revisions"), array("colspan" => "3", "data" => t("operations"))); + foreach ($node->revisions as $key => $revision) { - $output .= " <tr><td>". t("revision #%r revised by %u on %d", array("%r" => $key, "%u" => format_name(user_load(array("uid" => $revision["uid"]))), "%d" => format_date($revision["timestamp"], "small"))) . ($revision["history"] ? "<br /><small>". $revision["history"] ."</small>" : "") ."</td><td>". l(t("view revision"), "node/view/$node->nid", array(), "revision=$key") ."</td><td>". l(t("rollback revision"), "admin/node/rollback+revision/$node->nid/$key") ."</td><td>". l(t("delete revision"), "admin/node/delete+revision/$node->nid/$key") ."</td></tr>"; + $rows[] = array(t("revision #%r revised by %u on %d", array("%r" => $key, "%u" => format_name(user_load(array("uid" => $revision["uid"]))), "%d" => format_date($revision["timestamp"], "small"))) . ($revision["history"] ? "<br /><small>". $revision["history"] ."</small>" : ""), l(t("view revision"), "node/view/$node->nid", array(), "revision=$key"), l(t("rollback revision"), "admin/node/rollback+revision/$node->nid/$key"), l(t("delete revision"), "admin/node/delete+revision/$node->nid/$key")); } - $output .= "</table>"; + $output .= table($header, $rows); } /* diff --git a/modules/node/node.module b/modules/node/node.module index 62f7feed7..5acc7c956 100644 --- a/modules/node/node.module +++ b/modules/node/node.module @@ -587,12 +587,13 @@ function node_admin_edit($node) { if ($node->revisions) { $output .= "<h3>". t("Edit revisions") ."</h3>"; - $output .= "<table border=\"1\" cellpadding=\"2\" cellspacing=\"2\">"; - $output .= " <tr><th>". t("older revisions") ."</th><th colspan=\"3\">". t("operations") ."</th></tr>"; + + $header = array(t("older revisions"), array("colspan" => "3", "data" => t("operations"))); + foreach ($node->revisions as $key => $revision) { - $output .= " <tr><td>". t("revision #%r revised by %u on %d", array("%r" => $key, "%u" => format_name(user_load(array("uid" => $revision["uid"]))), "%d" => format_date($revision["timestamp"], "small"))) . ($revision["history"] ? "<br /><small>". $revision["history"] ."</small>" : "") ."</td><td>". l(t("view revision"), "node/view/$node->nid", array(), "revision=$key") ."</td><td>". l(t("rollback revision"), "admin/node/rollback+revision/$node->nid/$key") ."</td><td>". l(t("delete revision"), "admin/node/delete+revision/$node->nid/$key") ."</td></tr>"; + $rows[] = array(t("revision #%r revised by %u on %d", array("%r" => $key, "%u" => format_name(user_load(array("uid" => $revision["uid"]))), "%d" => format_date($revision["timestamp"], "small"))) . ($revision["history"] ? "<br /><small>". $revision["history"] ."</small>" : ""), l(t("view revision"), "node/view/$node->nid", array(), "revision=$key"), l(t("rollback revision"), "admin/node/rollback+revision/$node->nid/$key"), l(t("delete revision"), "admin/node/delete+revision/$node->nid/$key")); } - $output .= "</table>"; + $output .= table($header, $rows); } /* |