diff options
| author | Steven Wittens <steven@10.no-reply.drupal.org> | 2004-10-20 16:57:35 +0000 |
|---|---|---|
| committer | Steven Wittens <steven@10.no-reply.drupal.org> | 2004-10-20 16:57:35 +0000 |
| commit | 474beff6407b37c56b87fa552c253b6ab27e5c94 (patch) | |
| tree | 73295f00c5690ec4bff3e0ecf916e6b324e25cb9 | |
| parent | 10f329c0579c24a23f9345a21aa00e56f6755a40 (diff) | |
| download | brdo-474beff6407b37c56b87fa552c253b6ab27e5c94.tar.gz brdo-474beff6407b37c56b87fa552c253b6ab27e5c94.tar.bz2 | |
Missing check if file upload fails.
| -rw-r--r-- | modules/upload.module | 12 | ||||
| -rw-r--r-- | modules/upload/upload.module | 12 |
2 files changed, 12 insertions, 12 deletions
diff --git a/modules/upload.module b/modules/upload.module index 624ab2a4f..67312f5e1 100644 --- a/modules/upload.module +++ b/modules/upload.module @@ -276,15 +276,15 @@ function upload_count_size($uid = 0) { function upload_save($node) { foreach ((array)$node->files as $key => $file) { if ($file->source && !$file->remove) { - // Insert new files: - $fid = db_next_id('{files}_fid'); - $file = file_save_upload($file, $file->filename); - // Clean up the session: unset($_SESSION['file_uploads'][$file->source]); - db_query("INSERT INTO {files} (fid, nid, filename, filepath, filemime, filesize, list) VALUES (%d, %d, '%s', '%s', '%s', %d, %d)", - $fid, $node->nid, $file->filename, $file->filepath, $file->filemime, $file->filesize, $node->list[$key]); + // Insert new files: + if ($file = file_save_upload($file, $file->filename)) { + $fid = db_next_id('{files}_fid'); + db_query("INSERT INTO {files} (fid, nid, filename, filepath, filemime, filesize, list) VALUES (%d, %d, '%s', '%s', '%s', %d, %d)", + $fid, $node->nid, $file->filename, $file->filepath, $file->filemime, $file->filesize, $node->list[$key]); + } } else { // Remove or update existing files: diff --git a/modules/upload/upload.module b/modules/upload/upload.module index 624ab2a4f..67312f5e1 100644 --- a/modules/upload/upload.module +++ b/modules/upload/upload.module @@ -276,15 +276,15 @@ function upload_count_size($uid = 0) { function upload_save($node) { foreach ((array)$node->files as $key => $file) { if ($file->source && !$file->remove) { - // Insert new files: - $fid = db_next_id('{files}_fid'); - $file = file_save_upload($file, $file->filename); - // Clean up the session: unset($_SESSION['file_uploads'][$file->source]); - db_query("INSERT INTO {files} (fid, nid, filename, filepath, filemime, filesize, list) VALUES (%d, %d, '%s', '%s', '%s', %d, %d)", - $fid, $node->nid, $file->filename, $file->filepath, $file->filemime, $file->filesize, $node->list[$key]); + // Insert new files: + if ($file = file_save_upload($file, $file->filename)) { + $fid = db_next_id('{files}_fid'); + db_query("INSERT INTO {files} (fid, nid, filename, filepath, filemime, filesize, list) VALUES (%d, %d, '%s', '%s', '%s', %d, %d)", + $fid, $node->nid, $file->filename, $file->filepath, $file->filemime, $file->filesize, $node->list[$key]); + } } else { // Remove or update existing files: |