- Patch #6000 by Goba: makes the short tip list a HTML list (as it is semantically

  expected) and gives proper class names to the long and short tip list, so if
  someone would like to reproduce the 'br' tagged version, he can do that with
  some CSS styles easily.  Assigned a dedicated class to the more-tips link, so it
  can be differently stlyed (with a different bullet, different link color or
  anyhow, as the theme designer desires).

2 files changed, 10 insertions, 10 deletions

diff --git a/modules/filter.module b/modules/filter.module
index 07661f300..3ff107f4d 100644
--- a/modules/filter.module
+++ b/modules/filter.module
@@ -295,19 +295,19 @@ function filter_tips_long() {
       $tiplist .= "<li id=\"filter-$name\">$tip</li>\n";
     }
   }
-  $output = "<ul class=\"compose-tips\">\n$tiplist\n</ul>\n";
+  $output = "<ul class=\"filter-tips-long\">\n$tiplist\n</ul>\n";
   print theme("page", $output, t('Compose Tips'));
 }
 
 function filter_tips_short() {
-  $output = '';
+  $tiplist = '';
   foreach (module_list() as $name) {
     if ($tip = module_invoke($name, 'help', 'filter#short-tip')) {
-      $output .= "$tip<br />";
+      $tiplist .= "<li>$tip</li>\n";
     }
   }
-  $output .= l(t('More information on formatting options'), 'filter/tips');
-  return $output;
+  $tiplist .= '<li class="more-tips">' . l(t('More information on formatting options'), 'filter/tips') . '</li>';
+  return "<ul class=\"filter-tips-short\">\n$tiplist\n</ul>\n";
 }
 
 ?>
diff --git a/modules/filter/filter.module b/modules/filter/filter.module
index 07661f300..3ff107f4d 100644
--- a/modules/filter/filter.module
+++ b/modules/filter/filter.module
@@ -295,19 +295,19 @@ function filter_tips_long() {
       $tiplist .= "<li id=\"filter-$name\">$tip</li>\n";
     }
   }
-  $output = "<ul class=\"compose-tips\">\n$tiplist\n</ul>\n";
+  $output = "<ul class=\"filter-tips-long\">\n$tiplist\n</ul>\n";
   print theme("page", $output, t('Compose Tips'));
 }
 
 function filter_tips_short() {
-  $output = '';
+  $tiplist = '';
   foreach (module_list() as $name) {
     if ($tip = module_invoke($name, 'help', 'filter#short-tip')) {
-      $output .= "$tip<br />";
+      $tiplist .= "<li>$tip</li>\n";
     }
   }
-  $output .= l(t('More information on formatting options'), 'filter/tips');
-  return $output;
+  $tiplist .= '<li class="more-tips">' . l(t('More information on formatting options'), 'filter/tips') . '</li>';
+  return "<ul class=\"filter-tips-short\">\n$tiplist\n</ul>\n";
 }
 
 ?>