summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDries Buytaert <dries@buytaert.net>2008-07-05 18:34:29 +0000
committerDries Buytaert <dries@buytaert.net>2008-07-05 18:34:29 +0000
commit55018d34e910a236f409c4d91fb05a1fe4ef5f87 (patch)
tree5ab3824d44f56337572b0fd4706712c5d4b0a829
parentaf24fca8e9d2496354966925f8c604fd8238d52b (diff)
downloadbrdo-55018d34e910a236f409c4d91fb05a1fe4ef5f87.tar.gz
brdo-55018d34e910a236f409c4d91fb05a1fe4ef5f87.tar.bz2
- Patch #257537 by dopry: made file_check_directory less verbose on success.
-rw-r--r--includes/file.inc7
1 files changed, 2 insertions, 5 deletions
diff --git a/includes/file.inc b/includes/file.inc
index 2de64c10b..ef9989500 100644
--- a/includes/file.inc
+++ b/includes/file.inc
@@ -139,12 +139,12 @@ function file_check_directory(&$directory, $mode = 0, $form_item = NULL) {
// Check if directory exists.
if (!is_dir($directory)) {
if (($mode & FILE_CREATE_DIRECTORY) && @mkdir($directory)) {
- drupal_set_message(t('The directory %directory has been created.', array('%directory' => $directory)));
@chmod($directory, 0775); // Necessary for non-webserver users.
}
else {
if ($form_item) {
form_set_error($form_item, t('The directory %directory does not exist.', array('%directory' => $directory)));
+ watchdog('file system', 'The directory %directory does not exist.', array('%directory' => $directory), WATCHDOG_ERROR);
}
return FALSE;
}
@@ -152,10 +152,7 @@ function file_check_directory(&$directory, $mode = 0, $form_item = NULL) {
// Check to see if the directory is writable.
if (!is_writable($directory)) {
- if (($mode & FILE_MODIFY_PERMISSIONS) && @chmod($directory, 0775)) {
- drupal_set_message(t('The permissions of directory %directory have been changed to make it writable.', array('%directory' => $directory)));
- }
- else {
+ if (($mode & FILE_MODIFY_PERMISSIONS) && !@chmod($directory, 0775)) {
form_set_error($form_item, t('The directory %directory is not writable', array('%directory' => $directory)));
watchdog('file system', 'The directory %directory is not writable, because it does not have the correct permissions set.', array('%directory' => $directory), WATCHDOG_ERROR);
return FALSE;