summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAngie Byron <webchick@24967.no-reply.drupal.org>2010-06-08 05:16:29 +0000
committerAngie Byron <webchick@24967.no-reply.drupal.org>2010-06-08 05:16:29 +0000
commit8e8d8274d607307ac3d9bf9883f068a7b9d17542 (patch)
treea7ae953667a059309ccab66cebdf42629bdc3ea3
parentb5e696702df6df3a0bd09f44758bd8c73004c657 (diff)
downloadbrdo-8e8d8274d607307ac3d9bf9883f068a7b9d17542.tar.gz
brdo-8e8d8274d607307ac3d9bf9883f068a7b9d17542.tar.bz2
#668640 by casey, aspilicious, et al: Re-implement Overlay without jQuery UI Dialog; massive performance improvement, helps address several critical issues.
-rw-r--r--modules/dashboard/dashboard.js2
-rw-r--r--modules/overlay/overlay-child.css142
-rw-r--r--modules/overlay/overlay-child.js122
-rw-r--r--modules/overlay/overlay-parent.css175
-rw-r--r--modules/overlay/overlay-parent.js1101
-rw-r--r--modules/overlay/overlay.module69
-rw-r--r--modules/overlay/overlay.tpl.php37
-rw-r--r--modules/toolbar/toolbar.js5
-rw-r--r--modules/toolbar/toolbar.module10
-rw-r--r--themes/garland/style.css28
10 files changed, 825 insertions, 866 deletions
diff --git a/modules/dashboard/dashboard.js b/modules/dashboard/dashboard.js
index 5ac4de055..dc9019d85 100644
--- a/modules/dashboard/dashboard.js
+++ b/modules/dashboard/dashboard.js
@@ -7,7 +7,7 @@
Drupal.behaviors.dashboard = {
attach: function (context, settings) {
$('#dashboard', context).once(function () {
- $(this).prepend('<div class="customize"><ul class="action-links"><li><a href="#">' + Drupal.t('Customize dashboard') + '</a></li></ul><div class="canvas"></div></div>');
+ $(this).prepend('<div class="customize clearfix"><ul class="action-links"><li><a href="#">' + Drupal.t('Customize dashboard') + '</a></li></ul><div class="canvas"></div></div>');
$('.customize .action-links a', this).click(Drupal.behaviors.dashboard.enterCustomizeMode);
});
Drupal.behaviors.dashboard.addPlaceholders();
diff --git a/modules/overlay/overlay-child.css b/modules/overlay/overlay-child.css
new file mode 100644
index 000000000..c8924b10f
--- /dev/null
+++ b/modules/overlay/overlay-child.css
@@ -0,0 +1,142 @@
+
+html.js {
+ background: transparent !important;
+ overflow-y: scroll;
+}
+html.js body {
+ background: transparent !important;
+ padding: 20px 0;
+}
+
+#overlay {
+ margin: 0 auto;
+ min-height: 100px;
+ min-width: 700px;
+ position: relative;
+ padding: .2em;
+ padding-right: 26px;
+ width: 78%;
+}
+#overlay-titlebar {
+ padding: 0 20px;
+ position: relative;
+ white-space: nowrap;
+ z-index: 100;
+}
+#overlay-content {
+ background: #fff;
+ clear: both;
+ color: #000;
+ padding: .5em 1em;
+ position: relative;
+}
+
+#overlay-title-wrapper {
+ overflow: hidden;
+}
+#overlay-title {
+ color: #fff;
+ float: left;
+ font-family: Verdana,sans-serif;
+ font-size: 20px;
+ margin: 0;
+ padding: 0.3em 0;
+}
+#overlay-title:active,
+#overlay-title:focus {
+ outline: 0;
+}
+
+#overlay-close-wrapper {
+ position: absolute;
+ right: 0;
+}
+#overlay-close,
+#overlay-close:hover {
+ background: transparent url(images/close.png) no-repeat;
+ -moz-border-radius-topleft: 0;
+ -webkit-border-top-left-radius: 0;
+ border-top-left-radius: 0;
+ display: block;
+ height: 26px;
+ margin: 0;
+ padding: 0;
+ /* Replace with position:fixed to get a scrolling close button. */
+ position: absolute;
+ width: 26px;
+}
+#overlay-title:active,
+#overlay-close:hover,
+#overlay-close:focus {
+ padding: 0;
+}
+#overlay-close span {
+ display: none;
+}
+
+/**
+ * Tabs on the overlay.
+ */
+#overlay-tabs {
+ line-height: 27px;
+ margin: -27px 0 0 0;
+ position: absolute;
+ right: 20px;
+ text-transform: uppercase;
+}
+#overlay-tabs li {
+ display: inline;
+ list-style: none;
+ margin: 0 0 0 -3px;
+ padding: 0;
+}
+#overlay-tabs li a,
+#overlay-tabs li a:active,
+#overlay-tabs li a:visited,
+#overlay-tabs li a:hover {
+ background-color: #a6a7a2;
+ -moz-border-radius: 8px 8px 0 0;
+ -webkit-border-top-left-radius: 8px;
+ -webkit-border-top-right-radius: 8px;
+ border-radius: 8px 8px 0 0;
+ color: #000;
+ display: inline-block;
+ font-size: 11px;
+ font-weight: bold;
+ margin: 0 0 2px 0;
+ outline: 0;
+ padding: 0 14px;
+ text-decoration: none;
+}
+#overlay-tabs li.active a,
+#overlay-tabs li.active a.active,
+#overlay-tabs li.active a:active,
+#overlay-tabs li.active a:visited {
+ background-color: #fff;
+ margin: 0;
+ padding-bottom: 2px;
+}
+#overlay-tabs li a:focus,
+#overlay-tabs li a:hover {
+ color: #fff;
+}
+#overlay-tabs li.active a:focus,
+#overlay-tabs li.active a:hover {
+ color: #000;
+}
+
+/**
+ * Add to shortcuts link
+ */
+#overlay-titlebar .add-or-remove-shortcuts {
+ padding-top: 0.9em;
+}
+
+/**
+ * IE6 shows elements with position:fixed as position:static so replace
+ * it with position:absolute;
+ */
+* html #overlay-close,
+* html #overlay-close:hover {
+ position: absolute;
+}
diff --git a/modules/overlay/overlay-child.js b/modules/overlay/overlay-child.js
index 8e526b8a3..f89645b97 100644
--- a/modules/overlay/overlay-child.js
+++ b/modules/overlay/overlay-child.js
@@ -3,30 +3,23 @@
(function ($) {
/**
- * Overlay object for child windows.
- */
-Drupal.overlayChild = Drupal.overlayChild || { processed: false, behaviors: {} };
-
-/**
* Attach the child dialog behavior to new content.
*/
Drupal.behaviors.overlayChild = {
attach: function (context, settings) {
- var self = Drupal.overlayChild;
- var settings = settings.overlayChild || {};
-
// Make sure this behavior is not processed more than once.
- if (self.processed) {
+ if (this.processed) {
return;
}
- self.processed = true;
+ this.processed = true;
- // If we cannot reach the parent window, then we have nothing else to do
- // here.
- if (!$.isPlainObject(parent.Drupal) || !$.isPlainObject(parent.Drupal.overlay)) {
- return;
+ // If we cannot reach the parent window, break out of the overlay.
+ if (!parent.Drupal || !parent.Drupal.overlay) {
+ window.location = window.location.href.replace(/([?&]?)render=overlay&?/g, '$1').replace(/\?$/, '');
}
+ var settings = settings.overlayChild || {};
+
// If a form has been submitted successfully, then the server side script
// may have decided to tell us the parent window to close the popup dialog.
if (settings.closeOverlay) {
@@ -34,12 +27,11 @@ Drupal.behaviors.overlayChild = {
// Use setTimeout to close the child window from a separate thread,
// because the current one is busy processing Drupal behaviors.
setTimeout(function () {
- // We need to store the parent variable locally because it will
- // disappear as soon as we close the iframe.
- var p = parent;
- p.Drupal.overlay.close();
if (typeof settings.redirect == 'string') {
- p.Drupal.overlay.redirect(settings.redirect);
+ parent.Drupal.overlay.redirect(settings.redirect);
+ }
+ else {
+ parent.Drupal.overlay.close();
}
}, 1);
return;
@@ -54,12 +46,24 @@ Drupal.behaviors.overlayChild = {
// Ok, now we can tell the parent window we're ready.
parent.Drupal.overlay.bindChild(window);
+ // IE8 crashes on certain pages if this isn't called; reason unknown.
+ window.scrollTo(window.scrollX, window.scrollY);
+
// Attach child related behaviors to the iframe document.
- self.attachBehaviors(context, settings);
+ Drupal.overlayChild.attachBehaviors(context, settings);
}
};
/**
+ * Overlay object for child windows.
+ */
+Drupal.overlayChild = Drupal.overlayChild || {
+ behaviors: {}
+};
+
+Drupal.overlayChild.prototype = {};
+
+/**
* Attach child related behaviors to the iframe document.
*/
Drupal.overlayChild.attachBehaviors = function (context, settings) {
@@ -69,16 +73,6 @@ Drupal.overlayChild.attachBehaviors = function (context, settings) {
};
/**
- * Scroll to the top of the page.
- *
- * This makes the overlay visible to users even if it is not as tall as the
- * previously shown overlay was.
- */
-Drupal.overlayChild.behaviors.scrollToTop = function (context, settings) {
- window.scrollTo(0, 0);
-};
-
-/**
* Capture and handle clicks.
*
* Instead of binding a click event handler to every link we bind one to the
@@ -86,7 +80,7 @@ Drupal.overlayChild.behaviors.scrollToTop = function (context, settings) {
* to bind their own handlers to links and also to prevent overlay's handling.
*/
Drupal.overlayChild.behaviors.addClickHandler = function (context, settings) {
- $(document).bind('click.overlay-event', parent.Drupal.overlay.clickHandler);
+ $(document).bind('click.drupal-overlay mouseup.drupal-overlay', $.proxy(parent.Drupal.overlay, 'eventhandlerOverrideLink'));
};
/**
@@ -111,4 +105,70 @@ Drupal.overlayChild.behaviors.parseForms = function (context, settings) {
});
};
+/**
+ * Replace the overlay title with a message while loading another page.
+ */
+Drupal.overlayChild.behaviors.loading = function (context, settings) {
+ var $title;
+ var text = Drupal.t('Loading');
+ var dots = '';
+
+ $(document).bind('drupalOverlayBeforeLoad.drupal-overlay.drupal-overlay-child-loading', function () {
+ $title = $('#overlay-title').text(text);
+ var id = setInterval(function () {
+ dots = (dots.length > 10) ? '' : dots + '.';
+ $title.text(text + dots);
+ }, 500);
+ });
+};
+
+/**
+ * Switch active tab immediately.
+ */
+Drupal.overlayChild.behaviors.tabs = function (context, settings) {
+ var $tabsLinks = $('#overlay-tabs > li > a');
+
+ $('#overlay-tabs > li > a').bind('click.drupal-overlay', function () {
+ var active_tab = Drupal.t('(active tab)');
+ $tabsLinks.parent().siblings().removeClass('active').find('element-invisible:contains(' + active_tab + ')').appendTo(this);
+ $(this).parent().addClass('active');
+ });
+};
+
+/**
+ * If the shortcut add/delete button exists, move it to the overlay titlebar.
+ */
+Drupal.overlayChild.behaviors.shortcutAddLink = function (context, settings) {
+ // Remove any existing shortcut button markup from the titlebar.
+ $('#overlay-titlebar').find('.add-or-remove-shortcuts').remove();
+ // If the shortcut add/delete button exists, move it to the titlebar.
+ var $addToShortcuts = $('.add-or-remove-shortcuts');
+ if ($addToShortcuts.length) {
+ $addToShortcuts.insertAfter('#overlay-title');
+ }
+
+ $(document).bind('drupalOverlayBeforeLoad.drupal-overlay.drupal-overlay-child-loading', function () {
+ $('#overlay-titlebar').find('.add-or-remove-shortcuts').remove();
+ });
+};
+
+/**
+ * Use displacement from parent window.
+ */
+Drupal.overlayChild.behaviors.alterTableHeaderOffset = function (context, settings) {
+ if (Drupal.settings.tableHeaderOffset) {
+ Drupal.overlayChild.prevTableHeaderOffset = Drupal.settings.tableHeaderOffset;
+ }
+ Drupal.settings.tableHeaderOffset = 'Drupal.overlayChild.tableHeaderOffset';
+};
+
+/**
+ * Callback for Drupal.settings.tableHeaderOffset.
+ */
+Drupal.overlayChild.tableHeaderOffset = function () {
+ var topOffset = Drupal.overlayChild.prevTableHeaderOffset ? eval(Drupal.overlayChild.prevTableHeaderOffset + '()') : 0;
+
+ return topOffset + parseInt($(document.body).css('marginTop'));
+};
+
})(jQuery);
diff --git a/modules/overlay/overlay-parent.css b/modules/overlay/overlay-parent.css
index 9b1389bd1..e71cd6648 100644
--- a/modules/overlay/overlay-parent.css
+++ b/modules/overlay/overlay-parent.css
@@ -1,165 +1,48 @@
/* $Id$ */
-/**
- * ui-dialog overlay.
- */
-.ui-widget-overlay {
- opacity: 1;
- filter: none;
- /* Using a transparent png renders faster than using opacity */
- background: transparent url(images/background.png) repeat;
-}
-
-body.overlay-autofit {
- overflow-y: scroll;
+html.overlay-open,
+html.overlay-open body {
+ height: 100%;
+ overflow: hidden;
}
-/**
- * Overlay wrapper.
- */
-#overlay-wrapper {
- position: absolute;
- top: 0;
+#overlay-container,
+.overlay-modal-background,
+.overlay-element {
+ height: 100%;
left: 0;
+ position: fixed;
+ top: 0;
width: 100%;
- z-index: 501;
- padding: 20px 0 15px 0;
-}
-
-/**
- * jQuery UI Dialog classes.
- */
-.overlay {
- position: static;
- padding-right: 26px;
- margin: 0 auto;
- width: 88%;
- min-width: 700px;
- min-height: 100px;
+ z-index: 500;
}
-.overlay.ui-widget-content,
-.overlay .ui-widget-header {
- background: none;
- border: none;
-}
-
-.overlay .ui-dialog-titlebar {
- white-space: nowrap;
- padding: 0 20px;
+.overlay-modal-background {
+ /* Using a transparent png renders faster than using opacity */
+ background: transparent url(images/background.png) repeat;
}
-.overlay .ui-dialog-title {
- margin: 0;
- padding: 0.3em 0;
- color: #fff;
- font-size: 20px;
-}
-.overlay .ui-dialog-title:active,
-.overlay .ui-dialog-title:focus {
- outline: 0;
-}
-.overlay .ui-dialog-titlebar-close,
-.overlay .ui-dialog-titlebar-close:hover {
- display: block;
- right: -25px;
- top: 100%;
- margin: 0;
- border: none;
- padding: 0;
- width: 26px;
- height: 36px;
- background: transparent url(images/close.png) no-repeat;
- border-top-left-radius: 0;
- -moz-border-radius-topleft: 0;
- -webkit-border-top-left-radius: 0;
-}
-.overlay .ui-dialog-titlebar-close span {
- display: none;
+.overlay-element {
+ background: transparent;
+ left: -200%;
+ z-index: 501;
}
-.overlay .ui-dialog-content {
- color: #292929;
- background-color: #f8f8f8;
+.overlay-element.overlay-active {
+ left: 0;
}
-/**
- * Overlay content.
- */
-.overlay #overlay-container {
- margin: 0;
- padding: 0;
- width: 100%;
- overflow: visible;
- background: #fff;
-}
-.overlay #overlay-element {
- overflow: hidden;
- width: 100%;
- height: 100%;
+html.overlay-open .displace-top,
+html.overlay-open .displace-bottom {
+ z-index: 600;
}
/**
- * Tabs on the overlay.
+ * IE6 shows elements with position:fixed as position:static so replace
+ * it with position:absolute;
*/
-.overlay .ui-dialog-titlebar ul {
+* html #overlay-container,
+* html .overlay-modal-background,
+* html .overlay-element
+{
position: absolute;
- right: 20px;
- bottom: 0;
- margin: 0;
- line-height: 27px;
- text-transform: uppercase;
-}
-.overlay .ui-dialog-titlebar ul li {
- display: inline;
- list-style: none;
- margin: 0 0 0 -3px;
- padding: 0;
-}
-
-.overlay .ui-dialog-titlebar ul li a,
-.overlay .ui-dialog-titlebar ul li a:active,
-.overlay .ui-dialog-titlebar ul li a:visited,
-.overlay .ui-dialog-titlebar ul li a:hover {
- display: inline-block;
- background-color: #a6a7a2;
- border-radius: 8px 8px 0 0;
- -moz-border-radius: 8px 8px 0 0;
- -webkit-border-top-left-radius: 8px;
- -webkit-border-top-right-radius: 8px;
- color: #000;
- font-weight: bold;
- padding: 0 14px;
- text-decoration: none;
- font-size: 11px;
- margin: 0;
-}
-.overlay .ui-dialog-titlebar ul li.active a,
-.overlay .ui-dialog-titlebar ul li.active a.active,
-.overlay .ui-dialog-titlebar ul li.active a:active,
-.overlay .ui-dialog-titlebar ul li.active a:visited {
- background-color: #fff;
- margin: 0;
-}
-.overlay .ui-dialog-titlebar ul li a:hover {
- color: #fff;
-}
-.overlay .ui-dialog-titlebar ul li.active a:hover {
- color: #000;
-}
-
-/**
- * Add to shortcuts link
- */
-.overlay div.add-or-remove-shortcuts {
- padding-top: 0.9em;
-}
-
-/**
- * IE 6 Fix.
- *
- * Use filter to support transparency in IE6 for the overlay background.
- */
-* html .ui-widget-overlay {
- filter: progid:DXImageTransform.Microsoft.AlphaImageLoader(src='modules/overlay/images/background.png', sizingMethod='scale');
- background: none;
}
diff --git a/modules/overlay/overlay-parent.js b/modules/overlay/overlay-parent.js
index 64219b782..7f021ac8e 100644
--- a/modules/overlay/overlay-parent.js
+++ b/modules/overlay/overlay-parent.js
@@ -4,28 +4,27 @@
/**
* Open the overlay, or load content into it, when an admin link is clicked.
- *
- * http://docs.jquery.com/Namespaced_Events
*/
Drupal.behaviors.overlayParent = {
attach: function (context, settings) {
- // Make sure the onhashchange handling below is only processed once.
if (this.processed) {
return;
}
this.processed = true;
- // Bind event handlers to the parent window.
$(window)
- // When the hash (URL fragment) changes, open the overlay if needed.
- .bind('hashchange.overlay-event', Drupal.overlay.hashchangeHandler)
- // Trigger the hashchange event once, after the page is loaded, so that
- // permalinks open the overlay.
- .trigger('hashchange.overlay-event');
- // Instead of binding a click event handler to every link we bind one to the
- // document and only handle events that bubble up. This allows other scripts
- // to bind their own handlers to links and also to prevent overlay's handling.
- $(document).bind('click.overlay-event', Drupal.overlay.clickHandler);
+ // When the hash (URL fragment) changes, open the overlay if needed.
+ .bind('hashchange.drupal-overlay', $.proxy(Drupal.overlay, 'eventhandlerOperateByURLFragment'))
+ // Trigger the hashchange handler once, after the page is loaded, so that
+ // permalinks open the overlay.
+ .triggerHandler('hashchange.drupal-overlay');
+
+ $(document)
+ // Instead of binding a click event handler to every link we bind one to
+ // the document and only handle events that bubble up. This allows other
+ // scripts to bind their own handlers to links and also to prevent
+ // overlay's handling.
+ .bind('click.drupal-overlay mouseup.drupal-overlay', $.proxy(Drupal.overlay, 'eventhandlerOverrideLink'));
}
};
@@ -40,228 +39,93 @@ Drupal.behaviors.overlayParent = {
* - drupalOverlayClose: This event is triggered when the overlay is closed.
* - drupalOverlayBeforeLoad: This event is triggered right before a new URL
* is loaded into the overlay.
+ * - drupalOverlayReady: This event is triggered when the DOM of the overlay
+ * child document is fully loaded.
* - drupalOverlayLoad: This event is triggered when the overlay is finished
* loading.
+ * - drupalOverlayResize: This event is triggered when the overlay is being
+ * resized to match the parent window.
*/
Drupal.overlay = Drupal.overlay || {
- options: {},
isOpen: false,
isOpening: false,
isClosing: false,
- isLoading: false,
-
- resizeTimeoutID: null,
- lastHeight: 0,
-
- $wrapper: null,
- $dialog: null,
- $dialogTitlebar: null,
- $container: null,
- $iframe: null,
-
- $iframeWindow: null,
- $iframeDocument: null,
- $iframeBody: null
+ isLoading: false
};
+Drupal.overlay.prototype = {};
+
/**
- * Open an overlay.
- *
- * Ensure that only one overlay is opened ever. Use Drupal.overlay.load() if
- * the overlay is already open but a new page needs to be opened.
+ * Open the overlay.
*
- * @param options
- * Properties of the overlay to open:
- * - url: the URL of the page to open in the overlay.
- * - width: width of the overlay in pixels.
- * - height: height of the overlay in pixels.
- * - autoFit: boolean indicating whether the overlay should be resized to
- * fit the contents of the document loaded.
- * - customDialogOptions: an object with custom jQuery UI Dialog options.
+ * @param url
+ * The URL of the page to open in the overlay.
*
* @return
- * If the overlay was opened true, otherwise false.
+ * TRUE if the overlay was opened, FALSE otherwise.
*/
-Drupal.overlay.open = function (options) {
- var self = this;
-
+Drupal.overlay.open = function (url) {
// Just one overlay is allowed.
- if (self.isOpen || self.isOpening) {
- return false;
+ if (this.isOpen || this.isOpening) {
+ return this.load(url);
}
- self.isOpening = true;
-
- var defaultOptions = {
- url: options.url,
- width: options.width,
- height: options.height,
- autoFit: (options.autoFit == undefined || options.autoFit),
- customDialogOptions: options.customDialogOptions || {}
- };
-
- self.options = $.extend(defaultOptions, options);
+ this.isOpening = true;
// Create the dialog and related DOM elements.
- self.create();
+ this.create();
- // Open the dialog.
- self.$container.dialog('open');
+ this.isOpening = false;
+ this.isOpen = true;
+ $(document.documentElement).addClass('overlay-open');
// Allow other scripts to respond to this event.
$(document).trigger('drupalOverlayOpen');
- return true;
+ return this.load(url);
};
/**
* Create the underlying markup and behaviors for the overlay.
- *
- * Reuses jQuery UI's dialog component to construct the overlay markup and
- * behaviors, sanitizing the options previously set in self.options.
*/
Drupal.overlay.create = function () {
- var self = this;
- var $window = $(window);
- var $body = $('body');
-
- var delayedOuterResize = function() {
- setTimeout(self.outerResize, 1);
- };
-
- // Open callback for jQuery UI Dialog.
- var dialogOpen = function () {
- // Unbind the keypress handler installed by ui.dialog itself.
- // IE does not fire keypress events for some non-alphanumeric keys
- // such as the tab character. http://www.quirksmode.org/js/keys.html
- // Also, this is not necessary here because we need to deal with an
- // iframe element that contains a separate window.
- // We'll try to provide our own behavior from bindChild() method.
- self.$dialog.unbind('keypress.ui-dialog');
-
- // Add title to close button features for accessibility.
- self.$dialogTitlebar.find('.ui-dialog-titlebar-close').attr('title', Drupal.t('Close'));
-
- // Replace the title span element with an h1 element for accessibility.
- var $dialogTitle = self.$dialogTitlebar.find('.ui-dialog-title');
- $dialogTitle.replaceWith(Drupal.theme('overlayTitleHeader', $dialogTitle.html()));
-
- // Wrap the dialog into a div so we can center it using CSS.
- self.$dialog.wrap(Drupal.theme('overlayWrapper'));
- self.$wrapper = self.$dialog.parent();
-
- self.$dialog.css({
- // Remove some CSS properties added by ui.dialog itself.
- position: '', left: '', top: '', height: ''
- });
-
- // Add a class to the body to indicate the overlay is open.
- $body.addClass('overlay-open');
-
- // Adjust overlay size when window is resized.
- $window.bind('resize.overlay-event', delayedOuterResize);
-
- if (self.options.autoFit) {
- $body.addClass('overlay-autofit');
- }
- else {
- // Add scrollbar to the iframe when autoFit is disabled.
- self.$iframe.css('overflow', 'auto').attr('scrolling', 'yes');
- }
-
- // Compute initial dialog size.
- self.outerResize();
-
- // Load the document on hidden iframe (see bindChild method).
- self.load(self.options.url);
-
- if ($.isFunction(self.options.onOverlayOpen)) {
- self.options.onOverlayOpen(self);
- }
-
- self.isOpen = true;
- self.isOpening = false;
- };
-
- // Before close callback for jQuery UI Dialog.
- var dialogBeforeClose = function () {
- // Prevent double execution when close is requested more than once.
- if (!self.isOpen || self.isClosing) {
- return false;
- }
-
- // Allow other scripts to decide if the overlay can be closed. If an event-
- // handler returns false the overlay won't be closed. The external script
- // should call Drupal.overlay.close() again when it is ready for closing.
- var event = $.Event('drupalOverlayBeforeClose');
- $(document).trigger(event);
- if (event.isDefaultPrevented()) {
- return false;
- }
-
- self.isClosing = true;
-
- // Stop all animations.
- $window.unbind('resize.overlay-event', delayedOuterResize);
- clearTimeout(self.resizeTimeoutID);
- };
-
- // Close callback for jQuery UI Dialog.
- var dialogClose = function () {
- $(document).unbind('keydown.overlay-event');
-
- $body.removeClass('overlay-open').removeClass('overlay-autofit');
-
- // When the iframe is still loading don't destroy it immediately but after
- // the content is loaded (see self.load).
- if (!self.isLoading) {
- // As some browsers (webkit) fire a load event when the iframe is removed,
- // load handlers need to be unbound before removing the iframe.
- self.$iframe.unbind('load.overlay-event');
- self.destroy();
- }
-
- self.isOpen = false;
- self.isClosing = false;
-
- self.lastHeight = 0;
-
- // Allow other scripts to respond to this event.
- $(document).trigger('drupalOverlayClose');
- };
-
- // Default jQuery UI Dialog options.
- var dialogOptions = {
- autoOpen: false,
- closeOnEscape: true,
- dialogClass: 'overlay',
- draggable: false,
- modal: true,
- resizable: false,
- title: Drupal.t('Loading...'),
- zIndex: 500,
-
- // When the width is not set, use an empty string instead, so that CSS will
- // be able to handle it.
- width: self.options.width || '',
- height: self.options.height,
-
- open: dialogOpen,
- beforeclose: dialogBeforeClose,
- close: dialogClose
- };
-
- // Create the overlay container and iframe.
- self.$iframe = $(Drupal.theme('overlayElement'));
- self.$container = $(Drupal.theme('overlayContainer')).append(self.$iframe);
-
- // Allow external script to override the default jQuery UI Dialog options.
- $.extend(dialogOptions, self.options.customDialogOptions);
-
- // Create the jQuery UI Dialog.
- self.$container.dialog(dialogOptions);
- // Cache dialog selector.
- self.$dialog = self.$container.parents('.' + dialogOptions.dialogClass);
- self.$dialogTitlebar = self.$dialog.find('.ui-dialog-titlebar');
+ this.$container = $(Drupal.theme('overlayContainer'))
+ .appendTo(document.body);
+
+ // Overlay uses transparent iframes that cover the full parent window.
+ // When the overlay is open the scrollbar of the parent window is hidden.
+ // Because some browsers show a white iframe background for a short moment
+ // while loading a page into an iframe, overlay uses two iframes. By loading
+ // the page in a hidden (inactive) iframe the user doesn't see the white
+ // background. When the page is loaded the active and inactive iframes
+ // are switched.
+ this.activeFrame = this.$iframeA = $(Drupal.theme('overlayElement'))
+ .appendTo(this.$container);
+
+ this.inactiveFrame = this.$iframeB = $(Drupal.theme('overlayElement'))
+ .appendTo(this.$container);
+
+ this.$iframeA.bind('load.drupal-overlay', { self: this.$iframeA[0], sibling: this.$iframeB }, $.proxy(this, 'loadChild'));
+ this.$iframeB.bind('load.drupal-overlay', { self: this.$iframeB[0], sibling: this.$iframeA }, $.proxy(this, 'loadChild'));
+
+ // Add a second class "drupal-overlay-open" to indicate these event handlers
+ // should only be bound when the overlay is open.
+ var eventClass = '.drupal-overlay.drupal-overlay-open';
+ $(window)
+ .bind('resize' + eventClass, $.proxy(this, 'eventhandlerOuterResize'));
+ $(document)
+ .bind('drupalOverlayLoad' + eventClass, $.proxy(this, 'eventhandlerOuterResize'))
+ .bind('drupalOverlayReady' + eventClass +
+ ' drupalOverlayClose' + eventClass, $.proxy(this, 'eventhandlerSyncURLFragment'))
+ .bind('drupalOverlayBeforeClose' + eventClass +
+ ' drupalOverlayBeforeLoad' + eventClass +
+ ' drupalOverlayResize' + eventClass, $.proxy(this, 'eventhandlerDispatchEvent'))
+ .bind('keydown' + eventClass, $.proxy(this, 'eventhandlerRestrictKeyboardNavigation'));
+
+ if ($('.overlay-displace-top, .overlay-displace-bottom').length) {
+ $(document)
+ .bind('drupalOverlayResize' + eventClass, $.proxy(this, 'eventhandlerAlterDisplacedElements'))
+ .bind('drupalOverlayClose' + eventClass, $.proxy(this, 'eventhandlerRestoreDisplacedElements'));
+ }
};
/**
@@ -269,318 +133,163 @@ Drupal.overlay.create = function () {
*
* Use this method to change the URL being loaded in the overlay if it is
* already open.
+ *
+ * @return
+ * TRUE if URL is loaded into the overlay, FALSE otherwise.
*/
Drupal.overlay.load = function (url) {
- var self = this;
- var iframeElement = self.$iframe.get(0);
-
- self.isLoading = true;
-
- // Change the overlay title.
- self.$container.dialog('option', 'title', Drupal.t('Loading...'));
- // Remove any existing shortcut button markup in the title section.
- self.$dialogTitlebar.find('.add-or-remove-shortcuts').remove();
-
- // Remove any existing tabs in the title section, but only if requested url
- // is not one of those tabs. If the latter, set that tab active. Only check
- // for tabs when the overlay is not empty.
- if (self.$iframeBody) {
- var urlPath = self.getPath(url);
-
- // Get the primary tabs
- var $tabs = self.$dialogTitlebar.find('ul');
- var $tabsLinks = $tabs.find('> li > a');
-
- // Check if clicked on a primary tab
- var $activeLink = $tabsLinks.filter(function () { return self.getPath(this) == urlPath; });
-
- if ($activeLink.length) {
- var active_tab = Drupal.t('(active tab)');
- $tabsLinks.parent().removeClass('active').find('element-invisible:contains(' + active_tab + ')').appendTo($activeLink);
- $activeLink.parent().addClass('active');
- removeTabs = false;
- }
- else {
- // Get the secondary tabs
- var $secondary = self.$iframeBody.find('ul.secondary');
- var $secondaryLinks = $secondary.find('> li > a');
-
- // Check if clicked on a secondary tab
- var $activeLinkSecondary = $secondaryLinks.filter(function () { return self.getPath(this) == urlPath; });
-
- if ($activeLinkSecondary.length) {
- var active_tab = Drupal.t('(active tab)');
- $secondaryLinks.parent().removeClass('active').find('element-invisible:contains(' + active_tab + ')').appendTo($activeLinkSecondary);
- $activeLinkSecondary.parent().addClass('active');
- removeTabs = false;
- }
- else {
- $tabs.remove();
- }
- }
+ if (!this.isOpen) {
+ return false;
}
- self.$iframeWindow = null;
- self.$iframeDocument = null;
- self.$iframeBody = null;
-
- // No need to resize while loading.
- clearTimeout(self.resizeTimeoutID);
-
// Allow other scripts to respond to this event.
$(document).trigger('drupalOverlayBeforeLoad');
- // While the overlay is loading, we remove the loaded class from the dialog.
- // After the loading is finished, the loaded class is added back. The loaded
- // class is being used to hide the iframe while loading.
- // See overlay-parent.css .overlay-loaded #overlay-element.
- self.$dialog.removeClass('overlay-loaded');
- self.$iframe.once('overlay-event-load')
- .bind('load.overlay-event', function () {
- self.isLoading = false;
-
- // Only continue when overlay is still open and not closing.
- if (self.isOpen && !self.isClosing) {
- self.$dialog.addClass('overlay-loaded');
-
- // Allow other scripts to respond to this event.
- $(document).trigger('drupalOverlayLoad');
- }
- else {
- self.destroy();
- }
- });
+ $(document.documentElement).addClass('overlay-loading');
- // Get the document object of the iframe window.
- // See http://xkr.us/articles/dom/iframe-document/.
- var iframeDocument = (iframeElement.contentWindow || iframeElement.contentDocument);
- if (iframeDocument.document) {
- iframeDocument = iframeDocument.document;
- }
+ // The contentDocument property is not supported in IE until IE8.
+ var iframeDocument = this.inactiveFrame[0].contentDocument || this.inactiveFrame[0].contentWindow.document;
// location.replace doesn't create a history entry. location.href does.
// In this case, we want location.replace, as we're creating the history
// entry using URL fragments.
iframeDocument.location.replace(url);
+
+ // Immediately move the focus to the iframe.
+ this.inactiveFrame.focus();
+ return true;
};
/**
* Close the overlay and remove markup related to it from the document.
+ *
+ * @return
+ * TRUE if the overlay was closed, FALSE otherwise.
*/
Drupal.overlay.close = function () {
- return this.$container.dialog('close');
+ // Prevent double execution when close is requested more than once.
+ if (!this.isOpen || this.isClosing) {
+ return false;
+ }
+
+ // Allow other scripts to respond to this event.
+ var event = $.Event('drupalOverlayBeforeClose');
+ $(document).trigger(event);
+ // If a handler returned false, the close will be prevented.
+ if (event.isDefaultPrevented()) {
+ return false;
+ }
+
+ this.isClosing = true;
+ this.isOpen = false;
+ $(document.documentElement).removeClass('overlay-open');
+
+ // Allow other scripts to respond to this event.
+ $(document).trigger('drupalOverlayClose');
+
+ // When the iframe is still loading don't destroy it immediately but after
+ // the content is loaded (see Drupal.overlay.loadChild).
+ if (!this.isLoading) {
+ this.destroy();
+ this.isClosing = false;
+ }
+ return true;
};
/**
* Destroy the overlay.
*/
Drupal.overlay.destroy = function () {
- var self = this;
+ $([document, window]).unbind('.drupal-overlay-open');
+ this.$iframeA.unbind('.drupal-overlay');
+ this.$iframeB.unbind('.drupal-overlay');
+ this.$container.remove();
- self.$container.dialog('destroy').remove();
- self.$wrapper.remove();
+ this.$container = null;
+ this.$iframeA = null;
+ this.$iframeB = null;
- self.$wrapper = null;
- self.$dialog = null;
- self.$dialogTitlebar = null;
- self.$container = null;
- self.$iframe = null;
-
- self.$iframeWindow = null;
- self.$iframeDocument = null;
- self.$iframeBody = null;
+ this.iframeWindow = null;
};
/**
* Redirect the overlay parent window to the given URL.
*
- * @param link
+ * @param url
* Can be an absolute URL or a relative link to the domain root.
*/
-Drupal.overlay.redirect = function (link) {
- if (link.indexOf('http') != 0 && link.indexOf('https') != 0) {
- var absolute = location.href.match(/https?:\/\/[^\/]*/)[0];
- link = absolute + link;
- }
+Drupal.overlay.redirect = function (url) {
+ // Create a native Link object, so we can use its object methods.
+ var link = $(url.link(url)).get(0);
// If the link is already open, force the hashchange event to simulate reload.
- if (location.href == link) {
- $(window).trigger('hashchange.overlay-event');
+ if (window.location.href == link.href) {
+ $(window).triggerHandler('hashchange.drupal-overlay');
}
- location.href = link;
+ window.location.href = link.href;
return true;
};
/**
* Bind the child window.
*
- * Add tabs on the overlay, keyboard actions and display animation.
+ * Note that this function is fired earlier than Drupal.overlay.loadChild.
*/
Drupal.overlay.bindChild = function (iframeWindow, isClosing) {
- var self = this;
- self.$iframeWindow = iframeWindow.jQuery;
- self.$iframeDocument = self.$iframeWindow(iframeWindow.document);
- self.$iframeBody = self.$iframeWindow('body');
+ this.iframeWindow = iframeWindow;
// We are done if the child window is closing.
- if (isClosing || self.isClosing || !self.isOpen) {
+ if (isClosing || this.isClosing || !this.isOpen) {
return;
}
- // Make sure the parent window URL matches the child window URL.
- self.syncChildLocation(iframeWindow.document.location);
-
- // Unbind the mousedown handler installed by ui.dialog because the
- // handler interferes with use of the scroll bar in Chrome & Safari.
- // After unbinding from the document we bind a handler to the dialog overlay
- // which returns false to prevent event bubbling.
- // See http://dev.jqueryui.com/ticket/4671.
- // See https://bugs.webkit.org/show_bug.cgi?id=19033.
- // Do the same for the click handler as prevents default handling of clicks in
- // displaced regions (e.g. opening a link in a new browser tab when CTRL was
- // pressed while clicking).
- $(document).unbind('mousedown.dialog-overlay click.dialog-overlay');
- $('.ui-widget-overlay').bind('mousedown.dialog-overlay click.dialog-overlay', function (){return false;});
-
- // Unbind the keydown and keypress handlers installed by ui.dialog because
- // they interfere with use of browser's keyboard hotkeys like CTRL+w.
- // This may cause problems when using modules that implement keydown or
- // keypress handlers as they aren't blocked when overlay is open.
- $(document).unbind('keydown.dialog-overlay keypress.dialog-overlay');
-
- // Reset the scroll to the top of the window so that the overlay is visible again.
- window.scrollTo(0, 0);
-
- var iframeTitle = self.$iframeDocument.attr('title');
-
- // Update the dialog title with the child window title.
- self.$container.dialog('option', 'title', iframeTitle);
- self.$dialogTitlebar.find('.ui-dialog-title').focus();
- // Add a title attribute to the iframe for accessibility.
- self.$iframe.attr('title', Drupal.t('@title dialog', { '@title': iframeTitle }));
-
- // Remove any existing shortcut button markup in the title section.
- self.$dialogTitlebar.find('.add-or-remove-shortcuts').remove();
- // If the shortcut add/delete button exists, move it to the dialog title.
- var $addToShortcuts = self.$iframeWindow('.add-or-remove-shortcuts');
- if ($addToShortcuts.length) {
- // Move the button markup to the title section. We need to copy markup
- // instead of moving the DOM element, because Webkit and IE browsers will
- // not move DOM elements between two DOM documents.
- $addToShortcuts = $(self.$iframeWindow('<div>').append($addToShortcuts).remove().html());
-
- self.$dialogTitlebar.find('.ui-dialog-title').after($addToShortcuts);
- }
-
- // Remove any existing tabs in the title section.
- self.$dialogTitlebar.find('ul').remove();
- // If there are tabs in the page, move them to the titlebar.
- var $tabs = self.$iframeWindow('ul.primary');
- if ($tabs.length) {
- // Move the tabs markup to the title section. We need to copy markup
- // instead of moving the DOM element, because Webkit and IE browsers will
- // not move DOM elements between two DOM documents.
- $tabs = $(self.$iframeWindow('<div>').append($tabs).remove().html());
-
- self.$dialogTitlebar.append($tabs);
-
- // Remove any classes from the list element to avoid theme styles
- // clashing with our styling.
- $tabs.removeAttr('class');
- }
-
- // Re-attach the behaviors we lost while copying elements from the iframe
- // document to the parent document.
- Drupal.attachBehaviors(self.$dialogTitlebar);
-
- // Try to enhance keyboard based navigation of the overlay.
- // Logic inspired by the open() method in ui.dialog.js, and
- // http://wiki.codetalks.org/wiki/index.php/Docs/Keyboard_navigable_JS_widgets
-
- // Get a reference to the close button.
- var $closeButton = self.$dialogTitlebar.find('.ui-dialog-titlebar-close');
-
- // Search tabbable elements on the iframed document to speed up related
- // keyboard events.
- // @todo: Do we need to provide a method to update these references when
- // AJAX requests update the DOM on the child document?
- var $iframeTabbables = self.$iframeWindow(':tabbable:not(form)');
- var $firstTabbable = $iframeTabbables.filter(':first');
- var $lastTabbable = $iframeTabbables.filter(':last');
-
- // Unbind keyboard event handlers that may have been enabled previously.
- $(document).unbind('keydown.overlay-event');
- $closeButton.unbind('keydown.overlay-event');
-
- // When the focus leaves the close button, then we want to jump to the
- // first/last inner tabbable element of the child window.
- $closeButton.bind('keydown.overlay-event', function (event) {
- if (event.keyCode && event.keyCode == $.ui.keyCode.TAB) {
- var $target = (event.shiftKey ? $lastTabbable : $firstTabbable);
- if (!$target.size()) {
- $target = self.$iframeDocument;
- }
- $target.focus();
- return false;
- }
- });
+ // Allow other scripts to respond to this event.
+ $(document).trigger('drupalOverlayReady');
+};
- // When the focus leaves the child window, then drive the focus to the
- // close button of the dialog.
- self.$iframeDocument.bind('keydown.overlay-event', function (event) {
- if (event.keyCode) {
- if (event.keyCode == $.ui.keyCode.TAB) {
- if (event.shiftKey && event.target == $firstTabbable.get(0)) {
- $closeButton.focus();
- return false;
- }
- else if (!event.shiftKey && event.target == $lastTabbable.get(0)) {
- $closeButton.focus();
- return false;
- }
- }
- else if (event.keyCode == $.ui.keyCode.ESCAPE) {
- self.close();
- return false;
- }
- }
- });
+/**
+ * Event handler: load event handler for the overlay iframe.
+ *
+ * @param event
+ * Event being triggered, with the following restrictions:
+ * - event.type: load
+ * - event.currentTarget: iframe
+ */
+Drupal.overlay.loadChild = function (event) {
+ var iframe = event.data.self;
+ var iframeDocument = iframe.contentDocument || iframe.contentWindow.document;
+ var iframeWindow = iframeDocument.defaultView || iframeDocument.parentWindow;
+ if (iframeWindow.location == 'about:blank') {
+ return;
+ }
- // When the focus is captured by the parent document, then try
- // to drive the focus back to the first tabbable element, or the
- // close button of the dialog (default).
- $(document).bind('keydown.overlay-event', function (event) {
- if (event.keyCode && event.keyCode == $.ui.keyCode.TAB) {
- if (!self.$iframeWindow(':tabbable:not(form):first').focus().size()) {
- $closeButton.focus();
- }
- return false;
+ this.isLoading = false;
+ $(document.documentElement).removeClass('overlay-loading');
+ event.data.sibling.removeClass('overlay-active');
+
+ // Only continue when overlay is still open and not closing.
+ if (this.isOpen && !this.isClosing) {
+ // And child document is an actual overlayChild.
+ if (iframeWindow.Drupal && iframeWindow.Drupal.overlayChild) {
+ this.activeFrame = $(iframe)
+ .addClass('overlay-active')
+ // Add a title attribute to the iframe for accessibility.
+ .attr('title', Drupal.t('@title dialog', { '@title': iframeWindow.document.title }));;
+ this.inactiveFrame = event.data.sibling;
+
+ // Load an empty document into the inactive iframe.
+ (this.inactiveFrame[0].contentDocument || this.inactiveFrame[0].contentWindow.document).location.replace('about:blank');
+
+ // Allow other scripts to respond to this event.
+ $(document).trigger('drupalOverlayLoad');
+ }
+ else {
+ window.location = iframeWindow.location.href.replace(/([?&]?)render=overlay&?/g, '$1').replace(/\?$/, '');
}
- });
-
- // Adjust overlay to fit the iframe content?
- if (self.options.autoFit) {
- self.innerResize();
-
- var delayedResize = function() {
- if (!self.isOpen) {
- clearTimeout(self.resizeTimeoutID);
- return;
- }
-
- self.innerResize();
- iframeWindow.scrollTo(0, 0);
- self.resizeTimeoutID = setTimeout(delayedResize, 150);
- };
-
- clearTimeout(self.resizeTimeoutID);
- self.resizeTimeoutID = setTimeout(delayedResize, 150);
}
-
- // Scroll to anchor in overlay. This needs to be done after delayedResize().
- if (iframeWindow.document.location.hash) {
- window.scrollTo(0, self.$iframeWindow(iframeWindow.document.location.hash).position().top);
+ else {
+ this.destroy();
}
};
@@ -589,132 +298,152 @@ Drupal.overlay.bindChild = function (iframeWindow, isClosing) {
*
* @param url
* The url to be tested.
+ *
* @return boolean
* TRUE if the URL represents an administrative link, FALSE otherwise.
*/
Drupal.overlay.isAdminLink = function (url) {
- var self = this;
- var path = self.getPath(url);
+ var path = this.getPath(url);
// Turn the list of administrative paths into a regular expression.
- if (!self.adminPathRegExp) {
+ if (!this.adminPathRegExp) {
var adminPaths = '^(' + Drupal.settings.overlay.paths.admin.replace(/\s+/g, ')$|^(') + ')$';
var nonAdminPaths = '^(' + Drupal.settings.overlay.paths.non_admin.replace(/\s+/g, ')$|^(') + ')$';
adminPaths = adminPaths.replace(/\*/g, '.*');
nonAdminPaths = nonAdminPaths.replace(/\*/g, '.*');
- self.adminPathRegExp = new RegExp(adminPaths);
- self.nonAdminPathRegExp = new RegExp(nonAdminPaths);
+ this.adminPathRegExp = new RegExp(adminPaths);
+ this.nonAdminPathRegExp = new RegExp(nonAdminPaths);
}
- return self.adminPathRegExp.exec(path) && !self.nonAdminPathRegExp.exec(path);
+ return this.adminPathRegExp.exec(path) && !this.nonAdminPathRegExp.exec(path);
};
/**
- * Resize overlay according to the size of its content.
+ * Event handler: resizes overlay according to the size of the parent window.
*
- * @todo: Watch for experience in the way we compute the size of the iframed
- * document. There are many ways to do it, and none of them seem to be perfect.
- * Note, though, that the size of the iframe itself may affect the size of the
- * child document, especially on fluid layouts.
+ * @param event
+ * Event being triggered, with the following restrictions:
+ * - event.type: any
+ * - event.currentTarget: any
*/
-Drupal.overlay.innerResize = function (height) {
- var self = Drupal.overlay;
- // Proceed only if the dialog still exists.
- if (!self.isOpen || self.isClosing) {
+Drupal.overlay.eventhandlerOuterResize = function (event) {
+ // Proceed only if the overlay still exists.
+ if (!(this.isOpen || this.isOpening) || this.isClosing || !this.iframeWindow) {
return;
}
- // When no height is given try to get height when iframe content is loaded.
- if (!height && self.$iframeBody) {
- height = self.$iframeBody.outerHeight() + 25;
+ // IE6 uses position:absolute instead of position:fixed.
+ if (typeof document.body.style.maxHeight != 'string') {
+ this.activeFrame.height($(window).height());
}
- // Only resize when height actually is changed.
- if (height && height != self.lastHeight) {
- // Resize the container.
- self.$container.height(height);
- // Keep the dim background grow or shrink with the dialog.
- $.ui.dialog.overlay.resize();
-
- self.lastHeight = height;
- }
+ // Allow other scripts to respond to this event.
+ $(document).trigger('drupalOverlayResize');
};
/**
- * Resize overlay according to the size of the parent window.
+ * Event handler: resizes displaced elements so they won't overlap the scrollbar
+ * of overlay's iframe.
+ *
+ * @param event
+ * Event being triggered, with the following restrictions:
+ * - event.type: any
+ * - event.currentTarget: any
*/
-Drupal.overlay.outerResize = function () {
- var self = Drupal.overlay;
- // Proceed only if the dialog still exists.
- if (!(self.isOpen || self.isOpening) || self.isClosing) {
+Drupal.overlay.eventhandlerAlterDisplacedElements = function (event) {
+ // Proceed only if the overlay still exists.
+ if (!(this.isOpen || this.isOpening) || this.isClosing || !this.iframeWindow) {
return;
}
- // Consider any region that should be visible above the overlay (such as
- // an admin toolbar).
- var $displaceTop = $('.overlay-displace-top');
- var displaceTopHeight = 0;
- $displaceTop.each(function () {
- displaceTopHeight += $(this).height();
- });
-
- self.$wrapper.css('top', displaceTopHeight);
-
- // When the overlay has no height yet, make it fit exactly in the window,
- // or the configured height when autoFit is disabled.
- if (!self.lastHeight) {
- var titleBarHeight = self.$dialogTitlebar.outerHeight(true);
+ $(this.iframeWindow.document.body).css({
+ marginTop: Drupal.overlay.getDisplacement('top'),
+ marginBottom: Drupal.overlay.getDisplacement('bottom')
+ })
+ // IE7 isn't reflowing the document immediately.
+ // @todo This might be fixed in a cleaner way.
+ .addClass('overlay-trigger-reflow').removeClass('overlay-trigger-reflow');
+
+ var documentHeight = this.iframeWindow.document.body.clientHeight;
+ var documentWidth = this.iframeWindow.document.body.clientWidth;
+ // IE6 doesn't support maxWidth, use width instead.
+ var maxWidthName = (typeof document.body.style.maxWidth == 'string') ? 'maxWidth' : 'width';
+
+ // Consider any element that should be visible above the overlay (such as
+ // a toolbar).
+ $('.overlay-displace-top, .overlay-displace-bottom').each(function () {
+ var data = $(this).data();
+ var maxWidth = documentWidth;
+ // In IE, Shadow filter makes element to overlap the scrollbar with 1px.
+ if (this.filters && this.filters.length && this.filters.item('DXImageTransform.Microsoft.Shadow')) {
+ maxWidth -= 1;
+ }
- if (self.options.autoFit || self.options.height == undefined ||!isNan(self.options.height)) {
- self.lastHeight = parseInt($(window).height() - displaceTopHeight - titleBarHeight - 45);
+ // Prevent displaced elements overlapping window's scrollbar.
+ var currentMaxWidth = parseInt($(this).css(maxWidthName));
+ if ((data.drupalOverlay && data.drupalOverlay.maxWidth) || isNaN(currentMaxWidth) || currentMaxWidth > maxWidth || currentMaxWidth <= 0) {
+ $(this).css(maxWidthName, maxWidth);
+ (data.drupalOverlay = data.drupalOverlay || {}).maxWidth = true;
}
- else {
- self.lastHeight = self.options.height;
+
+ // Use a more rigerous approach if the displaced element still overlaps
+ // window's scrollbar; clip the element on the right.
+ var offset = $(this).offset();
+ var offsetRight = offset.left + $(this).outerWidth();
+ if ((data.drupalOverlay && data.drupalOverlay.clip) || offsetRight > maxWidth) {
+ $(this).css('clip', 'rect(auto, ' + (maxWidth - offset.left) + 'px, ' + (documentHeight - offset.top) + 'px, auto)');
+ (data.drupalOverlay = data.drupalOverlay || {}).clip = true;
}
+ });
+};
- self.$container.height(self.lastHeight);
+/**
+ * Event handler: restores size of displaced elements as they where before
+ * overlay was opened.
+ *
+ * @param event
+ * Event being triggered, with the following restrictions:
+ * - event.type: any
+ * - event.currentTarget: any
+ */
+Drupal.overlay.eventhandlerRestoreDisplacedElements = function (event) {
+ var $displacedElements = $('.overlay-displace-top, .overlay-displace-bottom');
+ try {
+ $displacedElements.css({ maxWidth: null, clip: null });
}
-
- if (self.options.autoFit) {
- self.innerResize();
+ // IE bug that doesn't allow unsetting style.clip (http://dev.jquery.com/ticket/6512).
+ catch (err) {
+ $displacedElements.attr('style', function (index, attr) {
+ return attr.replace(/clip\s*:\s*rect\([^)]+\);?/i, '');
+ });
}
-
- // Make the dim background grow or shrink with the dialog.
- $.ui.dialog.overlay.resize();
};
+Drupal.overlay.linksToRestore = [];
+
/**
- * Click event handler.
- *
- * Instead of binding a click event handler to every link we bind one to the
- * document and handle events that bubble up. This allows other scripts to bind
- * their own handlers to links and also to prevent overlay's handling.
+ * Event handler: overrides href of administrative links to be opened in
+ * the overlay.
*
- * This handler makes links in displaced regions work correctly, even when the
- * overlay is open.
- *
- * This click event handler should be bound any document (for example the
+ * This click event handler should be bound to any document (for example the
* overlay iframe) of which you want links to open in the overlay.
*
+ * @param event
+ * Event being triggered, with the following restrictions:
+ * - event.type: click, mouseup
+ * - event.currentTarget: document
+ *
* @see Drupal.overlayChild.behaviors.addClickHandler
*/
-Drupal.overlay.clickHandler = function (event) {
- var self = Drupal.overlay;
-
- var $target = $(event.target);
-
- if (self.isOpen && $target.closest('.overlay-displace-top, .overlay-displace-bottom').length) {
- // Click events in displaced regions could potentionally change the size of
- // that region (e.g. the toggle button of the toolbar module). Trigger the
- // resize event to force a recalculation of overlay's size/position.
- $(window).triggerHandler('resize.overlay-event');
- }
-
- // Only continue by left-click or right-click.
- if (!(event.button == 0 || event.button == 2)) {
+Drupal.overlay.eventhandlerOverrideLink = function (event) {
+ // In some browsers the click event isn't fired for right-clicks. Use the
+ // mouseup event for right-clicks and the click event for everything else.
+ if ((event.type == 'click' && event.button == 2) || (event.type == 'mouseup' && event.button != 2)) {
return;
}
+ var $target = $(event.target);
+
// Only continue if clicked target (or one of its parents) is a link.
if (!$target.is('a')) {
$target = $target.closest('a');
@@ -728,30 +457,45 @@ Drupal.overlay.clickHandler = function (event) {
return;
}
- var href = $target.attr('href');
- // Only continue if link has an href attribute and is not just linking to
- // an anchor.
- if (href != undefined && href != '' && href.charAt(0) != '#') {
+ // Close the overlay when the link contains the overlay-close class.
+ if ($target.hasClass('overlay-close')) {
+ // Clearing the overlay URL fragment will close the overlay.
+ $.bbq.pushState();
+ return;
+ }
+
+ var target = $target[0];
+ var href = target.href;
+ // Only handle links that have an href attribute and use the http(s) protocol.
+ if (href != undefined && href != '' && target.protocol.match(/^https?\:/)) {
+ var anchor = href.replace(target.ownerDocument.location.href, '');
+ // Skip anchor links.
+ if (anchor.length == 0 || anchor.charAt(0) == '#') {
+ return;
+ }
// Open admin links in the overlay.
- if (self.isAdminLink(href)) {
- href = self.fragmentizeLink($target.get(0));
+ else if (this.isAdminLink(href)) {
+ href = this.fragmentizeLink($target.get(0));
// Only override default behavior when left-clicking and user is not
// pressing the ALT, CTRL, META (Command key on the Macintosh keyboard)
// or SHIFT key.
if (event.button == 0 && !event.altKey && !event.ctrlKey && !event.metaKey && !event.shiftKey) {
// Redirect to a fragmentized href. This will trigger a hashchange event.
- self.redirect(href);
+ this.redirect(href);
// Prevent default action and further propagation of the event.
return false;
}
- // Otherwise only alter clicked link's href. This is being picked up by
+ // Otherwise alter clicked link's href. This is being picked up by
// the default action handler.
else {
- $target.attr('href', href);
+ $target
+ // Restore link's href attribute on blur or next click.
+ .one('blur mousedown', { target: target, href: target.href }, function (event) { $(event.data.target).attr('href', event.data.href); })
+ .attr('href', href);
}
}
// Open external links in a new window.
- else if ($target.get(0).hostname != window.location.hostname) {
+ else if (target.hostname != window.location.hostname) {
// Add a target attribute to the clicked link. This is being picked up by
// the default action handler.
if (!$target.attr('target')) {
@@ -761,43 +505,31 @@ Drupal.overlay.clickHandler = function (event) {
// Non-admin links should close the overlay and open in the main window.
// Only handle them if the overlay is open and the clicked link is inside
// the overlay iframe, else default action will do fine.
- else if (self.isOpen) {
- var inFrame = false;
- // W3C: http://www.w3.org/TR/DOM-Level-2-Events/events.html#Events-UIEvent-view
- if (event.view && event.view.frameElement != null) {
- inFrame = true;
- }
- // IE: http://msdn.microsoft.com/en-us/library/ms534331%28VS.85%29.aspx
- else if (event.target.ownerDocument.parentWindow && event.target.ownerDocument.parentWindow.frameElement != null) {
- inFrame = true;
+ else if (this.isOpen && target.ownerDocument === this.iframeWindow.document) {
+ // When the link has a destination query parameter and that destination
+ // is an admin link we need to fragmentize it. This will make it reopen
+ // in the overlay.
+ var params = $.deparam.querystring(href);
+ if (params.destination && this.isAdminLink(params.destination)) {
+ var fragmentizedDestination = $.param.fragment(this.getPath(window.location), { overlay: params.destination });
+ $target.attr('href', $.param.querystring(href, { destination: fragmentizedDestination }));
}
- // Add a target attribute to the clicked link. This is being picked up by
- // the default action handler.
- if (inFrame) {
- // When the link has a destination query parameter and that destination
- // is an admin link we need to fragmentize it. This will make it reopen
- // in the overlay.
- var params = $.deparam.querystring(href);
- if (params.destination && self.isAdminLink(params.destination)) {
- var fragmentizedDestination = $.param.fragment(self.getPath(window.location), { overlay: params.destination });
- href = $.param.querystring(href, { destination: fragmentizedDestination });
- $target.attr('href', href);
- }
-
- // Make the link to be opening in the immediate parent of the frame.
- $target.attr('target', '_parent');
- }
+ // Make the link to be opening in the immediate parent of the frame.
+ $target.attr('target', '_parent');
}
}
};
/**
- * Open, reload, or close the overlay, based on the current URL fragment.
+ * Event handler: opens or closes the overlay based on the current URL fragment.
+ *
+ * @param event
+ * Event being triggered, with the following restrictions:
+ * - event.type: hashchange
+ * - event.currentTarget: document
*/
-Drupal.overlay.hashchangeHandler = function (event) {
- var self = Drupal.overlay;
-
+Drupal.overlay.eventhandlerOperateByURLFragment = function (event) {
// If we changed the hash to reflect an internal redirect in the overlay,
// its location has already been changed, so don't do anything.
if ($.data(window.location, window.location.href) === 'redirect') {
@@ -809,49 +541,114 @@ Drupal.overlay.hashchangeHandler = function (event) {
var state = $.bbq.getState('overlay');
if (state) {
// Append render variable, so the server side can choose the right
- // rendering and add child modal frame code to the page if needed.
- var linkURL = Drupal.settings.basePath + state;
- linkURL = $.param.querystring(linkURL, {'render': 'overlay'});
+ // rendering and add child frame code to the page if needed.
+ var url = $.param.querystring(Drupal.settings.basePath + state, { render: 'overlay' });
- var path = self.getPath(state);
- self.resetActiveClass(path);
+ this.open(url);
+ this.resetActiveClass(this.getPath(url));
+ }
+ // If there is no overlay URL in the fragment and the overlay is (still)
+ // open, close the overlay.
+ else if (this.isOpen && !this.isClosing) {
+ this.close();
+ this.resetActiveClass(this.getPath(window.location));
+ }
+};
- // If the modal frame is already open, replace the loaded document with
- // this new one.
- if (self.isOpen) {
- self.load(linkURL);
+/**
+ * Event handler: makes sure the internal overlay URL is reflected in the parent
+ * URL fragment.
+ *
+ * Normally the parent URL fragment determines the overlay location. However, if
+ * the overlay redirects internally, the parent doesn't get informed, and the
+ * parent URL fragment will be out of date. This is a sanity check to make
+ * sure we're in the right place.
+ *
+ * The parent URL fragment is also not updated automatically when overlay's
+ * open, close or load functions are used directly (instead of through
+ * eventhandlerOperateByURLFragment).
+ *
+ * @param event
+ * Event being triggered, with the following restrictions:
+ * - event.type: drupalOverlayReady, drupalOverlayClose
+ * - event.currentTarget: document
+ */
+Drupal.overlay.eventhandlerSyncURLFragment = function (event) {
+ if (this.isOpen) {
+ var expected = $.bbq.getState('overlay');
+ // This is just a sanity check, so we're comparing paths, not query strings.
+ if (this.getPath(Drupal.settings.basePath + expected) != this.getPath(this.iframeWindow.document.location)) {
+ // There may have been a redirect inside the child overlay window that the
+ // parent wasn't aware of. Update the parent URL fragment appropriately.
+ var newLocation = Drupal.overlay.fragmentizeLink(this.iframeWindow.document.location);
+ // Set a 'redirect' flag on the new location so the hashchange event handler
+ // knows not to change the overlay's content.
+ $.data(window.location, newLocation, 'redirect');
+ // Use location.replace() so we don't create an extra history entry.
+ window.location.replace(newLocation);
}
- else {
- // There is not an overlay opened yet; we should open a new one.
- var overlayOptions = {
- url: linkURL
- };
- $(document).one('drupalOverlayClose', function () {
- // Clear the overlay URL fragment.
- $.bbq.pushState();
- self.resetActiveClass(self.getPath(window.location));
- });
- self.open(overlayOptions);
+ }
+ else {
+ $.bbq.pushState();
+ }
+};
+
+/**
+ * Event handler: makes sure that when the overlay is open no elements (except
+ * for elements inside any displaced elements) of the parent document are
+ * reachable through keyboard (TAB) navigation.
+ *
+ * @param event
+ * Event being triggered, with the following restrictions:
+ * - event.type: keydown
+ * - event.currentTarget: document
+ */
+Drupal.overlay.eventhandlerRestrictKeyboardNavigation = function (event) {
+ if (!this.$tabbables) {
+ this.$tabbables = $(':tabbable');
+ }
+
+ if (event.keyCode && event.keyCode == $.ui.keyCode.TAB) {
+ // Whenever the focus is not inside the overlay (or an displaced element)
+ // move the focus along until it is.
+ var direction = event.shiftKey ? -1 : 1;
+ var current = this.$tabbables.index(event.target);
+ var $allowedParent = $('#overlay-container, .overlay-displace-top, .overlay-displace-bottom');
+ if (current != -1 && this.$tabbables[current + direction] && !this.$tabbables.eq(current + direction).closest($allowedParent).length) {
+ while (this.$tabbables[current + direction] && !this.$tabbables.eq(current + direction).closest($allowedParent).length) {
+ current = current + direction;
+ }
+ // Move focus.
+ this.$tabbables.eq(current).focus();
}
}
- // If there is no overlay URL in the fragment and the overlay is (still)
- // open, close the overlay.
- else if (self.isOpen && !self.isClosing) {
- self.close();
+};
+
+/**
+ * Event handler: dispatches events to the overlay document.
+ *
+ * @param event
+ * Event being triggered, with the following restrictions:
+ * - event.type: any
+ * - event.currentTarget: any
+ */
+Drupal.overlay.eventhandlerDispatchEvent = function (event) {
+ if (this.iframeWindow && this.iframeWindow.document) {
+ this.iframeWindow.jQuery(this.iframeWindow.document).trigger(event);
}
};
/**
- * Make a regular admin link into a URL that will trigger the overlay to open.
+ * Make a regular admin link into an URL that will trigger the overlay to open.
*
* @param link
* A Javascript Link object (i.e. an <a> element).
+ *
* @return
- * A URL that will trigger the overlay (in the form
+ * An URL that will trigger the overlay (in the form
* /node/1#overlay=admin/config).
*/
Drupal.overlay.fragmentizeLink = function (link) {
- var self = this;
// Don't operate on links that are already overlay-ready.
var params = $.deparam.fragment(link.href);
if (params.overlay) {
@@ -861,9 +658,9 @@ Drupal.overlay.fragmentizeLink = function (link) {
// Determine the link's original destination. Set ignorePathFromQueryString to
// true to prevent transforming this link into a clean URL while clean URLs
// may be disabled.
- var path = self.getPath(link, true);
+ var path = this.getPath(link, true);
// Preserve existing query and fragment parameters in the URL, except for
- // "render=overlay" which is re-added in Drupal.overlay.hashchangeHandler.
+ // "render=overlay" which is re-added in Drupal.overlay.eventhandlerOperateByURLFragment.
var destination = path + link.search.replace(/&?render=overlay/, '').replace(/\?$/, '') + link.hash;
// Assemble and return the overlay-ready link.
@@ -871,34 +668,6 @@ Drupal.overlay.fragmentizeLink = function (link) {
};
/**
- * Make sure the internal overlay URL is reflected in the parent URL fragment.
- *
- * Normally the parent URL fragment determines the overlay location. However, if
- * the overlay redirects internally, the parent doesn't get informed, and the
- * parent URL fragment will be out of date. This is a sanity check to make
- * sure we're in the right place.
- *
- * @param childLocation
- * The child window's location object.
- */
-Drupal.overlay.syncChildLocation = function (childLocation) {
- var expected = $.bbq.getState('overlay');
- // This is just a sanity check, so we're comparing paths, not query strings.
- expected = Drupal.settings.basePath + expected.replace(/\?.+/, '');
- var actual = childLocation.pathname;
- if (expected !== actual) {
- // There may have been a redirect inside the child overlay window that the
- // parent wasn't aware of. Update the parent URL fragment appropriately.
- var newLocation = Drupal.overlay.fragmentizeLink(childLocation);
- // Set a 'redirect' flag on the new location so the hashchange event handler
- // knows not to change the overlay's content.
- $.data(window.location, newLocation, 'redirect');
- // Using location.replace so we don't create an extra history entry.
- window.location.replace(newLocation);
- }
-};
-
-/**
* Refresh any regions of the page that are displayed outside the overlay.
*
* @param data
@@ -913,6 +682,8 @@ Drupal.overlay.refreshRegions = function (data) {
$.each(region_info, function (regionClass) {
var regionName = region_info[regionClass];
var regionSelector = '.' + regionClass;
+ // Allow special behaviors to detach.
+ Drupal.detachBehaviors($(regionSelector));
$.get(Drupal.settings.basePath + Drupal.settings.overlay.ajaxCallback + '/' + regionName, function (newElement) {
$(regionSelector).replaceWith($(newElement));
Drupal.attachBehaviors($(regionSelector), Drupal.settings);
@@ -922,7 +693,8 @@ Drupal.overlay.refreshRegions = function (data) {
};
/**
- * Reset the active class on links in displaced regions according to given path.
+ * Reset the active class on links in displaced elements according to
+ * given path.
*
* @param activePath
* Path to match links against.
@@ -933,7 +705,7 @@ Drupal.overlay.resetActiveClass = function(activePath) {
$('.overlay-displace-top, .overlay-displace-bottom')
.find('a[href]')
- // Remove active class from all links in displaced regions.
+ // Remove active class from all links in displaced elements.
.removeClass('active')
// Add active class to links that match activePath.
.each(function () {
@@ -953,8 +725,9 @@ Drupal.overlay.resetActiveClass = function(activePath) {
* Link object or string to get the Drupal path from.
* @param ignorePathFromQueryString
* Boolean whether to ignore path from query string if path appears empty.
+ *
* @return
- * The drupal path.
+ * The Drupal path.
*/
Drupal.overlay.getPath = function (link, ignorePathFromQueryString) {
if (typeof link == 'string') {
@@ -967,11 +740,11 @@ Drupal.overlay.getPath = function (link, ignorePathFromQueryString) {
if (path.charAt(0) != '/') {
path = '/' + path;
}
- path = path.replace(new RegExp(Drupal.settings.basePath + "(?:index.php)?"), '');
+ path = path.replace(new RegExp(Drupal.settings.basePath + '(?:index.php)?'), '');
if (path == '' && !ignorePathFromQueryString) {
// If the path appears empty, it might mean the path is represented in the
// query string (clean URLs are not used).
- var match = new RegExp("([?&])q=(.+)([&#]|$)").exec(link.search);
+ var match = new RegExp('([?&])q=(.+)([&#]|$)').exec(link.search);
if (match && match.length == 4) {
path = match[2];
}
@@ -981,31 +754,41 @@ Drupal.overlay.getPath = function (link, ignorePathFromQueryString) {
};
/**
- * Theme function to create the overlay iframe element.
+ * Get the total displacement of given region.
+ *
+ * @param region
+ * Region name. Either "top" or "bottom".
+ *
+ * @return
+ * The total displacement of given region in pixels.
*/
-Drupal.theme.prototype.overlayElement = function () {
- return '<iframe id="overlay-element" frameborder="0" name="overlay-element" scrolling="no" allowtransparency="true"/>';
+Drupal.overlay.getDisplacement = function (region) {
+ var displacement = 0;
+ var lastDisplaced = $('.overlay-displace-' + region + ':last');
+ if (lastDisplaced.length) {
+ displacement = lastDisplaced.offset().top + lastDisplaced.outerHeight();
+
+ // Remove height added by IE Shadow filter.
+ if (lastDisplaced[0].filters && lastDisplaced[0].filters.length && lastDisplaced[0].filters.item('DXImageTransform.Microsoft.Shadow')) {
+ displacement -= lastDisplaced[0].filters.item('DXImageTransform.Microsoft.Shadow').strength;
+ displacement = Math.max(0, displacement);
+ }
+ }
+ return displacement;
};
/**
- * Theme function to create a container for the overlay iframe element.
+ * Theme function to create the overlay iframe element.
*/
Drupal.theme.prototype.overlayContainer = function () {
- return '<div id="overlay-container"/>';
-};
-
-/**
- * Theme function for the overlay title markup.
- */
-Drupal.theme.prototype.overlayTitleHeader = function (text) {
- return '<h1 id="ui-dialog-title-overlay-container" class="ui-dialog-title" tabindex="-1" unselectable="on">' + text + '</h1>';
+ return '<div id="overlay-container" role="dialog"><div class="overlay-modal-background"/></div>';
};
/**
- * Theme function to create a wrapper for the jquery UI dialog.
+ * Theme function to create an overlay iframe element.
*/
-Drupal.theme.prototype.overlayWrapper = function () {
- return '<div id="overlay-wrapper"/>';
+Drupal.theme.prototype.overlayElement = function (url) {
+ return '<iframe class="overlay-element" frameborder="0" scrolling="auto" allowtransparency="true" role="document"/>';
};
})(jQuery);
diff --git a/modules/overlay/overlay.module b/modules/overlay/overlay.module
index c5b123b7b..541d7641e 100644
--- a/modules/overlay/overlay.module
+++ b/modules/overlay/overlay.module
@@ -46,6 +46,18 @@ function overlay_permission() {
}
/**
+ * Implements hook_theme().
+ */
+function overlay_theme() {
+ return array(
+ 'overlay' => array(
+ 'render element' => 'page',
+ 'template' => 'overlay',
+ ),
+ );
+}
+
+/**
* Implements hook_init().
*
* Determine whether the current page request is destined to appear in the
@@ -150,8 +162,7 @@ function overlay_library() {
$module_path . '/overlay-parent.css' => array(),
),
'dependencies' => array(
- array('system', 'ui.dialog'),
- array('system', 'ui.position'),
+ array('system', 'ui'),
array('system', 'jquery-bbq'),
),
);
@@ -163,8 +174,8 @@ function overlay_library() {
'js' => array(
$module_path . '/overlay-child.js' => array(),
),
- 'dependencies' => array(
- array('system', 'ui'),
+ 'css' => array(
+ $module_path . '/overlay-child.css' => array(),
),
);
@@ -221,6 +232,11 @@ function overlay_page_alter(&$page) {
$page[$skipped_region]['#access'] = FALSE;
}
}
+
+ if (overlay_get_mode() == 'child') {
+ // Add the overlay wrapper before the html wrapper.
+ array_unshift($page['#theme_wrappers'], 'overlay');
+ }
}
/**
@@ -255,7 +271,7 @@ function overlay_system_info_alter(&$info, $file, $type) {
}
/**
- * Preprocess template variables for html.tpl.php.
+ * Implements hook_preprocess_html().
*
* If the current page request is inside the overlay, add appropriate classes
* to the <body> element, and simplify the page title.
@@ -272,7 +288,7 @@ function overlay_preprocess_html(&$variables) {
}
/**
- * Preprocess template variables for maintenance-page.tpl.php.
+ * Implements hook_preprocess_maintenance_page().
*
* If the current page request is inside the overlay, add appropriate classes
* to the <body> element, and simplify the page title.
@@ -284,7 +300,30 @@ function overlay_preprocess_maintenance_page(&$variables) {
}
/**
- * Preprocess template variables for page.tpl.php.
+ * Preprocesses template variables for overlay.tpl.php
+ *
+ * @see overlay.tpl.php
+ */
+function template_preprocess_overlay(&$variables) {
+ $variables['tabs'] = menu_primary_local_tasks();
+ $variables['title'] = drupal_get_title();
+
+ $variables['content_attributes_array']['class'][] = 'clearfix';
+}
+
+/**
+ * Processes variables for overlay.tpl.php
+ *
+ * @see template_preprocess_overlay()
+ * @see overlay.tpl.php
+ */
+function template_process_overlay(&$variables) {
+ // Place the rendered HTML for the page body into a top level variable.
+ $variables['page'] = $variables['page']['#children'];
+}
+
+/**
+ * Implements hook_preprocess_page().
*
* Display breadcrumbs correctly inside the overlay.
*
@@ -296,17 +335,10 @@ function overlay_preprocess_page(&$variables) {
$overlay_breadcrumb = drupal_get_breadcrumb();
array_shift($overlay_breadcrumb);
$variables['breadcrumb'] = theme('breadcrumb', array('breadcrumb' => $overlay_breadcrumb));
- }
-}
-/**
- * Preprocess template variables for toolbar.tpl.php.
- *
- * Adding the 'overlay-displace-top' class to the toolbar pushes the overlay
- * down, so it appears below the toolbar.
- */
-function overlay_preprocess_toolbar(&$variables) {
- $variables['classes_array'][] = "overlay-displace-top";
+ $variables['tabs'] = '';
+ $variables['primary_local_tasks'] = '';
+ }
}
/**
@@ -477,9 +509,6 @@ function overlay_set_mode($mode = NULL) {
case 'child':
drupal_add_library('overlay', 'child');
- // Pass child's document height on to parent document as quickly as
- // possible so it can be updated accordingly.
- drupal_add_js('if (parent.Drupal && parent.Drupal.overlay) { parent.Drupal.overlay.innerResize(jQuery(document.body).outerHeight()); }', array('type' => 'inline', 'scope' => 'footer'));
// Allow modules to act upon overlay events.
module_invoke_all('overlay_child_initialize');
diff --git a/modules/overlay/overlay.tpl.php b/modules/overlay/overlay.tpl.php
new file mode 100644
index 000000000..0c25b0eb8
--- /dev/null
+++ b/modules/overlay/overlay.tpl.php
@@ -0,0 +1,37 @@
+<?php
+// $Id$
+
+/**
+ * @file
+ * Default theme implementation to display a page in the overlay.
+ *
+ * Available variables:
+ * - $title: the (sanitized) title of the node.
+ * - $page: The rendered page content.
+ * - $tabs (array): Tabs linking to any sub-pages beneath the current page
+ * (e.g., the view and edit tabs when displaying a node).
+ *
+ * Helper variables:
+ * - $classes_array: Array of html class attribute values. It is flattened
+ * into a string within the variable $classes.
+ *
+ * @see template_preprocess()
+ * @see template_preprocess_overlay()
+ * @see template_process()
+ */
+?>
+
+<div id="overlay" <?php print $attributes; ?>>
+ <div id="overlay-titlebar" class="clearfix">
+ <div id="overlay-title-wrapper" class="clearfix">
+ <h1 id="overlay-title"<?php print $title_attributes; ?>><?php print $title; ?></h1>
+ </div>
+ <div id="overlay-close-wrapper">
+ <a id="overlay-close" href="#" class="overlay-close"><span><?php t('Close overlay'); ?></span></a>
+ </div>
+ <?php if ($tabs): ?><ul id="overlay-tabs"><?php print render($tabs); ?></ul><?php endif; ?>
+ </div>
+ <div id="overlay-content"<?php print $content_attributes; ?>>
+ <?php print $page; ?>
+ </div>
+</div>
diff --git a/modules/toolbar/toolbar.js b/modules/toolbar/toolbar.js
index 85129f824..4336218b6 100644
--- a/modules/toolbar/toolbar.js
+++ b/modules/toolbar/toolbar.js
@@ -15,9 +15,8 @@ Drupal.behaviors.toolbar = {
// Toggling toolbar drawer.
$('#toolbar a.toggle', context).once('toolbar-toggle').click(function(e) {
Drupal.toolbar.toggle();
- // As the toolbar is an overlay displaced region, overlay should be
- // notified of it's height change to adapt its position.
- $(window).triggerHandler('resize.overlay-event');
+ // Allow resize event handlers to recalculate sizes/positions.
+ $(window).triggerHandler('resize');
return false;
});
}
diff --git a/modules/toolbar/toolbar.module b/modules/toolbar/toolbar.module
index 396c50f93..fa0782a7e 100644
--- a/modules/toolbar/toolbar.module
+++ b/modules/toolbar/toolbar.module
@@ -151,6 +151,16 @@ function toolbar_preprocess_html(&$vars) {
}
/**
+ * Implements hook_preprocess_toolbar().
+ *
+ * Adding the 'overlay-displace-top' class to the toolbar pushes the overlay
+ * down, so it appears below the toolbar.
+ */
+function toolbar_preprocess_toolbar(&$variables) {
+ $variables['classes_array'][] = "overlay-displace-top";
+}
+
+/**
* Implements hook_system_info_alter().
*
* Indicate that the 'page_top' region (in which the toolbar will be displayed)
diff --git a/themes/garland/style.css b/themes/garland/style.css
index c6564d734..96e4875b3 100644
--- a/themes/garland/style.css
+++ b/themes/garland/style.css
@@ -629,16 +629,32 @@ div#branding strong {
margin-bottom: 2em;
}
-/* Don't display any header elements when within the overlay, and adjust the
- page height accordingly. */
-body.overlay #header * {
+/**
+ * Overlay
+ */
+#overlay #overlay-tabs li a {
+ background: #d9eaf5;
+ color: #000;
+}
+#overlay #overlay-tabs li a:hover,
+#overlay #overlay-tabs li a:focus {
+ background: #fff;
+}
+#overlay #overlay-tabs li.active a {
+ background: url("images/body.png") repeat-x scroll 50% -58px #edf5fa;
+ color: #fff;
+}
+#overlay-content {
+ padding: 1px;
+}
+#overlay-content #header {
display: none;
}
-
-body.overlay {
- margin-top: -80px;
+#overlay-content #wrapper {
+ background-position: 50% -80px;
}
+
/**
* Primary navigation
*/