diff options
author | Dries Buytaert <dries@buytaert.net> | 2003-12-15 19:41:24 +0000 |
---|---|---|
committer | Dries Buytaert <dries@buytaert.net> | 2003-12-15 19:41:24 +0000 |
commit | cc80cdf21539d401a8cd0474aef94684ae76a92e (patch) | |
tree | 7c3b441eeff6b02cea865ce599e71624f2056c03 | |
parent | 451bc9482fbd81b920e521312c675cef48fadea6 (diff) | |
download | brdo-cc80cdf21539d401a8cd0474aef94684ae76a92e.tar.gz brdo-cc80cdf21539d401a8cd0474aef94684ae76a92e.tar.bz2 |
- Replaced the tables used to structure the threaded comment view by div's.
Patch by Goba.
-rw-r--r-- | modules/comment.module | 16 | ||||
-rw-r--r-- | modules/comment/comment.module | 16 |
2 files changed, 8 insertions, 24 deletions
diff --git a/modules/comment.module b/modules/comment.module index b11ae3a86..de4073b88 100644 --- a/modules/comment.module +++ b/modules/comment.module @@ -1397,31 +1397,23 @@ function theme_comment_flat_expanded($comment, $threshold) { function theme_comment_thread_min($comment, $threshold, $pid = 0) { if (comment_visible($comment, $threshold)) { - $output = "<table border=\"0\" cellpadding=\"0\" cellspacing=\"0\" width=\"100%\"><tr><td width=\"". ($comment->depth * 25) ."\"><br /></td><td>\n"; + $output = "<div style=\"margin-left:". ($comment->depth * 25) ."px;\">\n"; $output .= theme("comment_view", $comment, "", 0); - $output .= "</td></tr></table>\n"; + $output .= "</div>\n"; } return $output; } function theme_comment_thread_max($comment, $threshold, $level = 0) { - /* - ** We had quite a few browser specific issues: expanded comments below - ** the top level got truncated on the right hand side. A range of - ** solutions have been proposed and tried but either the right margins of - ** the comments didn't line up well, or the heavily nested tables made - ** for slow rendering and cluttered HTML. This is the best work-around - ** in terms of speed and size. - */ $output = ""; if ($comment->depth) { - $output .= "<table border=\"0\" cellpadding=\"0\" cellspacing=\"0\" width=\"100%\"><tr><td width=\"". ($comment->depth * 25) ."\"> </td><td>\n"; + $output .= "<div style=\"margin-left:". ($comment->depth * 25) ."px;\">\n"; } $output .= theme("comment_view", $comment, comment_links($comment, 0), comment_visible($comment, $threshold)); if ($comment->depth) { - $output .= "</td></tr></table>\n"; + $output .= "</div>\n"; } return $output; } diff --git a/modules/comment/comment.module b/modules/comment/comment.module index b11ae3a86..de4073b88 100644 --- a/modules/comment/comment.module +++ b/modules/comment/comment.module @@ -1397,31 +1397,23 @@ function theme_comment_flat_expanded($comment, $threshold) { function theme_comment_thread_min($comment, $threshold, $pid = 0) { if (comment_visible($comment, $threshold)) { - $output = "<table border=\"0\" cellpadding=\"0\" cellspacing=\"0\" width=\"100%\"><tr><td width=\"". ($comment->depth * 25) ."\"><br /></td><td>\n"; + $output = "<div style=\"margin-left:". ($comment->depth * 25) ."px;\">\n"; $output .= theme("comment_view", $comment, "", 0); - $output .= "</td></tr></table>\n"; + $output .= "</div>\n"; } return $output; } function theme_comment_thread_max($comment, $threshold, $level = 0) { - /* - ** We had quite a few browser specific issues: expanded comments below - ** the top level got truncated on the right hand side. A range of - ** solutions have been proposed and tried but either the right margins of - ** the comments didn't line up well, or the heavily nested tables made - ** for slow rendering and cluttered HTML. This is the best work-around - ** in terms of speed and size. - */ $output = ""; if ($comment->depth) { - $output .= "<table border=\"0\" cellpadding=\"0\" cellspacing=\"0\" width=\"100%\"><tr><td width=\"". ($comment->depth * 25) ."\"> </td><td>\n"; + $output .= "<div style=\"margin-left:". ($comment->depth * 25) ."px;\">\n"; } $output .= theme("comment_view", $comment, comment_links($comment, 0), comment_visible($comment, $threshold)); if ($comment->depth) { - $output .= "</td></tr></table>\n"; + $output .= "</div>\n"; } return $output; } |