diff options
author | Jeroen Bensch <jeroen@44.no-reply.drupal.org> | 2001-03-05 20:46:29 +0000 |
---|---|---|
committer | Jeroen Bensch <jeroen@44.no-reply.drupal.org> | 2001-03-05 20:46:29 +0000 |
commit | d9289f51af1be173ae4c3716dba75ece2d266642 (patch) | |
tree | c685d3ddfc458e93f6f9d1a9329498bccc4800be | |
parent | 830e9b3f4f011640047e6607af79347668ea3040 (diff) | |
download | brdo-d9289f51af1be173ae4c3716dba75ece2d266642.tar.gz brdo-d9289f51af1be173ae4c3716dba75ece2d266642.tar.bz2 |
Hey,
I updated some things, remove some PHP lines in the comment function, that I think weren't necessary (did that in the previous commit but forgot to mention it) also I renamed all the PHP?> tags to ?>. I read in the docs at http://php.net that this is the way to go. Also I renamed all <? to <?PHP. I added a BCGOLOR again, so my theme's build up is a little nicer again. Spotted four (yes 4) bugs. I now use regular HTML to assign colors but in abstract and article, the sections were still done the old way. Fixed that now, but left them black. Oh yeah, I fixed that weird rendering of my theme I think Dries was talking about. He didn't exactly mention what was wrong but I assume that it were the links in abstract and article that didn't display at the right of the story. Because I deleted some tables I had to add COLSPAN="2". However, when I loaded my page locally on eden it displayed correct. But when I browsed to drop it didn't (in the same browser) Do you get it? I sure don't. It was the same HTML code, but seems differently parsed when coming from an outside server. Allthough I don't see why Netscape would see apache locally as something different than another one. Nevertheless, I think it's fixed.
Jeroen.
-rw-r--r-- | themes/jeroen/jeroen.theme | 104 |
1 files changed, 53 insertions, 51 deletions
diff --git a/themes/jeroen/jeroen.theme b/themes/jeroen/jeroen.theme index 39d19a8d0..c4d268672 100644 --- a/themes/jeroen/jeroen.theme +++ b/themes/jeroen/jeroen.theme @@ -15,13 +15,13 @@ function header() { global $site_name; -PHP?> +?> <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN" "http://www.w3.org/TR/html4/loose.dtd"> <HTML> <HEAD> - <TITLE><? echo $site_name; ?> - Tears of technology</TITLE> + <TITLE><?PHP echo $site_name; ?> - Tears of technology</TITLE> <META NAME="description" CONTENT="drop.org"> <META NAME="keywords" CONTENT="drop, weblog, portal, community, news, article, announcements, stories, story, computer, science, space, hype, cult, geek, nerd, foo, bar"> <STYLE type="text/css"> @@ -37,27 +37,27 @@ PHP?> <TABLE WIDTH="100%" ALIGN="left" CELLPADDING="0" CELLSPACING="6" BORDER="0"> <TR> <TD COLSPAN="2" WIDTH="80%"> - <?PHP $img = (rand(0,150) == 75) ? "logo2.gif" : "logo.gif";PHP ?> - <IMG SRC="themes/jeroen/images/<? echo $img; ?>" ALT="drop.org logo"><BR><BR> + <?PHP $img = (rand(0,150) == 75) ? "logo2.gif" : "logo.gif"; ?> + <IMG SRC="themes/jeroen/images/<?PHP echo $img; ?>" ALT="drop.org logo"><BR><BR> </TD> <TD WIDTH="20%"> <?PHP - $this->box("Drop where?", "<TR> - <TD ALIGN=\"left\" VALIGN=\"top\"> - <A HREF=\"index.php\">home</A><BR> - <A HREF=\"module.php?mod=faq\">faq</A><BR> - <A HREF=\"search.php\">search</A> - </TD> - <TD ALIGN=\"right\" VALIGN=\"top\"> - <A HREF=\"module.php?mod=diary\">diary</A><BR> - <A HREF=\"submit.php\">submit news</A><BR> - <A HREF=\"account.php\">account</A> - </TD> - </TR>"); - -PHP?> + $this->box("Drop where?", "<TR> + <TD ALIGN=\"left\" VALIGN=\"top\"> + <A HREF=\"index.php\">home</A><BR> + <A HREF=\"module.php?mod=faq\">faq</A><BR> + <A HREF=\"search.php\">search</A> + </TD> + <TD ALIGN=\"right\" VALIGN=\"top\"> + <A HREF=\"module.php?mod=diary\">diary</A><BR> + <A HREF=\"submit.php\">submit news</A><BR> + <A HREF=\"account.php\">account</A> + </TD> + </TR>"); + +?> </TD> </TR> @@ -67,7 +67,7 @@ PHP?> <?PHP theme_blocks("left", $this); -PHP?> +?> </TD> <TD WIDTH="80%" VALIGN="top" ALIGN="left"> @@ -79,15 +79,15 @@ PHP?> function abstract($story) { $timestamp = format_date($story->timestamp); -PHP?> +?> <TABLE WIDTH="100%" CELLPADDING="0" CELLSPACING="0" BORDER="0"> <TR> - <TD ALIGN="left" VALIGN="bottom" WIDTH="20" HEIGHT="20" BACKGROUND="themes/jeroen/images/<?PHP echo (rand(0, 1) ? "news1.gif" : "news3.gif"); PHP?>" NOWRAP> </TD> + <TD ALIGN="left" VALIGN="bottom" WIDTH="20" HEIGHT="20" BACKGROUND="themes/jeroen/images/<?PHP echo (rand(0, 1) ? "news1.gif" : "news3.gif"); ?>" NOWRAP> </TD> <TD ALIGN="center" VALIGN="top" WIDTH="100%" BACKGROUND="themes/jeroen/images/newsmiddle.gif" NOWRAP> - <B><?PHP echo "". check_output($story->subject) .""; PHP?></B> + <B><?PHP echo "". check_output($story->subject) .""; ?></B> </TD> - <TD ALIGN="right" VALIGN="bottom" WIDTH="20" BACKGROUND="themes/jeroen/images/<?PHP echo (rand(0,1) == 0) ? "news2.gif" : "news4.gif"; if (rand(0,100) == 50) "news5.gif"; PHP?>" NOWRAP> </TD> + <TD ALIGN="right" VALIGN="bottom" WIDTH="20" BACKGROUND="themes/jeroen/images/<?PHP echo (rand(0,1) == 0) ? "news2.gif" : "news4.gif"; if (rand(0,100) == 50) "news5.gif"; ?>" NOWRAP> </TD> </TR> <TR> <TD></TD> @@ -95,7 +95,7 @@ PHP?> <TABLE BORDER="0" CELLPADDING="1" CELLSPACING="0" BGCOLOR="#000000" WIDTH="100%"> <TR> <TD> - <TABLE BORDER="0" CELLPADDING="2" CELLSPACING="0" WIDTH="100%" BACKGROUND="themes/jeroen/images/sketch.gif"> + <TABLE BORDER="0" CELLPADDING="2" CELLSPACING="0" WIDTH="100%" BGCOLOR="#E7E7E7" BACKGROUND="themes/jeroen/images/sketch.gif"> <TR> <TD ALIGN="left" BACKGROUND="themes/jeroen/images/menutitle.gif" NOWRAP> <FONT COLOR="#FEFEFE"> @@ -116,9 +116,9 @@ PHP?> </FONT> </TD> <TD ALIGN=\"right\" BACKGROUND=\"themes/jeroen/images/menutitle.gif\" NOWRAP> - <B><A HREF=\"search.php?category=". urlencode($story->section) ."\"><FONT COLOR=\"<? $this->fgc3; ?>\">$story->section</FONT></A></B>"; + <B><A HREF=\"search.php?category=". urlencode($story->section) ."\"><FONT COLOR=\"#000000\">$story->section</FONT></A></B>"; -PHP?> +?> </TD> </TR> @@ -132,12 +132,12 @@ PHP?> if ($story->abstract) echo "<P>". check_output($story->abstract, 1) ."</P>"; -PHP?> +?> </TD> </TR> <TR> - <TD ALIGN="right"> - <FONT COLOR="#E09226"><? echo theme_morelink($this, $story); ?></FONT> + <TD COLSPAN="2" ALIGN="right"> + <FONT COLOR="#E09226"><?PHP echo theme_morelink($this, $story); ?></FONT> </TD> </TR> </TABLE> @@ -156,15 +156,15 @@ PHP?> function article($story, $reply) { $timestamp = format_date($story->timestamp); -PHP?> +?> <TABLE WIDTH="100%" CELLPADDING="0" CELLSPACING="0" BORDER="0"> <TR> - <TD ALIGN="left" VALIGN="bottom" WIDTH="20" HEIGHT="20" BACKGROUND="themes/jeroen/images/<?PHP echo (rand(0, 1) ? "news1.gif" : "news3.gif");PHP ?>" NOWRAP> </TD> + <TD ALIGN="left" VALIGN="bottom" WIDTH="20" HEIGHT="20" BACKGROUND="themes/jeroen/images/<?PHP echo (rand(0, 1) ? "news1.gif" : "news3.gif"); ?>" NOWRAP> </TD> <TD ALIGN="center" VALIGN="top" WIDTH="100%" BACKGROUND="themes/jeroen/images/newsmiddle.gif" NOWRAP> - <B><?PHP echo "". check_output($story->subject) .""; PHP?></B> + <B><?PHP echo "". check_output($story->subject) .""; ?></B> </TD> - <TD ALIGN="right" VALIGN="bottom" WIDTH="20" BACKGROUND="themes/jeroen/images/<?PHP echo (rand(0, 1) == 0) ? "news2.gif" : "news4.gif"; if (rand(0, 100) == 50) $img = "news5.gif"; PHP?>" NOWRAP> </TD> + <TD ALIGN="right" VALIGN="bottom" WIDTH="20" BACKGROUND="themes/jeroen/images/<?PHP echo (rand(0, 1) == 0) ? "news2.gif" : "news4.gif"; if (rand(0, 100) == 50) $img = "news5.gif"; ?>" NOWRAP> </TD> </TR> <TR> <TD></TD> @@ -172,7 +172,7 @@ PHP?> <TABLE BORDER="0" CELLPADDING="1" CELLSPACING="0" BGCOLOR="#000000" WIDTH="100%"> <TR> <TD> - <TABLE BORDER="0" CELLPADDING="2" CELLSPACING="0" WIDTH="100%" BACKGROUND="themes/jeroen/images/sketch.gif"> + <TABLE BORDER="0" CELLPADDING="2" CELLSPACING="0" WIDTH="100%" BGCOLOR="#E7E7E7" BACKGROUND="themes/jeroen/images/sketch.gif"> <TR> <TD ALIGN="left" BACKGROUND="themes/jeroen/images/menutitle.gif" NOWRAP> <FONT COLOR="#FEFEFE"> @@ -195,16 +195,16 @@ PHP?> </FONT> </TD> <TD ALIGN=\"right\" BACKGROUND=\"themes/jeroen/images/menutitle.gif\" NOWRAP> - <B><A HREF=\"search.php?category=". urlencode($story->section) ."\"><FONT COLOR=\"<? $this->fgc3; ?>\">$story->section</FONT></A></B>"; + <B><A HREF=\"search.php?category=". urlencode($story->section) ."\"><FONT COLOR=\"#000000\">$story->section</FONT></A></B>"; } else { - echo "<FONT SIZE=\"-1\">Reported to us by $anonymous on $story->timestamp"; ?><? print "</FONT> + echo "<FONT SIZE=\"-1\">Reported to us by $anonymous on $story->timestamp"; ?><?PHP print "</FONT> </TD> <TD ALIGN=\"right\" BACKGROUND=\"themes/jeroen/images/menutitle.gif\" NOWRAP> - <A HREF=\"search.php?category=". urlencode($story->section) ."\"><FONT COLOR=\"<? $this->fgc3; ?>\">$story->section</FONT></A>"; + <A HREF=\"search.php?category=". urlencode($story->section) ."\"><FONT COLOR=\"#000000\">$story->section</FONT></A>"; } -PHP?> +?> </FONT> </TD> @@ -221,13 +221,13 @@ PHP?> if ($story->article) echo "<P>". check_output($story->article, 1) ."</P>"; -PHP?> +?> </TD> </TR> <TR> - <TD ALIGN="right"> - <FONT COLOR="#E09226"><? echo $reply; ?></FONT> + <TD COLSPAN="2" ALIGN="right"> + <FONT COLOR="#E09226"><?PHP echo $reply; ?></FONT> </TD> </TR> </TABLE> @@ -318,20 +318,20 @@ PHP?> $width = rand(10, 200); $img2 = (rand(0, 100) == 50) ? "boxtopleftside2.gif" : "boxtopleftside1.gif"; -PHP?> +?> <TABLE WIDTH="100%" ALIGN="center" CELLPADDING="0" CELLSPACING="0" BORDER="0"> <TR> <TD WIDTH="20" HEIGHT="20" BACKGROUND="themes/jeroen/images/boxtopleft.gif" NOWRAP> </TD> - <TD WIDTH="<? echo $width; ?>" BACKGROUND="themes/jeroen/images/boxtop.gif"> </TD> + <TD WIDTH="<?PHP echo $width; ?>" BACKGROUND="themes/jeroen/images/boxtop.gif"> </TD> <TD BACKGROUND="themes/jeroen/images/boxtopmiddle.gif"> </TD> <TD BACKGROUND="themes/jeroen/images/boxtop.gif"> </TD> <TD WIDTH="20" BACKGROUND="themes/jeroen/images/boxtopright.gif" NOWRAP> </TD> </TR> <TR> - <TD BACKGROUND="themes/jeroen/images/<? echo $img2; ?>" HEIGHT="20"> </TD> + <TD BACKGROUND="themes/jeroen/images/<?PHP echo $img2; ?>" HEIGHT="20"> </TD> <TD ALIGN="center" WIDTH="100%" COLSPAN="3" BACKGROUND="themes/jeroen/images/menutitle.gif" NOWRAP> - <FONT COLOR="#FEFEFE"><? echo $subject; ?></FONT> + <FONT COLOR="#FEFEFE"><?PHP echo $subject; ?></FONT> </TD> <TD BACKGROUND="themes/jeroen/images/boxtoprightside.gif"> </TD> </TR> @@ -341,7 +341,7 @@ PHP?> <TABLE> <TR> <TD> - <?PHP echo $content; PHP?> + <?PHP echo $content; ?> </TD> </TR> </TABLE> @@ -351,7 +351,7 @@ PHP?> <TR> <TD BACKGROUND="themes/jeroen/images/boxbottomleft.gif" HEIGHT="20" NOWRAP> </TD> <TD COLSPAN="3" BACKGROUND="themes/jeroen/images/boxbottom.gif"> </TD> - <TD BACKGROUND="themes/jeroen/images/<? echo $img; ?>" NOWRAP> </TD> + <TD BACKGROUND="themes/jeroen/images/<?PHP echo $img; ?>" NOWRAP> </TD> </TR> </TABLE> <BR> @@ -362,7 +362,7 @@ PHP?> function footer() { -PHP?> +?> </TD> <TD WIDTH="20%" VALIGN="top" ALIGN="right"> @@ -374,7 +374,7 @@ PHP?> theme_account($this); theme_blocks("right", $this); -PHP?> +?> </TD> </TR> @@ -396,8 +396,10 @@ PHP?> </TABLE> </BODY> </HTML> -<? + +<?PHP + } } -?> +?>
\ No newline at end of file |