diff options
| author | Steven Wittens <steven@10.no-reply.drupal.org> | 2001-12-20 21:44:46 +0000 |
|---|---|---|
| committer | Steven Wittens <steven@10.no-reply.drupal.org> | 2001-12-20 21:44:46 +0000 |
| commit | e798fe83730039417ea80a790b59d4a3290c9d64 (patch) | |
| tree | 8bedfdccaf7da2f856da8c3781226daf6c108ae0 | |
| parent | 148c23d3a8bd958f85d6fbf46a9b03f061ee8ce3 (diff) | |
| download | brdo-e798fe83730039417ea80a790b59d4a3290c9d64.tar.gz brdo-e798fe83730039417ea80a790b59d4a3290c9d64.tar.bz2 | |
form_checkbox() was totally broken: a checkbox needs a value on top of being (un)checked. When it is checked, the value is sent as "name=value". When not checked, nothing is sent. Usually a value of "1" will suffice, but I added explicit separate $value and $checked parameters to make sure no mix-up occurs, and to allow more freedom.
| -rw-r--r-- | includes/common.inc | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/includes/common.inc b/includes/common.inc index ef1661132..c235c055c 100644 --- a/includes/common.inc +++ b/includes/common.inc @@ -335,8 +335,8 @@ function form_item($title, $value, $description = 0) { return ($title ? "<b>$title:</b><br />" : "") . $value . ($description ? "<br /><small><i>$description</i></small>" : "") ."<p />\n"; } -function form_checkbox($title, $name, $value, $description = 0) { - return form_item(0, "<input type=\"checkbox\" name=\"edit[$name]\" ". ($value ? " checked=\"checked\"" : "") ." /> $title", $description); +function form_checkbox($title, $name, $value = 1, $checked = 0, $description = 0) { + return form_item(0, "<input type=\"checkbox\" name=\"edit[$name]\" value=\"". $value ."\"". ($checked ? " checked=\"checked\"" : "") ." /> $title", $description); } function form_textfield($title, $name, $value, $size, $maxlength, $description = 0) { |