summaryrefslogtreecommitdiff
path: root/includes/database/mysql
diff options
context:
space:
mode:
authorDries Buytaert <dries@buytaert.net>2008-12-02 19:45:01 +0000
committerDries Buytaert <dries@buytaert.net>2008-12-02 19:45:01 +0000
commit71a22f1c1f4da46a370dd11b9e31537f255c7375 (patch)
tree41e0c79282557b7f1ed878bf78ad482c2ce2f102 /includes/database/mysql
parent8900c6156d3ab1e48c8e8ff697305ce6530fbe5a (diff)
downloadbrdo-71a22f1c1f4da46a370dd11b9e31537f255c7375.tar.gz
brdo-71a22f1c1f4da46a370dd11b9e31537f255c7375.tar.bz2
- Patch #337926 by Damien Tournoud: clean-up lower case handling.
Diffstat (limited to 'includes/database/mysql')
-rw-r--r--includes/database/mysql/database.inc15
-rw-r--r--includes/database/mysql/schema.inc2
2 files changed, 8 insertions, 9 deletions
diff --git a/includes/database/mysql/database.inc b/includes/database/mysql/database.inc
index 82c962929..661503cd6 100644
--- a/includes/database/mysql/database.inc
+++ b/includes/database/mysql/database.inc
@@ -13,11 +13,14 @@
class DatabaseConnection_mysql extends DatabaseConnection {
- protected $transactionSupport = FALSE;
-
public function __construct(Array $connection_options = array()) {
- $this->transactionSupport = isset($connection_options['transactions']) ? $connection_options['transactions'] : FALSE;
- $connection_options['port'] = !empty($connection_options['port']) ? $connection_options['port'] : 3306;
+ // This driver defaults to non transaction support.
+ $this->transactionSupport = !empty($connection_option['transactions']);
+
+ // Default to TCP connection on port 3306.
+ if (empty($connection_options['port'])) {
+ $connection_options['port'] = 3306;
+ }
$dsn = 'mysql:host=' . $connection_options['host'] . ';port=' . $connection_options['port'] . ';dbname=' . $connection_options['database'];
parent::__construct($dsn, $connection_options['username'], $connection_options['password'], array(
@@ -53,10 +56,6 @@ class DatabaseConnection_mysql extends DatabaseConnection {
return 'mysql';
}
- public function supportsTransactions() {
- return $this->transactionSupport;
- }
-
public function mapConditionOperator($operator) {
// We don't want to override any of the defaults.
return NULL;
diff --git a/includes/database/mysql/schema.inc b/includes/database/mysql/schema.inc
index 40f45aeb8..bbc9a9ca0 100644
--- a/includes/database/mysql/schema.inc
+++ b/includes/database/mysql/schema.inc
@@ -92,7 +92,7 @@ class DatabaseSchema_mysql extends DatabaseSchema {
$sql .= ' auto_increment';
}
- // $spec['default'] can be NULL, so we explicitely check for the key here.
+ // $spec['default'] can be NULL, so we explicitly check for the key here.
if (array_key_exists('default', $spec)) {
if (is_string($spec['default'])) {
$spec['default'] = "'" . $spec['default'] . "'";