diff options
| author | Dries Buytaert <dries@buytaert.net> | 2007-07-23 07:29:29 +0000 |
|---|---|---|
| committer | Dries Buytaert <dries@buytaert.net> | 2007-07-23 07:29:29 +0000 |
| commit | 772a2d39d2ba8d567fe42ad45be212dd7f7e75ab (patch) | |
| tree | 4dcf95136c0fda0f921b6aaed9e9d7bf81bcda8f /includes | |
| parent | 837350ecc252ea341cd9fd63a4ebeb1240fb0e79 (diff) | |
| download | brdo-772a2d39d2ba8d567fe42ad45be212dd7f7e75ab.tar.gz brdo-772a2d39d2ba8d567fe42ad45be212dd7f7e75ab.tar.bz2 | |
- Patch #40545 by Moshe: reduces contention in the users table.
Diffstat (limited to 'includes')
| -rw-r--r-- | includes/session.inc | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/includes/session.inc b/includes/session.inc index e9464c20a..b842b1218 100644 --- a/includes/session.inc +++ b/includes/session.inc @@ -75,8 +75,9 @@ function sess_write($key, $value) { else { db_query("UPDATE {sessions} SET uid = %d, cache = %d, hostname = '%s', session = '%s', timestamp = %d WHERE sid = '%s'", $user->uid, isset($user->cache) ? $user->cache : '', ip_address(), $value, time(), $key); - // TODO: this can be an expensive query. Perhaps only execute it every x minutes. Requires investigation into cache expiration. - if ($user->uid) { + // Last access time is updated no more frequently than once every 180 seconds. + // This reduces contention in the users table. + if ($user->uid && time() - $user->access > variable_get('session_write_interval', 180)) { db_query("UPDATE {users} SET access = %d WHERE uid = %d", time(), $user->uid); } } |