summaryrefslogtreecommitdiff
path: root/includes
diff options
context:
space:
mode:
authorwebchick <webchick@24967.no-reply.drupal.org>2011-06-04 11:13:28 -0700
committerwebchick <webchick@24967.no-reply.drupal.org>2011-06-04 11:13:28 -0700
commitdf642fea996fbfb85fe4ed3b8ec1989c9aaa2683 (patch)
tree3caf085b076c7b7007b85111a347df65f8eb3e9d /includes
parent02d6d3541ac9c8f9b6cb7e14cffd58bdd0096fb4 (diff)
downloadbrdo-df642fea996fbfb85fe4ed3b8ec1989c9aaa2683.tar.gz
brdo-df642fea996fbfb85fe4ed3b8ec1989c9aaa2683.tar.bz2
Issue #1038030 by yched: Fixed More accurate error handling in EntityFieldQuery : non-existing field.
Diffstat (limited to 'includes')
-rw-r--r--includes/entity.inc12
1 files changed, 10 insertions, 2 deletions
diff --git a/includes/entity.inc b/includes/entity.inc
index aaa39d871..9ee7889cf 100644
--- a/includes/entity.inc
+++ b/includes/entity.inc
@@ -651,7 +651,11 @@ class EntityFieldQuery {
*/
public function fieldCondition($field, $column = NULL, $value = NULL, $operator = NULL, $delta_group = NULL, $language_group = NULL) {
if (is_scalar($field)) {
- $field = field_info_field($field);
+ $field_definition = field_info_field($field);
+ if (empty($field_definition)) {
+ throw new EntityFieldQueryException(t('Unknown field: @field_name', array('@field_name' => $field)));
+ }
+ $field = $field_definition;
}
// Ensure the same index is used for fieldConditions as for fields.
$index = count($this->fields);
@@ -753,7 +757,11 @@ class EntityFieldQuery {
*/
public function fieldOrderBy($field, $column, $direction = 'ASC') {
if (is_scalar($field)) {
- $field = field_info_field($field);
+ $field_definition = field_info_field($field);
+ if (empty($field_definition)) {
+ throw new EntityFieldQueryException(t('Unknown field: @field_name', array('@field_name' => $field)));
+ }
+ $field = $field_definition;
}
// Save the index used for the new field, for later use in field storage.
$index = count($this->fields);