diff options
| author | Dries Buytaert <dries@buytaert.net> | 2010-10-28 02:27:09 +0000 |
|---|---|---|
| committer | Dries Buytaert <dries@buytaert.net> | 2010-10-28 02:27:09 +0000 |
| commit | 1d0f6479da4cdbd14b747ead6cb934a769a9579d (patch) | |
| tree | 3875e9403a28aac4477a3531379c85b6b10cd660 /modules/openid | |
| parent | 0344a78d9643d97e1aff8ab94fec551bc091bfbc (diff) | |
| download | brdo-1d0f6479da4cdbd14b747ead6cb934a769a9579d.tar.gz brdo-1d0f6479da4cdbd14b747ead6cb934a769a9579d.tar.bz2 | |
- Patch #839556 by jrchamp, dmitrig01: remove pointless usage of array_key_exists().
Diffstat (limited to 'modules/openid')
| -rw-r--r-- | modules/openid/openid.inc | 2 | ||||
| -rw-r--r-- | modules/openid/openid.module | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/modules/openid/openid.inc b/modules/openid/openid.inc index 5a9326905..48af76669 100644 --- a/modules/openid/openid.inc +++ b/modules/openid/openid.inc @@ -501,7 +501,7 @@ function _openid_dh_rand($stop) { // Used as the key for the duplicate cache $rbytes = _openid_dh_long_to_binary($stop); - if (array_key_exists($rbytes, $duplicate_cache)) { + if (isset($duplicate_cache[$rbytes])) { list($duplicate, $nbytes) = $duplicate_cache[$rbytes]; } else { diff --git a/modules/openid/openid.module b/modules/openid/openid.module index 7e7ebfd05..3e1b2c96b 100644 --- a/modules/openid/openid.module +++ b/modules/openid/openid.module @@ -932,7 +932,7 @@ function openid_verify_assertion_return_url($service, $response) { // contains a number of other parameters added by the OpenID Provider. parse_str(isset($return_to_parts['query']) ? $return_to_parts['query'] : '', $return_to_query_parameters); foreach ($return_to_query_parameters as $name => $value) { - if (!array_key_exists($name, $_GET) || $_GET[$name] != $value) { + if (!isset($_GET[$name]) || $_GET[$name] != $value) { return FALSE; } } |