diff options
author | Dries Buytaert <dries@buytaert.net> | 2003-07-12 22:21:55 +0000 |
---|---|---|
committer | Dries Buytaert <dries@buytaert.net> | 2003-07-12 22:21:55 +0000 |
commit | 22b6d2f30cb1d5a0e7b4f1385ddba79e59dc0b34 (patch) | |
tree | 68745484c801b5b3155f8ac068140a0a74f0d558 /modules/poll/poll.module | |
parent | d5cdbcd6444e9d36db64c1f80a70611f779ede94 (diff) | |
download | brdo-22b6d2f30cb1d5a0e7b4f1385ddba79e59dc0b34.tar.gz brdo-22b6d2f30cb1d5a0e7b4f1385ddba79e59dc0b34.tar.bz2 |
- Performance improvement: changed a fair amount of "left joins" to "inner
joins". Patch by Gerhard.
Diffstat (limited to 'modules/poll/poll.module')
-rw-r--r-- | modules/poll/poll.module | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/modules/poll/poll.module b/modules/poll/poll.module index 9df886bc8..07786b295 100644 --- a/modules/poll/poll.module +++ b/modules/poll/poll.module @@ -66,7 +66,7 @@ function poll_block($op = "list", $delta = 0) { function poll_cron() { // Close polls that have exceeded their allowed runtime - $result = db_query("SELECT p.nid FROM {poll} p LEFT JOIN {node} n ON p.nid=n.nid WHERE (n.created + p.runtime) < '". time() ."' AND p.active = '1' AND p.runtime != '0'"); + $result = db_query("SELECT p.nid FROM {poll} p INNER JOIN {node} n ON p.nid=n.nid WHERE (n.created + p.runtime) < '". time() ."' AND p.active = '1' AND p.runtime != '0'"); while ($poll = db_fetch_object($result)) { db_query("UPDATE {poll} SET active='0' WHERE nid = %d", $poll->nid); } @@ -221,7 +221,7 @@ function poll_node($field) { function poll_page() { theme("header"); - $result = db_query("SELECT n.nid, n.title, p.active, SUM(c.chvotes) AS votes FROM {node} n LEFT JOIN {poll} p ON n.nid=p.nid LEFT JOIN {poll_choices} c ON n.nid=c.nid WHERE type = 'poll' AND status = '1' AND moderate = '0' GROUP BY n.nid, n.title, p.active, n.created ORDER BY n.created DESC"); + $result = db_query("SELECT n.nid, n.title, p.active, SUM(c.chvotes) AS votes FROM {node} n INNER JOIN {poll} p ON n.nid=p.nid INNER JOIN {poll_choices} c ON n.nid=c.nid WHERE type = 'poll' AND status = '1' AND moderate = '0' GROUP BY n.nid, n.title, p.active, n.created ORDER BY n.created DESC"); $output = "<ul>"; while ($node = db_fetch_object($result)) { $output .= "<li>".l($node->title, "node/view/$node->nid") ." - ". format_plural($node->votes, "1 vote", "%count votes") ." - ". ($node->active ? t("open") : t("closed")) ."</li>"; |