diff options
author | Angie Byron <webchick@24967.no-reply.drupal.org> | 2010-01-09 02:51:09 +0000 |
---|---|---|
committer | Angie Byron <webchick@24967.no-reply.drupal.org> | 2010-01-09 02:51:09 +0000 |
commit | 1f6a553cd2f8eeb531e6404d793797cb19bcfaf4 (patch) | |
tree | d6202498a9abe607b3d7252a0a9ce99c9318ea76 /modules | |
parent | 25747314e2b923f90f44e69c896d3aa0e0087dce (diff) | |
download | brdo-1f6a553cd2f8eeb531e6404d793797cb19bcfaf4.tar.gz brdo-1f6a553cd2f8eeb531e6404d793797cb19bcfaf4.tar.bz2 |
#629794 follow-up by yched: Fixed batch API in update.php.
Diffstat (limited to 'modules')
-rw-r--r-- | modules/system/system.install | 20 | ||||
-rw-r--r-- | modules/system/system.queue.inc | 18 |
2 files changed, 14 insertions, 24 deletions
diff --git a/modules/system/system.install b/modules/system/system.install index 519cbabda..47ee14415 100644 --- a/modules/system/system.install +++ b/modules/system/system.install @@ -2590,25 +2590,11 @@ function system_update_7043() { } /** - * Reuse the actions_aid table as sequences. + * Drop the actions_aid table. */ function system_update_7044() { - $schema['sequences'] = array( - 'description' => 'Stores IDs.', - 'fields' => array( - 'value' => array( - 'description' => 'The value of the sequence.', - 'type' => 'serial', - 'unsigned' => TRUE, - 'not null' => TRUE, - ), - ), - 'primary key' => array('value'), - ); - db_create_table('sequences', $schema['sequences']); - $max_aid = db_query('SELECT MAX(aid) FROM {actions_aid}')->fetchField(); - $max_uid = db_query('SELECT MAX(uid) FROM {users}')->fetchField(); - db_insert('sequences')->fields(array('value' => max($max_aid, $max_uid)))->execute(); + // The current value of the increment has been taken into account when + // creating the sequences table in update_fix_d7_requirements(). db_drop_table('actions_aid'); } diff --git a/modules/system/system.queue.inc b/modules/system/system.queue.inc index bac1ff26e..586681181 100644 --- a/modules/system/system.queue.inc +++ b/modules/system/system.queue.inc @@ -179,13 +179,17 @@ class SystemQueue implements DrupalQueueInterface { } public function createItem($data) { - $record = new stdClass(); - $record->name = $this->name; - $record->data = $data; - // We cannot rely on REQUEST_TIME because many items might be created by a - // single request which takes longer than 1 second. - $record->created = time(); - return drupal_write_record('queue', $record) !== FALSE; + // During a Drupal 6.x to 7.x update, drupal_get_schema() does not contain + // the queue table yet, so we cannot rely on drupal_write_record(). + $query = db_insert('queue') + ->fields(array( + 'name' => $this->name, + 'data' => serialize($data), + // We cannot rely on REQUEST_TIME because many items might be created + // by a single request which takes longer than 1 second. + 'created' => time(), + )); + return (bool) $query->execute(); } public function numberOfItems() { |