- Patch #5393 by Goba: changes the search hook return value, and requires an array

  containing two elements, the first being the requested title, and the second being
  the result list. Advantages:
    * Cleaner search code in common.inc
    * Po extraction is possible and works fine
    * No hardcoded exceptions for node and comment modules, since any module can
      return results in order of relevance (or another order)

6 files changed, 6 insertions, 6 deletions

diff --git a/modules/comment.module b/modules/comment.module
index 7bd5b5240..4e78e7677 100644
--- a/modules/comment.module
+++ b/modules/comment.module
@@ -1622,7 +1622,7 @@ function comment_search($keys) {
 
   $find = do_search(array("keys" => $keys, "type" => "comment", "select" => "select s.lno as lno, c.nid as nid, c.subject as title, c.timestamp as created, u.uid as uid, u.name as name, s.count as count FROM {search_index} s, {comments} c INNER JOIN {users} u ON c.uid = u.uid WHERE s.lno = c.cid AND s.type = 'comment' AND c.status = 0 AND s.word like '%'"));
 
-  return $find;
+  return array(t("Matching comments ranked in order of relevance"), $find);
 }
 
 function comment_update_index() {
diff --git a/modules/comment/comment.module b/modules/comment/comment.module
index 7bd5b5240..4e78e7677 100644
--- a/modules/comment/comment.module
+++ b/modules/comment/comment.module
@@ -1622,7 +1622,7 @@ function comment_search($keys) {
 
   $find = do_search(array("keys" => $keys, "type" => "comment", "select" => "select s.lno as lno, c.nid as nid, c.subject as title, c.timestamp as created, u.uid as uid, u.name as name, s.count as count FROM {search_index} s, {comments} c INNER JOIN {users} u ON c.uid = u.uid WHERE s.lno = c.cid AND s.type = 'comment' AND c.status = 0 AND s.word like '%'"));
 
-  return $find;
+  return array(t("Matching comments ranked in order of relevance"), $find);
 }
 
 function comment_update_index() {
diff --git a/modules/node.module b/modules/node.module
index 7b0bd1cb0..c902fd3b5 100644
--- a/modules/node.module
+++ b/modules/node.module
@@ -566,7 +566,7 @@ function node_search($keys) {
   //
   $find = do_search(array("keys" => $keys, "type" => "node", "select" => "select s.lno as lno, n.title as title, n.created as created, u.uid as uid, u.name as name, s.count as count FROM {search_index} s, {node} n INNER JOIN {users} u ON n.uid = u.uid WHERE s.lno = n.nid AND s.type = 'node' AND s.word like '%' AND n.status = 1"));
 
-  return $find;
+  return array(t("Matching nodes ranked in order of relevance"), $find);
 }
 
 function node_settings() {
diff --git a/modules/node/node.module b/modules/node/node.module
index 7b0bd1cb0..c902fd3b5 100644
--- a/modules/node/node.module
+++ b/modules/node/node.module
@@ -566,7 +566,7 @@ function node_search($keys) {
   //
   $find = do_search(array("keys" => $keys, "type" => "node", "select" => "select s.lno as lno, n.title as title, n.created as created, u.uid as uid, u.name as name, s.count as count FROM {search_index} s, {node} n INNER JOIN {users} u ON n.uid = u.uid WHERE s.lno = n.nid AND s.type = 'node' AND s.word like '%' AND n.status = 1"));
 
-  return $find;
+  return array(t("Matching nodes ranked in order of relevance"), $find);
 }
 
 function node_settings() {
diff --git a/modules/user.module b/modules/user.module
index 68c2b6eb7..79f490ad5 100644
--- a/modules/user.module
+++ b/modules/user.module
@@ -300,7 +300,7 @@ function user_search($keys) {
   while ($account = db_fetch_object($result)) {
     $find[] = array("title" => $account->name, "link" => (strstr(request_uri(), "admin") ? url("admin/user/edit/$account->uid") : url("user/view/$account->uid")), "user" => $account->name);
   }
-  return $find;
+  return array(t("Matching users"), $find);
 }
 
 function user_block($op = "list", $delta = 0) {
diff --git a/modules/user/user.module b/modules/user/user.module
index 68c2b6eb7..79f490ad5 100644
--- a/modules/user/user.module
+++ b/modules/user/user.module
@@ -300,7 +300,7 @@ function user_search($keys) {
   while ($account = db_fetch_object($result)) {
     $find[] = array("title" => $account->name, "link" => (strstr(request_uri(), "admin") ? url("admin/user/edit/$account->uid") : url("user/view/$account->uid")), "user" => $account->name);
   }
-  return $find;
+  return array(t("Matching users"), $find);
 }
 
 function user_block($op = "list", $delta = 0) {