- Patch #270045 by drewish, Susurrus: clean up return values.

3 files changed, 6 insertions, 5 deletions

diff --git a/modules/aggregator/aggregator.module b/modules/aggregator/aggregator.module
index 33796a5a9..d75c67777 100644
--- a/modules/aggregator/aggregator.module
+++ b/modules/aggregator/aggregator.module
@@ -680,7 +680,7 @@ function aggregator_parse_w3cdtf($date_str) {
  * @param $feed
  *   An associative array describing the feed to be parsed.
  * @return
- *   0 on error, 1 otherwise.
+ *   FALSE on error, TRUE otherwise.
  */
 function aggregator_parse_feed(&$data, $feed) {
   global $items, $image, $channel;
@@ -699,7 +699,7 @@ function aggregator_parse_feed(&$data, $feed) {
   if (!xml_parse($xml_parser, $data, 1)) {
     watchdog('aggregator', 'The feed from %site seems to be broken, due to an error "%error" on line %line.', array('%site' => $feed['title'], '%error' => xml_error_string(xml_get_error_code($xml_parser)), '%line' => xml_get_current_line_number($xml_parser)), WATCHDOG_WARNING);
     drupal_set_message(t('The feed from %site seems to be broken, because of error "%error" on line %line.', array('%site' => $feed['title'], '%error' => xml_error_string(xml_get_error_code($xml_parser)), '%line' => xml_get_current_line_number($xml_parser))), 'error');
-    return 0;
+    return FALSE;
   }
   xml_parser_free($xml_parser);
 
@@ -801,7 +801,7 @@ function aggregator_parse_feed(&$data, $feed) {
     db_query('DELETE FROM {aggregator_item} WHERE fid = %d AND timestamp < %d', $feed['fid'], $age);
   }
 
-  return 1;
+  return TRUE;
 }
 
 /**
diff --git a/modules/comment/comment.module b/modules/comment/comment.module
index 635f64192..ce84a6e34 100644
--- a/modules/comment/comment.module
+++ b/modules/comment/comment.module
@@ -1129,6 +1129,7 @@ function comment_num_replies($pid) {
  * @param $timestamp
  *   Time to count from (defaults to time of last user access
  *   to node).
+ * @return The result or FALSE on error.
  */
 function comment_num_new($nid, $timestamp = 0) {
   global $user;
@@ -1146,7 +1147,7 @@ function comment_num_new($nid, $timestamp = 0) {
     return $result;
   }
   else {
-    return 0;
+    return FALSE;
   }
 
 }
diff --git a/modules/user/user.module b/modules/user/user.module
index 18f3dbe01..dfaccd72d 100644
--- a/modules/user/user.module
+++ b/modules/user/user.module
@@ -91,7 +91,7 @@ function user_external_load($authname) {
     return user_load($user);
   }
   else {
-    return 0;
+    return FALSE;
   }
 }