diff options
| author | Dries Buytaert <dries@buytaert.net> | 2000-11-13 08:17:45 +0000 |
|---|---|---|
| committer | Dries Buytaert <dries@buytaert.net> | 2000-11-13 08:17:45 +0000 |
| commit | 9559f61fcab156477dd45f4926664b74c3c2d65d (patch) | |
| tree | 4c0fb62ac3dca254a2c22023e81d50eb51e579a1 /themes | |
| parent | d4fc1dfa888305c57f52730ba9dcec800896c004 (diff) | |
| download | brdo-9559f61fcab156477dd45f4926664b74c3c2d65d.tar.gz brdo-9559f61fcab156477dd45f4926664b74c3c2d65d.tar.bz2 | |
Another batch with a lot of internal updates, yet no visual changes to the
site:
- watchdog (rewrite):
+ the collected information provides more details and insights
for post-mortem research
+ input limitation
- database abstraction layer:
+ mysql errors are now verbose and is no longer displayed in a
browser - fixes a possible security risk
- admin.php:
+ updated watchdog page
+ fixed security flaw
- diary.php:
+ fixed nl2br problem
- themes:
+ fixed comment bug in all 3 themes.
- misc:
+ renamed some global variables for sake of consistency:
$sitename --> $site_name
$siteurl --> $site_url
+ added input check where (a) exploitable and (b) possible
+ added input size check
+ various small improvements
+ fixed various typoes
... and much, much more in fact.
Diffstat (limited to 'themes')
| -rw-r--r-- | themes/marvin/marvin.theme | 6 | ||||
| -rw-r--r-- | themes/unconed/unconed.theme | 10 |
2 files changed, 7 insertions, 9 deletions
diff --git a/themes/marvin/marvin.theme b/themes/marvin/marvin.theme index 916aab382..c2e3631e4 100644 --- a/themes/marvin/marvin.theme +++ b/themes/marvin/marvin.theme @@ -20,12 +20,12 @@ # Syntax.......: header($title); # Description..: a function to draw the page header. function header($title) { - global $sitename; + global $site_name; ?> <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0//EN" "http://www.w3.org/TR/REC-html40/strict.dtd"> <HTML> <HEAD> - <TITLE><? print $sitename; ?></TITLE> + <TITLE><? print $site_name; ?></TITLE> <META NAME="description" CONTENT="drop.org"> <META NAME="keywords" CONTENT="drop, weblog, portal, community, news, article, announcements, stories, story, computer, science, space, hype, cult, geek, nerd, foo, bar"> </HEAD> @@ -189,7 +189,7 @@ ### Moderation: print " <TD ALIGN=\"right\" ROWSPAN=\"3\" VALIGN=\"middle\" WIDTH=\"15%\">\n"; - display_comment_moderation($comment->cid, $comment->poster, $comment->score, $comment->votes); + display_comment_moderation($comment->cid, $comment->userid, $comment->score, $comment->votes); print " </TD>\n"; print " </TR>\n"; diff --git a/themes/unconed/unconed.theme b/themes/unconed/unconed.theme index 2d6029b57..201a8c0a0 100644 --- a/themes/unconed/unconed.theme +++ b/themes/unconed/unconed.theme @@ -31,12 +31,12 @@ # Syntax.......: header($title); # Description..: a function to draw the page header. function header($title) { - global $sitename; + global $site_name; srand((double)microtime()*1000000); ?> <HTML> <HEAD> - <TITLE><? echo $sitename; ?></TITLE> + <TITLE><? echo $site_name; ?></TITLE> <META NAME="description" CONTENT="drop.org"> <META NAME="keywords" CONTENT="drop, weblog, portal, community, news, article, announcements, stories, story, computer, science, space, hype, cult, geek, nerd, foo, bar"> </HEAD> @@ -220,9 +220,7 @@ function comment($comment, $link, $thread = "") { print "<A NAME=\"$comment->cid\"></A>\n"; - $timestamp = format_date($timestamp); - - print "\n<!-- Comment: \"$subject\" by $poster -->\n"; + print "\n<!-- Comment: \"$comment->subject\" by $comment->userid -->\n"; ?> <TABLE BORDER="0" CELLPADDING="0" CELLSPACING="0" BGCOLOR="<? echo $this->brcolor1; ?>" WIDTH="100%"> @@ -243,7 +241,7 @@ ### Moderation: echo " <TD ALIGN=\"right\" ROWSPAN=\"3\" VALIGN=\"middle\" WIDTH=\"15%\">"; - display_comment_moderation($comment->cid, $comment->poster, $comment->score, $comment->votes); + display_comment_moderation($comment->cid, $comment->userid, $comment->score, $comment->votes); echo " </TD>"; echo " </TR>"; |