| Commit message (Collapse) | Author | Age |
|---|
| |
|
|
| |
installations where the comment.module is turned on, $comments is never set to 0, and posts that have no comments instead get the value of the last successful comment_num_all. The attached patch corrects this ($comments is set to 0 before we do anything) and also merges the if statements.
|
| |
|
|
| |
later.
|
| |
|
|
| |
little and made the form groups use consistent titles.
|
| |
|
|
| |
'home » administer » settings" page.
|
| | |
|
| | |
|
| | |
|
| |
|
|
| |
now (if they are not already there).
|
| |
|
|
|
|
|
|
|
| |
stand out a bit better by using green-ish and red-ish colors, resp.
for 'success' and 'failure'.
- Small change to the way context-sensitive help texts are emitted -
the pages wouldn't validate in the presence of help texts with
block-level elements.
|
| |
|
|
|
|
| |
all the commonly used ones, can handle blocks on either side, and there is no way to see the preview without saving and seeing the results on the site.
Anything else that can be removed? Less is more.
|
| |
|
|
| |
not have the 'access users' permission set.
|
| | |
|
| |
|
|
| |
should not be called.
|
| | |
|
| | |
|
| |
|
|
|
| |
- If you are allowed to vote, results are now shown on a separate node tab "node/id/results".
- Poll voting now submits to a separate URL and uses drupal_goto to go back to the poll node
|
| |
|
|
| |
- Updated node.module to use drupal_goto after submission: this allows people to refresh after submission without any problems.
|
| |
|
|
|
|
|
|
| |
system is now using form_set_error() and friends like the rest of Drupal does. This makes for both a consistent user experience and consistent code. It simplifies the forms and validation code, however, it does change the node API slightly:
* The _validate hook and the _nodeapi('validate') hook of the node API (1) no longer take an 'error' parameter and (2) should no longer return an error array. To set an error, call form_set_error().
* The _form hook of the node module no longer takes a form hook and should not worry about displaying errors. Ditto for _nodeapi('form_post') and _nodeapi('form_pre').
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
|
|
| |
* slightly reorders the functions in anticipation of http://drupal.org/node/view/9010.
* reorders help definitions to match the alphabetical nature of the menu items.
* tweaked visual appearance of menu code (whitespace, etc.)
* minor tweaks to "warning" help to match style of others.
|
| | |
|
| |
|
|
| |
seems to need. It generates an error under php5. Found by redLED.
|
| |
|
|
| |
indices, which makes PHP throw a lot of warnings when the reporting level is set to E_ALL. Things run fine with these warnings, but as a matter of code style if nothing else we should probably strive to avoid them. The attached fixes most of the more egregious offenders (about 95% of the warnings when I load /node on my test site).
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
| |
* @file header with a oneliner and blurb description about watchdog.module.
* standardized the text between admin/help#watchdog and admin/logs.
* tweaked the descriptions of log types available ever so slightly.
* removed anything that referred to the old settings page.
* added an assumed 'type' to one of the menu's.
|
| | |
|
| |
|
|
|
| |
as simplifying the theming of local tasks so they can be more easily
rendered in a non-tab manner.
|
| | |
|
| |
|
|
| |
database indices.
|
| | |
|
| |
|
|
| |
overview when a topic has no comments yet.
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
| |
messages, and redirected to themselves
- Now uses drupal_goto after every form submission [1]. Patches for other modules will follow.
[1] http://lists.drupal.org/archives/drupal-devel/2004-06/msg01147.html
|
| |
|
|
|
|
| |
redirects after form submission to work properly)
- Double-quotes to Single-quotes
|
| | |
|
| | |
|
| |
|
|
| |
it.
|
| |
|
|
| |
UTF-8 safe.
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
$ diffstat user.patch
database/database.mysql | 4
database/database.pgsql | 2
database/updates.inc | 10 -
modules/block.module | 20 +-
modules/locale.module | 9
modules/profile.module | 108 +++++++----
modules/system.module | 8
modules/user.module | 456 +++++++++++++++++++-----------------------------
8 files changed, 289 insertions(+), 328 deletions(-)
More functionality, less code. Here is a list of the changes:
- Some user API changes:
+ When $type is 'form', you have to return an associative array of groups. In turn, each group is an array with a 'title', 'data' and 'weight'.
+ A new $type has been added, namely 'categories'. User settings can be organized in categories. Categories can be sorted, as can the groups within a category. (Ordering 'categories' is somewhat broken due to a bug in the menu system.)
- The 'my account > edit' page will use subtabs for each 'category'. Read: you can break down the account settings into multiple subpages.
- Profile module improvements:
+ Added support for private fields to the profile module!
+ Improved workflow of profile administration pages.
+ Improved the form descriptions.
- Code improvements:
+ Unified user_edit() and user_admin_edit().
+ Unified and cleaned up the validation code. Fixed some validation glitches too.
|
| |
|
|
| |
is not part of the selected fields.
|
| | |
|
| |
|
|
| |
and forum module.
|
| |
|
|
| |
profile fields of users.
|
| |
|
|
| |
"anonymous-but-named" comments, anonymous users can leave behind their names as opposed to the 'anonymous' setting. These names are shown as "$name (not verified)" on regular nodes. This change provides the same display for forums (assuming anonymous commenting on forums is allowed).
|
| |
|
|
| |
and user/password now show all three forms, as opposed to just the requested relevance. The attached patch implements a quick workaround: three new callbacks, and a cheapy modification of user_page where I use a ternary to test whether arg(2) exists (as it would in the case of user/nnn/edit). If it does, we set that to $op, and if it doesn't (in the case of user/login, etc.), we set arg(1).
|
