Commit message (Collapse) | Author | Age | |
---|---|---|---|
* | - Patch #40849 by wtanaka and Richard: killed some menu.inc warnings/notices. | Dries Buytaert | 2006-01-20 |
| | |||
* | - Patch #45228 and patch #45025 by m3avrck and Uwe: aggregator module ↵ | Dries Buytaert | 2006-01-20 |
| | | | | HTML/CSS cleanups. | ||
* | - Patch #45530 by Morbus: filter_form shouldn't default to #weight 0 | Dries Buytaert | 2006-01-20 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | When a form element doesn't specify a #weight, it is assumed internally as #weight 0. However, to ensure that our form elements display visually *as they were defined in the array* we, in form_builder, count the number of elements, divide by 1000, and set that as the weight: # Assign a decimal placeholder weight to preserve original array order if (!isset($form[$key]['#weight'])) { $form[$key]['#weight'] = $count/1000; } The above code will set the #weights of elements that have not defined a weight to something like 0 (first element in array definition), 0.001, 0.002, and so on. However, anytime a form element *explicitly* defines a #weight of 0, that #weight is kept at exactly 0, which would cause that form element to appear BEFORE the elements that didn't have a #weight defined (and thus received a #weight such as 0.002). Consider the following pseudo example: $form['game_title'] = array( '#type' => 'textfield', ... ); $form['game_description'] = array( '#type' => 'textarea', ... ); $form['game_format'] = filter_form(variable_get('game_format', NULL)); return $form; Here, we're not definiing weights on our two textfields. We then add an filter_form. The second parameter of the filter_form is $weight, which defaults to 0. After this $form hits form_builder, we have weights 0 (game_title), 0.001 (game_description), and 0 (filter_form) respectively. This is then sorted by weight, which causes filter_form (the third element in the array) to appear BEFORE game_description (0 is lighter than 0.001). The short lesson is: explicitly defining #weight 0 for a form element is probably a bad idea. This patch changes the default #weight of filter_form to NULL, instead of 0, and also removes any other explicit setting of #weight to 0 in core. | ||
* | - Patch #45312 by Robin and Zen: made theme_user_list() more like ↵ | Dries Buytaert | 2006-01-20 |
| | | | | theme_item_list(), made it robust for empty lists. | ||
* | - Patch #27884 by gordon: js addLoadEvent not working. | Dries Buytaert | 2006-01-20 |
| | |||
* | - Patch #45281 by chx: made categories with forum topics work again. | Dries Buytaert | 2006-01-19 |
| | |||
* | - Patch #45281 by flevour/chx: fixed problem with categories not being set ↵ | Dries Buytaert | 2006-01-19 |
| | | | | properly validated. | ||
* | - Patch #45446 by jakeg: don't generate empty >> | Dries Buytaert | 2006-01-19 |
| | |||
* | - Patch #45336 by Ber: bugfix: removed obsolete check_plain() check causing ↵ | Dries Buytaert | 2006-01-19 |
| | | | | & problems. | ||
* | - Patch #45365 by chx: critical bugfix: Fix and simplify selection options. | Dries Buytaert | 2006-01-19 |
| | |||
* | - Patch #39430 by Jaza and Richard: code improvements: improved separation ↵ | Dries Buytaert | 2006-01-19 |
| | | | | between UI and logic. | ||
* | - Patch #45349 by Morbus Iff: input filters aren't sorting correctly ↵ | Dries Buytaert | 2006-01-19 |
| | | | | infForms API. | ||
* | - #42277: Make node search indexing more robust against bad nodes and timeouts. | Steven Wittens | 2006-01-18 |
| | |||
* | - Patch #45281 by flevour/chx: fixed problem with categories not being set ↵ | Dries Buytaert | 2006-01-18 |
| | | | | properly on editing. | ||
* | - Patch #45209 by markus et al: added some missing t() functions. | Dries Buytaert | 2006-01-18 |
| | |||
* | - Patch #45301 by Morbus: corrected the weight of form item titles of nodes. | Dries Buytaert | 2006-01-18 |
| | |||
* | - Patch #44011 by Souvent22 et al: critical bugfix: make private downloads ↵ | Dries Buytaert | 2006-01-18 |
| | | | | work again. | ||
* | - Patch #45206 by markus: attempt at making the node filters somewhat ↵ | Dries Buytaert | 2006-01-18 |
| | | | | translatable. | ||
* | - Patch #45224 by jvandyk: improved PHPdoc comments. Corrected spelling, ↵ | Dries Buytaert | 2006-01-18 |
| | | | | improved grammar. | ||
* | - Modified patch #45214 by markus: don't generate empty breadcrumb div. | Dries Buytaert | 2006-01-18 |
| | |||
* | - Patch #43325 by chx/drumm/merlinofchaos: critical bugfix: made editing ↵ | Dries Buytaert | 2006-01-18 |
| | | | | comments work. | ||
* | - Patch #45259 by chx/drumm: cast to object required. | Dries Buytaert | 2006-01-18 |
| | |||
* | - Patch #42072 by m3avrck: more improvements to the node revesion overview ↵ | Dries Buytaert | 2006-01-17 |
| | | | | screen. | ||
* | - Patch #42072 by m3avrck: improved the revision overview screen. | Dries Buytaert | 2006-01-17 |
| | |||
* | - Patch #42088 by Cvbge: fixed problem with input formats gettin lost when ↵ | Dries Buytaert | 2006-01-17 |
| | | | | upgrading. | ||
* | - Patch #45041 by markus: rand() -> mt_rand() + removed deprecated comments. | Dries Buytaert | 2006-01-17 |
| | |||
* | - Patch #40755 by wtanaka: make the comment block themable. | Dries Buytaert | 2006-01-17 |
| | |||
* | - Critical feature #40670: made the form array accessible. | Dries Buytaert | 2006-01-17 |
| | |||
* | - Patch #44136 by riccardoR: can't enable more than one language. | Dries Buytaert | 2006-01-17 |
| | |||
* | - Patch #45107 by chx: minor code speedups. | Dries Buytaert | 2006-01-17 |
| | |||
* | - Patch #44381 by gerhard: improved consistency of API. Always pass an array. | Dries Buytaert | 2006-01-17 |
| | |||
* | - Patch #44754 by Zen: fixed "Who's new" block inaccuracy. | Dries Buytaert | 2006-01-17 |
| | |||
* | - #44992: ./ prefix for conf file include (faster) | Steven Wittens | 2006-01-17 |
| | |||
* | Code style | Steven Wittens | 2006-01-17 |
| | |||
* | - Patch #44976 by m3avrck: cleaned up some CSS. | Dries Buytaert | 2006-01-16 |
| | |||
* | - Patch #44964 by Eaton: remove comment moderation tables. | Dries Buytaert | 2006-01-16 |
| | |||
* | - Fix Safari alert when no autocomplete matches are returned. | Steven Wittens | 2006-01-16 |
| | |||
* | - Patch #9477 by Neil and Richard: fixed inconsistent behavior of ↵ | Dries Buytaert | 2006-01-16 |
| | | | | user-specified paths. | ||
* | - Patch #22035 by Matt: fixed problem with alias table getting corrupted. | Dries Buytaert | 2006-01-16 |
| | |||
* | - Patch #44286 by Neil, Zen, et al: a couple fixes to the upgrade path. | Dries Buytaert | 2006-01-15 |
| | |||
* | - Patch #39329 by markus: order sources in aggregator. | Dries Buytaert | 2006-01-15 |
| | |||
* | - Patch #44767 by jvandyk: small (code) improvements | Dries Buytaert | 2006-01-15 |
| | |||
* | - Patch #44771 by jvandyk: small performance improvement. | Dries Buytaert | 2006-01-15 |
| | |||
* | - #44772: {} -> [] (in anticipation of PHP de-deprecation) | Steven Wittens | 2006-01-15 |
| | |||
* | - #44498: Clean up pager / make more accessible | Steven Wittens | 2006-01-15 |
| | |||
* | - Patch #39135 by Zen: various contact form improvements/fixes. | Dries Buytaert | 2006-01-14 |
| | | | | | | | | | | | | + Conversion to _validate + _submit model.. + Split replaced by explode - faster + Fixed typos: Recipient + Fixed weight defaulting to -10 + Popped mail subject formatting into a t() + Popped '--' formatting into a t() + Does a lot of documentation fixing/rewriting. + Renamed contact_user_mail form functions to contact_mail_user for consistency. + ... | ||
* | - Patch #41594 by Richard: more improvements to primary/secondary links ↵ | Dries Buytaert | 2006-01-14 |
| | | | | upgrade path. | ||
* | - Extended the form description for clarity. | Dries Buytaert | 2006-01-14 |
| | |||
* | - Patch #44544 by Richard: made the help text slightly more accurate. | Dries Buytaert | 2006-01-14 |
| | |||
* | - Patch #44498 by m3vrck: improved HTML generated code for pagers. | Dries Buytaert | 2006-01-14 |
| |