Commit message (Collapse) | Author | Age | |
---|---|---|---|
* | - Patch #46106 by markus: usability improvement: moved the block description ↵ | Dries Buytaert | 2006-01-24 |
| | | | | textfield up. | ||
* | - Patch #45530 by Morbus: filter_form shouldn't default to #weight 0 | Dries Buytaert | 2006-01-20 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | When a form element doesn't specify a #weight, it is assumed internally as #weight 0. However, to ensure that our form elements display visually *as they were defined in the array* we, in form_builder, count the number of elements, divide by 1000, and set that as the weight: # Assign a decimal placeholder weight to preserve original array order if (!isset($form[$key]['#weight'])) { $form[$key]['#weight'] = $count/1000; } The above code will set the #weights of elements that have not defined a weight to something like 0 (first element in array definition), 0.001, 0.002, and so on. However, anytime a form element *explicitly* defines a #weight of 0, that #weight is kept at exactly 0, which would cause that form element to appear BEFORE the elements that didn't have a #weight defined (and thus received a #weight such as 0.002). Consider the following pseudo example: $form['game_title'] = array( '#type' => 'textfield', ... ); $form['game_description'] = array( '#type' => 'textarea', ... ); $form['game_format'] = filter_form(variable_get('game_format', NULL)); return $form; Here, we're not definiing weights on our two textfields. We then add an filter_form. The second parameter of the filter_form is $weight, which defaults to 0. After this $form hits form_builder, we have weights 0 (game_title), 0.001 (game_description), and 0 (filter_form) respectively. This is then sorted by weight, which causes filter_form (the third element in the array) to appear BEFORE game_description (0 is lighter than 0.001). The short lesson is: explicitly defining #weight 0 for a form element is probably a bad idea. This patch changes the default #weight of filter_form to NULL, instead of 0, and also removes any other explicit setting of #weight to 0 in core. | ||
* | - Patch #45349 by Morbus Iff: input filters aren't sorting correctly ↵ | Dries Buytaert | 2006-01-19 |
| | | | | infForms API. | ||
* | - Patch #44163 by m3avrck: fixed typo in permission and fixed incorrect ↵ | Dries Buytaert | 2006-01-12 |
| | | | | description. | ||
* | - #43495: Separate permission for PHP-based block visibility | Steven Wittens | 2006-01-08 |
| | |||
* | - Patch #35667 by Crell: bug fix: on ?q=admin/block style.css was imported ↵ | Dries Buytaert | 2006-01-06 |
| | | | | twice. | ||
* | - Patch #40631 by Chris Johnson: is_array() slower than isset() or empty(). | Dries Buytaert | 2005-12-14 |
| | |||
* | - Patch #39778 by chx: obliterate nodeapi op form in favor of the forms ↵ | Dries Buytaert | 2005-12-05 |
| | | | | API's way of doing things. Tested with help from webchick. | ||
* | - Patch #39576 by chx: rename '_execute' to '_submit' and '#execute' to ↵ | Dries Buytaert | 2005-12-02 |
| | | | | '#submit'. | ||
* | - Patch #37714 by asimmonds: fixed saving of blocks. | Dries Buytaert | 2005-11-16 |
| | |||
* | - Patch #35524 by asimmonds / drewish: converted the custom block forms code ↵ | Dries Buytaert | 2005-11-13 |
| | | | | to the forms API's execute model. | ||
* | - Patch #35644 by webchick: forms API simplificiations. | Dries Buytaert | 2005-11-12 |
| | |||
* | - Patch #36029 by asimmonds: fixed typo that prevents 'admin - block - ↵ | Dries Buytaert | 2005-11-03 |
| | | | | configure' from working. | ||
* | - Patch #26139 by webchick / Kieran / documentation team: improved admin ↵ | Dries Buytaert | 2005-11-01 |
| | | | | help of core modules! / | ||
* | - Patch #30930 by m3avrck/deekayen: cured PHP5 warnings. | Dries Buytaert | 2005-10-22 |
| | |||
* | - Patch #33752 by chx, adrian, et al: another batch of form API changes/fixes. | Dries Buytaert | 2005-10-11 |
| | |||
* | - Removing tabs and trailing whitespaces. | Dries Buytaert | 2005-10-07 |
| | |||
* | - Patch #29465: new form API by Adrian et al. | Dries Buytaert | 2005-10-07 |
| | | | | | | | TODO: + The contact.module was broken; a new patch for contact.module is needed. + Documentation is needed. + The most important modules need to be updated ASAP. | ||
* | - Patch #30801 by Allie Micka, m3avrck, 1uv4t4r et al: fixed block problems. | Dries Buytaert | 2005-09-14 |
| | |||
* | - Patch #30801 by Allie Micka and m3avrck: performance improvements: ↵ | Dries Buytaert | 2005-09-12 |
| | | | | improved the database scheme and queries of the block.module. | ||
* | - Patch #29385 by chx: no ?> add end of files. | Dries Buytaert | 2005-08-25 |
| | |||
* | - Patch #16216 by nedjo: multiple block regions! | Dries Buytaert | 2005-08-16 |
| | |||
* | - Patch #27713 by tostinni: fixed two problems on the block add page: | Dries Buytaert | 2005-08-07 |
| | | | | | + description field isn't marked as requiered +when the field isn't unique, an error is displayed, but the wrong text field is set as erronous. | ||
* | - #27551: Rename check_output() to check_markup(). Needs contrib updates! | Steven Wittens | 2005-07-29 |
| | |||
* | - Patch #26217 by HellRaider: fixed problem <front> setting in presence of ↵ | Dries Buytaert | 2005-07-20 |
| | | | | slashes. | ||
* | - Patch #26233 by Goba: fixed problem with block regions being buggy. | Dries Buytaert | 2005-07-03 |
| | |||
* | - Fixed problems with filter formats and problem with XML-RPC server. | Dries Buytaert | 2005-06-29 |
| | |||
* | - Patch #25603 by Stefan: made the sizes of forms consistent. | Dries Buytaert | 2005-06-27 |
| | | | | TODO: document the defaults in the PHPdoc comments. | ||
* | - Patch #22192 by tostinne: fixed invalid XHTML code | Dries Buytaert | 2005-05-22 |
| | |||
* | - Patch #15595 by Stefan and Djun: improved status messages. | Dries Buytaert | 2005-05-05 |
| | | | | | TODO: we should write down a couple guidelines for these document them in the PHPDoc code of drupal_set_message()! . | ||
* | - Patch #21939 by Usability Poobah Chris: added missing </p> tag. | Dries Buytaert | 2005-05-05 |
| | |||
* | - Patch #21445 by Goba: added missing t() function. | Dries Buytaert | 2005-05-01 |
| | |||
* | - Patch #21353 by chx: implemented PHP-mode for blocks. | Dries Buytaert | 2005-04-30 |
| | |||
* | - Patch 20910 by chx: centralize print theme page. | Dries Buytaert | 2005-04-24 |
| | |||
* | - Improved consistency. | Dries Buytaert | 2005-04-18 |
| | |||
* | - Patch #19965 by Robin Monks: fixed problem with duplicate block titles. | Dries Buytaert | 2005-04-12 |
| | |||
* | - Modified patch #19694 by chx: makes sure that block.module deals by ↵ | Dries Buytaert | 2005-04-04 |
| | | | | default only with regions 0 and 1 as it does now but lets you use block_list with any region you define. This opens many possibilites. You may do a multi region module, with your admin UI using the blocks table as storage and the block_list matcher. Or you may do a sections module using the block matcher without cluttering the current blocks list. | ||
* | - #18817: Clean up plain-text checking (see drupal-devel!) | Steven Wittens | 2005-03-31 |
| | |||
* | - #18939 (Stefan): Always use paragraph tags around page help text. | Steven Wittens | 2005-03-18 |
| | |||
* | - Renamed some more 'region's to 'sidebar's | Dries Buytaert | 2005-03-06 |
| | |||
* | - Patch by Neil: fixed typo. | Dries Buytaert | 2005-03-05 |
| | |||
* | - Patch #18382 by Neil: usability improvement: organized the blocks on the ↵ | Dries Buytaert | 2005-03-05 |
| | | | | block administration page by region. (I wanted to do that myself!) | ||
* | #18329: Unify confirmation messages (and make them themable) | Steven Wittens | 2005-03-03 |
| | |||
* | - Block admin usability: display block title if no description was given. | Steven Wittens | 2005-03-03 |
| | |||
* | - #17868: Remove hardcoded align="center" | Steven Wittens | 2005-02-27 |
| | |||
* | #17216: Restore missing "delete" link for blocks. | Steven Wittens | 2005-02-22 |
| | |||
* | - Patch #16399 by James: fixed typo in block.module. | Dries Buytaert | 2005-01-28 |
| | |||
* | Typos. | Steven Wittens | 2005-01-27 |
| | |||
* | - Code style | Steven Wittens | 2005-01-27 |
| | |||
* | - Patch #16074 by Andre Molnar: add configuration option to show blocks only ↵ | Dries Buytaert | 2005-01-27 |
| | | | | on pages of certain node type. |