Commit message (Collapse) | Author | Age | |
---|---|---|---|
* | #61802 by Zen, Double spaced sentences clean up | Neil Drumm | 2006-05-07 |
| | |||
* | #61696 by Zen, book module: Missing t() | Neil Drumm | 2006-05-04 |
| | |||
* | - Removing trailing whitespace. | Dries Buytaert | 2006-04-17 |
| | |||
* | #58539, removed duplicate menu item, patch by Markus Petrux | Gerhard Killesreiter | 2006-04-13 |
| | |||
* | #56105, remove title validation, already enforced by #required, patch by Moshe | Gerhard Killesreiter | 2006-03-27 |
| | |||
* | #53826, Book export: db_rewrite breaks sql query., patch by puregin | Gerhard Killesreiter | 2006-03-26 |
| | |||
* | #55493, Editing an existing book page kills Drupal, patch by chx | Gerhard Killesreiter | 2006-03-23 |
| | |||
* | #54565, cannot remove pages from book outline. Patch by Zen. | Gerhard Killesreiter | 2006-03-18 |
| | |||
* | #50987: book next link breaks with php 5.1 | Steven Wittens | 2006-03-14 |
| | |||
* | #53956: Don't allow moving away top-level book pages if you cannot move them ↵ | Steven Wittens | 2006-03-14 |
| | | | | back. | ||
* | #11206, Editing a top level book page inadvertently changes parent, patch by ↵ | Gerhard Killesreiter | 2006-03-14 |
| | | | | chx. | ||
* | - Patch #50821 by Zen/merlinofchaos: convert book.module to form API so the ↵ | Dries Buytaert | 2006-03-02 |
| | | | | forms can be altered/themed. | ||
* | - #47844: Book module doesn't delete table entry for nodes added to outline. | Steven Wittens | 2006-03-01 |
| | |||
* | - Patch #49912: www.drupal.org -> drupal.org. (Today's critical bugfix #5.) | Dries Buytaert | 2006-02-21 |
| | |||
* | - Patch #49131 by puregin: refine book permissions. | Dries Buytaert | 2006-02-14 |
| | |||
* | - Patch #47098 by JonBob: fixed book navigation divs when book has no child ↵ | Dries Buytaert | 2006-02-09 |
| | | | | pages. | ||
* | - Patch #47066 by Zen: removed dead code. | Dries Buytaert | 2006-02-01 |
| | |||
* | - Patch #46827 by wulff: fixed incorrect links. | Dries Buytaert | 2006-01-29 |
| | |||
* | - Patch #46400 by m3avrck: clean up book navigation markup + UI ↵ | Dries Buytaert | 2006-01-27 |
| | | | | improvements. (Hint: the forum module has previous and next links too.) | ||
* | - Patch #45706 by markus: keep up with CSS improvements. | Dries Buytaert | 2006-01-24 |
| | |||
* | - Patch #45706 by markus: keeping up with CSS improvements. | Dries Buytaert | 2006-01-22 |
| | |||
* | - Patch #45530 by Morbus: filter_form shouldn't default to #weight 0 | Dries Buytaert | 2006-01-20 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | When a form element doesn't specify a #weight, it is assumed internally as #weight 0. However, to ensure that our form elements display visually *as they were defined in the array* we, in form_builder, count the number of elements, divide by 1000, and set that as the weight: # Assign a decimal placeholder weight to preserve original array order if (!isset($form[$key]['#weight'])) { $form[$key]['#weight'] = $count/1000; } The above code will set the #weights of elements that have not defined a weight to something like 0 (first element in array definition), 0.001, 0.002, and so on. However, anytime a form element *explicitly* defines a #weight of 0, that #weight is kept at exactly 0, which would cause that form element to appear BEFORE the elements that didn't have a #weight defined (and thus received a #weight such as 0.002). Consider the following pseudo example: $form['game_title'] = array( '#type' => 'textfield', ... ); $form['game_description'] = array( '#type' => 'textarea', ... ); $form['game_format'] = filter_form(variable_get('game_format', NULL)); return $form; Here, we're not definiing weights on our two textfields. We then add an filter_form. The second parameter of the filter_form is $weight, which defaults to 0. After this $form hits form_builder, we have weights 0 (game_title), 0.001 (game_description), and 0 (filter_form) respectively. This is then sorted by weight, which causes filter_form (the third element in the array) to appear BEFORE game_description (0 is lighter than 0.001). The short lesson is: explicitly defining #weight 0 for a form element is probably a bad idea. This patch changes the default #weight of filter_form to NULL, instead of 0, and also removes any other explicit setting of #weight to 0 in core. | ||
* | - Patch #45349 by Morbus Iff: input filters aren't sorting correctly ↵ | Dries Buytaert | 2006-01-19 |
| | | | | infForms API. | ||
* | - Patch #45301 by Morbus: corrected the weight of form item titles of nodes. | Dries Buytaert | 2006-01-18 |
| | |||
* | - Patch 42591 by Simon/me: fixed problem with deleting forum and book revisions. | Dries Buytaert | 2005-12-31 |
| | |||
* | - Patch #34920 by Morbus/webchick/tangent: fixed order of form fields. | Dries Buytaert | 2005-12-15 |
| | |||
* | - Patch #31323 by Gerhard: delete extra data when a revision is deleted. | Dries Buytaert | 2005-12-05 |
| | |||
* | - Patch #39778 by chx: obliterate nodeapi op form in favor of the forms ↵ | Dries Buytaert | 2005-12-05 |
| | | | | API's way of doing things. Tested with help from webchick. | ||
* | - Patch #39576 by chx: rename '_execute' to '_submit' and '#execute' to ↵ | Dries Buytaert | 2005-12-02 |
| | | | | '#submit'. | ||
* | - Patch #1482 by djun: we're moving the DocBook output to a contributed ↵ | Dries Buytaert | 2005-11-30 |
| | | | | module. It's not a core feature. | ||
* | - Patch #38296 by Tobias Maier: fixed bug with book links. | Dries Buytaert | 2005-11-24 |
| | |||
* | - Patch #35644 by webchick: fixed the sizes of the textareas on the node ↵ | Dries Buytaert | 2005-11-23 |
| | | | | edit forms. | ||
* | - Patch #38611 by Neil: redo book administration. | Dries Buytaert | 2005-11-23 |
| | | | | The book module's current administration is actually a patchwork of one form per book page crammed into a table with another form at the bottom. This simply didn't work. | ||
* | - Patch #38296 by Ber: generate rel-tags for book pages. Makes it easier to ↵ | Dries Buytaert | 2005-11-22 |
| | | | | browse in some browsers. | ||
* | - Patch #35644 by webchick: forms API simplificiations. | Dries Buytaert | 2005-11-12 |
| | |||
* | #36791: node_validate was called twice | Steven Wittens | 2005-11-12 |
| | |||
* | - Patch #26139 by webchick / Kieran / documentation team: improved admin ↵ | Dries Buytaert | 2005-11-01 |
| | | | | help of core modules! / | ||
* | - Patch #34920 by tangent: reorganized the node submission form a bit. | Dries Buytaert | 2005-10-28 |
| | |||
* | - Patch #34932 by tangent: fixed the placement of the 'log'-textarea on book ↵ | Dries Buytaert | 2005-10-24 |
| | | | | preview pages. | ||
* | - Patch #33220 by Tobias: improved themeability of book module. | Dries Buytaert | 2005-10-23 |
| | |||
* | - Patch #33752 by chx, adrian, et al: another batch of form API changes/fixes. | Dries Buytaert | 2005-10-11 |
| | |||
* | - Patch #27999 by Tobias: made book export functionality configurable. | Dries Buytaert | 2005-10-08 |
| | |||
* | - Removing tabs and trailing whitespaces. | Dries Buytaert | 2005-10-07 |
| | |||
* | - Patch #29465: new form API by Adrian et al. | Dries Buytaert | 2005-10-07 |
| | | | | | | | TODO: + The contact.module was broken; a new patch for contact.module is needed. + Documentation is needed. + The most important modules need to be updated ASAP. | ||
* | Improved error-handling of book module. | Dries Buytaert | 2005-10-06 |
| | |||
* | - Patch #32584 by Gerhard: removed reference to node_revision_load() and fixed | Dries Buytaert | 2005-09-29 |
| | | | | input validation error.. | ||
* | - Patch #10056: allow the node title forms to be customized. | Dries Buytaert | 2005-09-23 |
| | |||
* | - Patch #31496 by Goba: added missing $node object in book export. | Dries Buytaert | 2005-09-18 |
| | |||
* | - Patch #30308 by gordon: fixed broken SQL query. | Dries Buytaert | 2005-09-06 |
| | |||
* | - Patch #7582 by Gerhard: improved node revisions! | Dries Buytaert | 2005-08-30 |
| | | | | | | | | | | All node revisions were stored in a serialized field in the node table and retrieved for _each_ page view although they are rarely needed. We created a separate revisions table which would be in principle identical to the node table, only that it could have several old copies of the same node. This also allows us to revision-related information, and to provide log entries to non-book pages when a new revision is being created. TODO: 1. Provide upgrade instructions for node module maintainers! 2. Upgrade modules that implement node types. 3. Provide an upgarde path for revisions. Dependency on the upgrade system. |