summaryrefslogtreecommitdiff
path: root/modules/comment.module
Commit message (Collapse)AuthorAge
* - Patch #40752 by moshe/wtanaka: login and regsiter links on each comment ↵Dries Buytaert2006-01-26
| | | | don't redirect back to the topic.
* - Patch #40753 by wtanaka/killes: #comment-form has disappeared from ↵Dries Buytaert2006-01-25
| | | | comment.module
* - Patch #44101 by Cvbge: deleting a comment creates incorrect entry in ↵Dries Buytaert2006-01-22
| | | | node_comment_statistics.
* - Patch #45380 by Neil: usability improvement: disable anonymous commenting ↵Dries Buytaert2006-01-20
| | | | options when anonymous people can't comment.
* - Patch #45530 by Morbus: filter_form shouldn't default to #weight 0Dries Buytaert2006-01-20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | When a form element doesn't specify a #weight, it is assumed internally as #weight 0. However, to ensure that our form elements display visually *as they were defined in the array* we, in form_builder, count the number of elements, divide by 1000, and set that as the weight: # Assign a decimal placeholder weight to preserve original array order if (!isset($form[$key]['#weight'])) { $form[$key]['#weight'] = $count/1000; } The above code will set the #weights of elements that have not defined a weight to something like 0 (first element in array definition), 0.001, 0.002, and so on. However, anytime a form element *explicitly* defines a #weight of 0, that #weight is kept at exactly 0, which would cause that form element to appear BEFORE the elements that didn't have a #weight defined (and thus received a #weight such as 0.002). Consider the following pseudo example: $form['game_title'] = array( '#type' => 'textfield', ... ); $form['game_description'] = array( '#type' => 'textarea', ... ); $form['game_format'] = filter_form(variable_get('game_format', NULL)); return $form; Here, we're not definiing weights on our two textfields. We then add an filter_form. The second parameter of the filter_form is $weight, which defaults to 0. After this $form hits form_builder, we have weights 0 (game_title), 0.001 (game_description), and 0 (filter_form) respectively. This is then sorted by weight, which causes filter_form (the third element in the array) to appear BEFORE game_description (0 is lighter than 0.001). The short lesson is: explicitly defining #weight 0 for a form element is probably a bad idea. This patch changes the default #weight of filter_form to NULL, instead of 0, and also removes any other explicit setting of #weight to 0 in core.
* - Patch #45349 by Morbus Iff: input filters aren't sorting correctly ↵Dries Buytaert2006-01-19
| | | | infForms API.
* - Patch #43325 by chx/drumm/merlinofchaos: critical bugfix: made editing ↵Dries Buytaert2006-01-18
| | | | comments work.
* - Patch #40755 by wtanaka: make the comment block themable.Dries Buytaert2006-01-17
|
* - Removed reference to comment moderation.Dries Buytaert2006-01-10
|
* - #43097: restore admin/comment tablesortSteven Wittens2006-01-08
|
* - Comment bug: anchor links should be specified using $fragment in url() and ↵Steven Wittens2006-01-06
| | | | drupal_goto().
* - Patch #40563 by chx, merlingofchaos, et al: bug fix: fixed the default ↵Dries Buytaert2006-01-05
| | | | comment settings on node sumbission forms.
* - Patch #39743 by merlinofchaos: critical bugfix: fixed comment ordering ↵Dries Buytaert2006-01-05
| | | | setting.
* - Patch #42971 by markus_petrux: input format not correctly shown when ↵Dries Buytaert2006-01-03
| | | | editing a comment.
* - Patch 41169 by Chris: got rid of expensvie object 2 array casts.Dries Buytaert2005-12-31
|
* - Patch #38999 by saerdna: There's no need that users with the "administer ↵Dries Buytaert2005-12-19
| | | | comments" role has to go via admin/comments to delete comments. this patch simply adds the delete link on each comment if you have administer comments role. "access administration pages" not needed; because if they not have it they can still delete from admin/comments.
* - Patch #41081 by billturner: fixed problem with the comment settings form.Dries Buytaert2005-12-15
|
* - Patch #34920 by Morbus/webchick/tangent: fixed order of form fields.Dries Buytaert2005-12-15
|
* - Patch #41133 by DriesK: as of PHP 5.1.0, strtotime() returns FALSE on ↵Dries Buytaert2005-12-15
| | | | | | failure instead of -1. Changed code to be compatible with all versions.
* - Patch #40631 by Chris Johnson: is_array() slower than isset() or empty().Dries Buytaert2005-12-14
|
* - Patch #28595 by Cvbge: fixed problems with bulk comment operations.Dries Buytaert2005-12-08
|
* - Patch #28595 by Jeremy: added support for bulk operations on comments.Dries Buytaert2005-12-07
|
* - Patch #39778 by chx: obliterate nodeapi op form in favor of the forms ↵Dries Buytaert2005-12-05
| | | | API's way of doing things. Tested with help from webchick.
* - Patch #36434 by assimonds: fixed problem with editing signatures.Dries Buytaert2005-12-03
|
* - Patch #39576 by chx: rename '_execute' to '_submit' and '#execute' to ↵Dries Buytaert2005-12-02
| | | | '#submit'.
* - Patch #39024 by Zen: comments that should be in the moderation queue get ↵Dries Buytaert2005-11-27
| | | | published.
* - Patch #37798 by Neil: fixed problem with node settings.Dries Buytaert2005-11-27
|
* - Patch #39013 by drumm: more logical naming of themeable functionsDries Buytaert2005-11-27
|
* - Patch #37798 by Neil: allow non-workflow form elements on the node type ↵Dries Buytaert2005-11-25
| | | | settings page.
* - Patch #38575 by Neil: fixed infinite loop in comment.module.Dries Buytaert2005-11-23
|
* - Patch #38491 by Neil: refactor comment viewing controls to _execute model.Dries Buytaert2005-11-22
|
* - Patch #35726 by asimmonds: post_process -> build_afterDries Buytaert2005-11-22
|
* - Patch #35726 by asimmonds/chx: converted the comment module to the forms ↵Dries Buytaert2005-11-21
| | | | API's _execute model.
* - Patch #34295 by assimonds: added missing defines to comment.module. ImprovesDries Buytaert2005-11-15
| | | | readability of the code.
* - Patch #34295 by DrupalJapan and chx:Dries Buytaert2005-11-13
| | | | | + Fixed problem with configuration of comment display options. + Introduced defines for the various comment settings.
* - Add missing url()s around form actions (these would break without clean URLs)Steven Wittens2005-11-13
|
* - Patch #35644 by webchick: forms API simplificiations.Dries Buytaert2005-11-12
|
* - Patch #36727 by Goba: fixed incorrect use of drupal_goto().Dries Buytaert2005-11-08
|
* - Patch #26139 by webchick / Kieran / documentation team: improved admin ↵Dries Buytaert2005-11-01
| | | | help of core modules! /
* - #34645: Make $links in theme_comment consistent with theme_node (Stefan)Steven Wittens2005-10-20
|
* - TypoSteven Wittens2005-10-20
|
* - Code styleSteven Wittens2005-10-20
|
* - Patch #33752 by chx, adrian, et al: another batch of form API changes/fixes.Dries Buytaert2005-10-11
|
* - Patch #33433 by chx: fixed a number of form API problems.Dries Buytaert2005-10-08
| | | | | | | | | | | * Default form value * Leftover debug function in form.inc * PHP5 issue with comment date (I got this patch from another issue) * Validation error fix (was calling legacy form validate) * Lots o' warnings on comment preview * Filter tips plus argument (gremlins. I swear this was not there.) * Message to clear what's going on with system settings * Non-freetagging taxonomies fixed
* - Patch #29465: new form API by Adrian et al.Dries Buytaert2005-10-07
| | | | | | | TODO: + The contact.module was broken; a new patch for contact.module is needed. + Documentation is needed. + The most important modules need to be updated ASAP.
* - Patch by chx: fixed validation check.Dries Buytaert2005-10-01
|
* - Add some extra options.Dries Buytaert2005-09-29
|
* - Patch #26031 by leafish_dylan: fixed comment pager (broken SQL query).Dries Buytaert2005-09-27
|
* - Patch #28786 by Neil: moved pagers out of table.Dries Buytaert2005-09-27
|
* - Patch #28786 by Neil: move pagers out of table.Dries Buytaert2005-09-24
|
generated by cgit v1.2.3 (git 2.25.1) at 2025-07-19 23:18:50 +0000