summaryrefslogtreecommitdiff
path: root/modules/comment.module
Commit message (Collapse)AuthorAge
* - Partial patch #9643 by Bart:Dries Buytaert2004-08-03
| | | | | + the confirmation before deleting a comment was missing a check_output. + after editing a comment, two pages were shown (two calls to theme('page',..)), replaced this by a drupal_goto.
* - Fixed broken link + removed redundant form descriptions (there is no pointDries Buytaert2004-08-01
| | | | in repeating the title).
* - Patch #7466 by TDobes: comments module would add a link of register even ↵Dries Buytaert2004-07-14
| | | | if "user_register" was set to 0.
* - Patch #9253 by Morbus: fixed bug that manifested itself with a duplicate ↵Dries Buytaert2004-07-13
| | | | page when a user has submitted a comment that goes into the moderation queue. Part of the problem seemed to be that the "your comment is in the moderation queue" message was set as a theme print, as opposed to a drupal_set_message(). This patch fixes that, as well as adding a drupal_goto() to redirect the user back to where they came.
* - Patch by JonBob: updated the comment module to take advantage of the latestDries Buytaert2004-07-10
| | | | menu system improvements.
* - Patch 8756 by Morbus:Dries Buytaert2004-07-10
| | | | | | | | | | | | | | | | | | | | | | * improves the doxygentation and help text. * deletes comment_admin and comment_page; using proper callbacks instead. * related/modified callbacks/menus/functions were tweaked to not use arg() at all. * the "settings" subtab was weighted to -10 so it'd appear first (in prep of JonBob's local default). * moderation pages weren't properly showing defined votes or thresholds; fixed. * when moderation votes or thresholds didn't exist, no error stating as such was shown; fixed. * we show "submit votes" on the moderation votes page only when votes actually exist. * fixes the (broken in CVS) comment/reply and comment/edit features. * fixes the (broken in CVS) "save settings" for comment view options and comment moderation. In addition I: * fixed a couple warnings introduced by Morbus' patch. * fixed a couple translation bugs. * fixed comment_node_url(). I also found that: * the collapsed comment views (i.e. 'threaded list - collapsed) are broken.
* - Patch #9010 by Morbus: reorganized the order of functions in the commentDries Buytaert2004-07-08
| | | | module.
* - Marked required fields on the node (story, book, page, blog) and commentDries Buytaert2004-07-08
| | | | | | | | | forms using the $required argument of the form_ functions. - Replaced all Optional's and Required's from the taxonomy forms with proper use of the form_ functions. Please check your contributed modules too!
* - Moving the title.module from core to contrib as discussed on the mailing list.Dries Buytaert2004-07-07
|
* - Patch #9046 by asimmonds: comment signature option was not displayed.Dries Buytaert2004-07-05
|
* - Patch by Steven and me: refactored the form handling of nodes. The node ↵Dries Buytaert2004-07-04
| | | | | | | | system is now using form_set_error() and friends like the rest of Drupal does. This makes for both a consistent user experience and consistent code. It simplifies the forms and validation code, however, it does change the node API slightly: * The _validate hook and the _nodeapi('validate') hook of the node API (1) no longer take an 'error' parameter and (2) should no longer return an error array. To set an error, call form_set_error(). * The _form hook of the node module no longer takes a form hook and should not worry about displaying errors. Ditto for _nodeapi('form_post') and _nodeapi('form_pre').
* - Patch #8757 by Morbus Iff: fixed redirection after comment moderation.Dries Buytaert2004-06-23
|
* - Patch #8681 by asimmonds: more help text updatesDries Buytaert2004-06-21
|
* - Patch #8681 by Stefan: more help fixes.Dries Buytaert2004-06-20
|
* - Patch #8670 by asimmonds: spelling fixes.Dries Buytaert2004-06-20
|
* - Patch #8679 by asimmonds: fixed spelling mistakes.Dries Buytaert2004-06-20
|
* First tab improvements by Adrian:Dries Buytaert2004-06-19
| | | | | | | | + Changed menu.inc to generate two separate lists instead of nested lists: that seems to be the only alternative to get rid of absolute positioning. + Changed the tabs code to be more sexy and put the code in misc/drupal.css so all themes are automagically updated.
* Tabs patch!Dries Buytaert2004-06-18
| | | | | | | | | | | | | | | | | | CHANGES ------- + Introduced tabs. First, we extended the menu system to support tabs. Next, a tab was added for every link that was (1) an administrative action other than the implicit 'view' (2) relevant to that particular page only. This is illustrated by the fact that all tabs are verbs and that clicking a page's tab leads you to a subpage of that page. + Flattened the administration menu. The tabs helped simplify the navigation menu as I could separate 'actions' from 'navigation'. In addition, I removed the 'administer > configuration'-menu, renamed 'blocks' to 'sidebars' which I hope is a bit more descriptive, and made a couple more changes. Earlier, we already renamed 'taxonomy' to 'categorization' and we move 'statistics' under 'logs'. + Grouped settings. All settings have been grouped under 'administer > settings'. TODO ---- + Update core themes: only Xtemplate default supports tabs and even those look ugly. Need help. + Update contributed modules. The menu() hook changed drastically. Updating your code adhere the new menu() function should be 90% of the work. Moreover, ensure that your modue's admin links are still valid and that URLs to node get updated to the new scheme ('node/view/x' -> 'node/x').
* - Patch #8553 by Moshe: hide the 'add new comment' link when showing theDries Buytaert2004-06-17
| | | | comment form.
* - Commiting patch #7577: comment.module clean up.Kjartan Mannes2004-06-04
|
* - Patch #4950 by Stefan (and Morbus): made watchdog messages translatable.Dries Buytaert2004-06-02
|
* - Patches #6863 by Kristjan and Moshe: implemented pretty tables and fixed ↵Dries Buytaert2004-06-02
| | | | some tablesort glitches.
* - Patch #7350 by Mathias: return part a taxonomy tree to a user-definedDries Buytaert2004-05-31
| | | | | | depth/level. - Updated CHANGELOG.txt.
* - Reworked comment submission. It is less broken now.Dries Buytaert2004-05-31
|
* - Improved form handling.Dries Buytaert2004-05-31
| | | | | | | | | | | | | | | | | | | | | + Introduced two new functions: 1. form_set_error($name, $message): files an error against the form element with the specified $name. 2. form_has_errors(): returns true if errors has been filed against form elements. + Updated the form handling: 1. The form_ functions will add 'class="error"' when a form field has been found to be erroneous. 2. The error message is passed to theme_form_element() when the particular form field has been found to be erroneous. + I updated the user and profile module to take advantage of these new functions. + IMPORTANT: the _user() hook changed. The 'validate' case should no longer retun an error message when something goes wrong but should set it with form_set_error().
* - Patch 7444 (#35) by Pablo. This patch addresses some issues with showingDries Buytaert2004-05-24
| | | | | | anonymous usernames in comments. It does not solve all my problems, but others claim it works as advertised. I'm committing this because it does fix some pending issues (even though that might not be the end of it).
* - Simplified the 'anonymous poster settings' of the comment module andDries Buytaert2004-05-20
| | | | | | | | | | | | | | | | | | | | | made it possible to enforce a username/e-mail address. Based on James Seng's work there are now 3 radio buttons: ( ) Anonymous users may not enter contact information ( ) Anonymous users may leave contact information ( ) Anonymous users must leave contact information - Fixed a bug in the default theme_comment_view() function. - Added permalinks for comments. Requested by Michael and Christina. Maintainers of contributed themes might want to add permalinks too. TODO: - Fix the interaction design of the submission form: the page you are directed to and the validation of the contact information. - Changing the comment viewing options appears to be broken?
* - Made it possible for anonymous users to leave their name, e-mail addressDries Buytaert2004-05-18
| | | | and the URL of their homepage. Patch by Pablo.
* - Patch #7638 by nereocystis: fixed PostgreSQL (ANSI SQL) compatibility bug ↵Dries Buytaert2004-05-10
| | | | in the comment module.
* - Added support for multiple user roles. Patch by Jim Hriggs.Dries Buytaert2004-05-10
|
* - Patch #7504 by bylund: multiple form_radio-function calls is used insteadDries Buytaert2004-05-03
| | | | | of a single form_radios-call. This could cause problems when trying to style individual form elements.
* - Bug #7135: fixed saving of comment viewing options in PostgreSQL. Patch ↵Dries Buytaert2004-05-01
| | | | by Adrian.
* - Patch #7482 by Gerhard: double 'edit' in comment_user(). One 'edit' had ↵Dries Buytaert2004-05-01
| | | | to be 'validate'.
* - Added support for 403 handling. Patch by JonBob. As a side benefit,Dries Buytaert2004-04-21
| | | | | | | | administrators will be able to define a custom 403 page, just as they can define 404 pages now. This needs to be documented in the "Changes since / migrating to ..." pages.
* - Fixed problem with global session variable that caused the wrong page toDries Buytaert2004-04-18
| | | | be rendered after posting a comment.
* - Patch by JonBob/Jonathan: reworked the menu system so that menus areDries Buytaert2004-04-15
| | | | | | | | | | | | configurable! Menu items can be disabled, repositioned, added and so on. Upgrading to requires you to run update.php. This functionality depricates some of the 'navigation modules' in the contributions repository. Furthermore, modules can now 'suggest' menu items and site adminstrators can choose to enable them. Modules in the contributions repository should try to take advantage of this.
* Truncate UTF-8 patch. Introduced a new function truncate_utf8() for chopping ↵Steven Wittens2004-04-15
| | | | off strings at unsure locations, without risking incomplete UTF-8 data.
* - More profile module improvements:Dries Buytaert2004-03-21
| | | | | | | | | | | + Updated the _user() hook's "$type == 'view'" case to match the "$type == 'edit'" case. That is, both have to return an associtive array of the format array('category' => 'fields'). + Updated the profile pages to group fields by category. Made possible thanks to the above change. + Moved logic out of the theme_ functions.
* - Partial patch #6375 by jik: it's -> itsDries Buytaert2004-03-20
|
* - Partial patch #6375 by jik: fixed broken URL in comment help.Dries Buytaert2004-03-20
|
* - Bug #6595: made the signature's textarea less wideDries Buytaert2004-03-20
|
* Patch #5588 by bylund: XHTML improvements: <i> -> <em> and <b> -> <strong>.Dries Buytaert2004-03-20
|
* - Bugfix: mark new comments when show as 'folded'Dries Buytaert2004-03-12
|
* - Rewrote the profile module:Dries Buytaert2004-03-11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | + Added a 'created' field to the users table and renamed the 'timestamp' fied to 'changed' (cfr. node table). Update.php will try to determine a 'created' timestamp for existing users. + The profile module no longer uses serialized data but has its own set of tables. Known existing profile data is migrated by these new tables. TODO: migrate the birthday field. + The profile fields can be grouped, and within each group, profile fields can be sorted using weights. + The profile pages can be themed. + The profiles can be browsed based on certain properties/settings. + Change the _user hook: (i) 'private_view' and 'public_view' are merged into 'view' as there are no private fields and (ii) 'edit_form' has been renamed to 'edit'. + Avatar handling has been refactored and is now part of the user module. The users table has a dedicted 'picture' field. + Simplified the way themes should use display/visualize pictures or avatars. + Made it possible for administrators to replace or delete avatars. + ... I hope this make for a good base to build on collectively.
* - Removed broken throttle.Dries Buytaert2004-03-01
|
* - Patch #6129 by Goba: fixed dependencies on search module.Dries Buytaert2004-02-29
|
* - Patch by Steven: removed redundant permission checks. These are no longerDries Buytaert2004-02-15
| | | | required thanks to the new 404 handling.
* - Patch #4861 by Moshe/TDobes: made the comment module use the _link hook.Dries Buytaert2004-02-15
|
* - Patch 5592 by Goba: introduced a new function, drupal_map_assoc().Dries Buytaert2004-02-12
|
* - Patch 4902 by Goba:Dries Buytaert2004-02-11
| | | | | | | | | | | | | + only adds an optional parameter to url() and l(), so individual links can be set to be absolute + modifies drupal_goto() to accept the parameters of url() without the $absolute parameter, so cleaner invocations can be used + rework of some code in node_feed, making it much better to look at (the current code uses foreach with an immediate brake to get the first key of the associative array, geeeeez) + added xml:base to the rss tag generated by node_feed() + set all user mail URLs to be absolute + fix a small fragmented URL in user.module