Commit message (Collapse) | Author | Age | |
---|---|---|---|
* | - Patch #72284 by me: | Dries Buytaert | 2006-07-10 |
| | | | | | + reorganized ?q=admin/settings + deprecated the _settings hook | ||
* | #72865 by AjK, use more standard is_numeric() instead of ctype_digit(). | Neil Drumm | 2006-07-10 |
| | |||
* | #71925 by Steven, remove # prefix from link array keys. | Neil Drumm | 2006-07-04 |
| | |||
* | #63990 by Heine and chx, allow commenting on nodes containing forms | Neil Drumm | 2006-07-02 |
| | |||
* | #67745 by AjK, handle deleting non-existant comments better. | Neil Drumm | 2006-07-02 |
| | |||
* | #51556 by greggles, Fixing an inaccurate comment. | Neil Drumm | 2006-05-20 |
| | |||
* | - Patch #18260 by Ber, m3averck et al: allow overriding of links returned by ↵ | Dries Buytaert | 2006-05-18 |
| | | | | modules | ||
* | #61802 by Zen, Double spaced sentences clean up | Neil Drumm | 2006-05-07 |
| | |||
* | #61678 by Zen, Comment body validation should rely on fapi | Neil Drumm | 2006-05-04 |
| | |||
* | #58953: Flat collapsed mode and newest first order broken | Steven Wittens | 2006-04-27 |
| | |||
* | - Patch #58953 by tenrapid: critical bugfix: Flat Collapsed mode and Newest ↵ | Dries Buytaert | 2006-04-24 |
| | | | | First order broken. | ||
* | #58221, Turn #after_build into a functions array in order to make validation ↵ | Gerhard Killesreiter | 2006-04-20 |
| | | | | | | of date fields possible. Patch by yched, tenrapid Also makes forms API more consistent (see #pre_render) | ||
* | - Patch #58921 by markus_petrux: critical bug: database error when rendering ↵ | Dries Buytaert | 2006-04-17 |
| | | | | | | comments in PostgreSQL. Tested with MySQL only! | ||
* | #51002: Admins could not see unpublished comments (plus minor usability ↵ | Steven Wittens | 2006-04-15 |
| | | | | enhancements for previewing/unpublished) | ||
* | #5371, drupal_get_destination, pager and tablesort array handling, patch by ↵ | Gerhard Killesreiter | 2006-04-13 |
| | | | | Steven | ||
* | #58166, fixes for typos, patch by Uwe Herrmann | Gerhard Killesreiter | 2006-04-11 |
| | |||
* | #56942: Comment cids should belong to the associated nid | Steven Wittens | 2006-04-04 |
| | |||
* | #57133: admin/comment needs to remember sort order in page | Steven Wittens | 2006-04-04 |
| | |||
* | #56346: XHTML validation error due to comment.module links | Steven Wittens | 2006-03-30 |
| | |||
* | #34132, remove remnants of nodeapi('fields'), patch by myself | Gerhard Killesreiter | 2006-03-28 |
| | |||
* | - #55666: Comment reply form anchor fixes | Steven Wittens | 2006-03-27 |
| | |||
* | #53348, Handling of deleted/blocked user accounts, patch by jreyero and Zen | Gerhard Killesreiter | 2006-03-26 |
| | |||
* | #55622, Security threat -- any user can delete comments, patch by ↵ | Gerhard Killesreiter | 2006-03-24 |
| | | | | robertgarrigos | ||
* | #54687, Typo with page redirection upon login, patch by matt westgate | Gerhard Killesreiter | 2006-03-20 |
| | |||
* | - Patch #51142 by markus: hook_comment not called for all update operations. | Dries Buytaert | 2006-03-06 |
| | |||
* | - Patch #51543 by wtanaka: clicking on 'add new comment' takes you to the ↵ | Dries Buytaert | 2006-03-06 |
| | | | | wrong place. | ||
* | - Patch #50835 by markus: print message when replying to non-existing comment. | Dries Buytaert | 2006-03-04 |
| | |||
* | #50771, Wrong user name in admin/comment, patach by Markus Petrux | Gerhard Killesreiter | 2006-02-27 |
| | |||
* | - Patch #51347 by eafarris: fixed typo: coment -> comment. | Dries Buytaert | 2006-02-26 |
| | |||
* | - Patch #46690 by Zen: 'user comments' -> 'comment settings'. | Dries Buytaert | 2006-02-26 |
| | |||
* | - Patch #50755 by markus: = -> ==. | Dries Buytaert | 2006-02-22 |
| | |||
* | - Patch #47699 by wtanaka: performance improvement. | Dries Buytaert | 2006-02-22 |
| | |||
* | - Patch #49912: www.drupal.org -> drupal.org. (Today's critical bugfix #5.) | Dries Buytaert | 2006-02-21 |
| | |||
* | - Patch #43572 by Tobias: don't accept spaces. | Dries Buytaert | 2006-02-14 |
| | |||
* | - Patch #48622 by adrian: remove drupal_goto from _submit functions. | Dries Buytaert | 2006-02-10 |
| | |||
* | - #48518: Editing own comment broken under postgresl | Steven Wittens | 2006-02-09 |
| | |||
* | - #48239: Comment thread coding inefficient | Steven Wittens | 2006-02-09 |
| | |||
* | - Patch #47705 by DriesK: comment moderation/approval wasn't working due to ↵ | Dries Buytaert | 2006-02-04 |
| | | | | a bug with its forms. | ||
* | - Patch #47045 by Cvbge: fixed problem with deleting comments. | Dries Buytaert | 2006-02-01 |
| | |||
* | - Modified patch #46227 by chx: comment token is broken. | Dries Buytaert | 2006-01-31 |
| | |||
* | - Modified patch #45723 by wtanaka: creating a comment, editing a comment, ↵ | Dries Buytaert | 2006-01-26 |
| | | | | or anything that validates a comment fails on PHP5. | ||
* | - Patch #40752 by moshe/wtanaka: login and regsiter links on each comment ↵ | Dries Buytaert | 2006-01-26 |
| | | | | don't redirect back to the topic. | ||
* | - Patch #40753 by wtanaka/killes: #comment-form has disappeared from ↵ | Dries Buytaert | 2006-01-25 |
| | | | | comment.module | ||
* | - Patch #44101 by Cvbge: deleting a comment creates incorrect entry in ↵ | Dries Buytaert | 2006-01-22 |
| | | | | node_comment_statistics. | ||
* | - Patch #45380 by Neil: usability improvement: disable anonymous commenting ↵ | Dries Buytaert | 2006-01-20 |
| | | | | options when anonymous people can't comment. | ||
* | - Patch #45530 by Morbus: filter_form shouldn't default to #weight 0 | Dries Buytaert | 2006-01-20 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | When a form element doesn't specify a #weight, it is assumed internally as #weight 0. However, to ensure that our form elements display visually *as they were defined in the array* we, in form_builder, count the number of elements, divide by 1000, and set that as the weight: # Assign a decimal placeholder weight to preserve original array order if (!isset($form[$key]['#weight'])) { $form[$key]['#weight'] = $count/1000; } The above code will set the #weights of elements that have not defined a weight to something like 0 (first element in array definition), 0.001, 0.002, and so on. However, anytime a form element *explicitly* defines a #weight of 0, that #weight is kept at exactly 0, which would cause that form element to appear BEFORE the elements that didn't have a #weight defined (and thus received a #weight such as 0.002). Consider the following pseudo example: $form['game_title'] = array( '#type' => 'textfield', ... ); $form['game_description'] = array( '#type' => 'textarea', ... ); $form['game_format'] = filter_form(variable_get('game_format', NULL)); return $form; Here, we're not definiing weights on our two textfields. We then add an filter_form. The second parameter of the filter_form is $weight, which defaults to 0. After this $form hits form_builder, we have weights 0 (game_title), 0.001 (game_description), and 0 (filter_form) respectively. This is then sorted by weight, which causes filter_form (the third element in the array) to appear BEFORE game_description (0 is lighter than 0.001). The short lesson is: explicitly defining #weight 0 for a form element is probably a bad idea. This patch changes the default #weight of filter_form to NULL, instead of 0, and also removes any other explicit setting of #weight to 0 in core. | ||
* | - Patch #45349 by Morbus Iff: input filters aren't sorting correctly ↵ | Dries Buytaert | 2006-01-19 |
| | | | | infForms API. | ||
* | - Patch #43325 by chx/drumm/merlinofchaos: critical bugfix: made editing ↵ | Dries Buytaert | 2006-01-18 |
| | | | | comments work. | ||
* | - Patch #40755 by wtanaka: make the comment block themable. | Dries Buytaert | 2006-01-17 |
| | |||
* | - Removed reference to comment moderation. | Dries Buytaert | 2006-01-10 |
| |