summaryrefslogtreecommitdiff
path: root/modules/profile.module
Commit message (Collapse)AuthorAge
* - Patch #9478 by JonBob: allow printf-style arguments in pager_query.Dries Buytaert2004-07-25
| | | | | | Currently pager_query() is the black sheep of the database query family, because it does not allow for printf-style arguments to be inserted in the query. This is a problem because it introduces developer confusion when moving from an unpaged query to a paged one, and it encourages substitution of variables directly into the query, which can bypass our check_query() security feature. This patch adds this ability to pager_query(). The change is backwards-compatible, but a couple calls to the function in core have been changed to use the new capability.
* - More tab-improvements by JonBob: improved support for the default tabs!Dries Buytaert2004-07-10
|
* - Usability improvement: users can also separate 'list items' (i.e. favoriteDries Buytaert2004-07-08
| | | | | movies) using a comma. Only few users actually read the form description, it seems ...
* - Patch by Steven and me: refactored the form handling of nodes. The node ↵Dries Buytaert2004-07-04
| | | | | | | | system is now using form_set_error() and friends like the rest of Drupal does. This makes for both a consistent user experience and consistent code. It simplifies the forms and validation code, however, it does change the node API slightly: * The _validate hook and the _nodeapi('validate') hook of the node API (1) no longer take an 'error' parameter and (2) should no longer return an error array. To set an error, call form_set_error(). * The _form hook of the node module no longer takes a form hook and should not worry about displaying errors. Ditto for _nodeapi('form_post') and _nodeapi('form_pre').
* Using drupal_specialchars() instead of htmlentities(). htmlentities() is not ↵Steven Wittens2004-06-27
| | | | UTF-8 safe.
* I refactored quite a bit of the user.module:Dries Buytaert2004-06-27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | $ diffstat user.patch database/database.mysql | 4 database/database.pgsql | 2 database/updates.inc | 10 - modules/block.module | 20 +- modules/locale.module | 9 modules/profile.module | 108 +++++++---- modules/system.module | 8 modules/user.module | 456 +++++++++++++++++++----------------------------- 8 files changed, 289 insertions(+), 328 deletions(-) More functionality, less code. Here is a list of the changes: - Some user API changes: + When $type is 'form', you have to return an associative array of groups. In turn, each group is an array with a 'title', 'data' and 'weight'. + A new $type has been added, namely 'categories'. User settings can be organized in categories. Categories can be sorted, as can the groups within a category. (Ordering 'categories' is somewhat broken due to a bug in the menu system.) - The 'my account > edit' page will use subtabs for each 'category'. Read: you can break down the account settings into multiple subpages. - Profile module improvements: + Added support for private fields to the profile module! + Improved workflow of profile administration pages. + Improved the form descriptions. - Code improvements: + Unified user_edit() and user_admin_edit(). + Unified and cleaned up the validation code. Fixed some validation glitches too.
* - Fixed administration pages being broken due to tabs changes, improved formDries Buytaert2004-06-22
| | | | handling and form descriptions and fixed an incorrect title.
* Tabs patch!Dries Buytaert2004-06-18
| | | | | | | | | | | | | | | | | | CHANGES ------- + Introduced tabs. First, we extended the menu system to support tabs. Next, a tab was added for every link that was (1) an administrative action other than the implicit 'view' (2) relevant to that particular page only. This is illustrated by the fact that all tabs are verbs and that clicking a page's tab leads you to a subpage of that page. + Flattened the administration menu. The tabs helped simplify the navigation menu as I could separate 'actions' from 'navigation'. In addition, I removed the 'administer > configuration'-menu, renamed 'blocks' to 'sidebars' which I hope is a bit more descriptive, and made a couple more changes. Earlier, we already renamed 'taxonomy' to 'categorization' and we move 'statistics' under 'logs'. + Grouped settings. All settings have been grouped under 'administer > settings'. TODO ---- + Update core themes: only Xtemplate default supports tabs and even those look ugly. Need help. + Update contributed modules. The menu() hook changed drastically. Updating your code adhere the new menu() function should be 90% of the work. Moreover, ensure that your modue's admin links are still valid and that URLs to node get updated to the new scheme ('node/view/x' -> 'node/x').
* - Patch #8105 by mathias: made the menu system aware of path aliases.Dries Buytaert2004-06-01
|
* - Improved form handling.Dries Buytaert2004-05-31
| | | | | | | | | | | | | | | | | | | | | + Introduced two new functions: 1. form_set_error($name, $message): files an error against the form element with the specified $name. 2. form_has_errors(): returns true if errors has been filed against form elements. + Updated the form handling: 1. The form_ functions will add 'class="error"' when a form field has been found to be erroneous. 2. The error message is passed to theme_form_element() when the particular form field has been found to be erroneous. + I updated the user and profile module to take advantage of these new functions. + IMPORTANT: the _user() hook changed. The 'validate' case should no longer retun an error message when something goes wrong but should set it with form_set_error().
* - Added some error checking to the profile module.Dries Buytaert2004-05-28
|
* - Patch #7585 by Gerhard: extra data added by profile.module to the userDries Buytaert2004-05-05
| | | | | object got saved in the user's data column even if there is a dedicated table for that information.
* - Fixed sitewide timezone settings not being saved.Kjartan Mannes2004-04-29
| | | | - Making sure profile fields are saved properly.
* - Applied patch #6552: Put back register_form and register_validate ↵Kjartan Mannes2004-04-29
| | | | | | callbacks in user.module. - Fixed bug #7406: User delete hook incorrect params.
* - Patch #6791: mark required fields. Modified patch by Michelangelo.Dries Buytaert2004-04-24
|
* - Added support for 403 handling. Patch by JonBob. As a side benefit,Dries Buytaert2004-04-21
| | | | | | | | administrators will be able to define a custom 403 page, just as they can define 404 pages now. This needs to be documented in the "Changes since / migrating to ..." pages.
* - Patch by JonBob/Jonathan: reworked the menu system so that menus areDries Buytaert2004-04-15
| | | | | | | | | | | | configurable! Menu items can be disabled, repositioned, added and so on. Upgrading to requires you to run update.php. This functionality depricates some of the 'navigation modules' in the contributions repository. Furthermore, modules can now 'suggest' menu items and site adminstrators can choose to enable them. Modules in the contributions repository should try to take advantage of this.
* - Patch 6751 by TDobes: fixed call-by-reference problemDries Buytaert2004-03-29
|
* - Profile module improvement:Dries Buytaert2004-03-27
| | | | | | | | * Made it possible to set certain fields as 'required'. To do: * Mark them as required visually. * Add required fields to the subscription page.
* - Patch #6632 by Moshe: added missing brackets around table name.Dries Buytaert2004-03-27
|
* - More profile module improvements:Dries Buytaert2004-03-21
| | | | | | | | | | | + Updated the _user() hook's "$type == 'view'" case to match the "$type == 'edit'" case. That is, both have to return an associtive array of the format array('category' => 'fields'). + Updated the profile pages to group fields by category. Made possible thanks to the above change. + Moved logic out of the theme_ functions.
* - More profile module improvements:Dries Buytaert2004-03-21
| | | | + Add a new field type: 'list'.
* - Profile module improvements: added a URL-type field to the profile module.Dries Buytaert2004-03-21
| | | | | We can use this for the 'URL of homepage' field on drupal.org. URL fields are rendered as links and are being validated.
* - Profile module improvements:Dries Buytaert2004-03-20
| | | | | | | | + Made it possible to define the page title of the user listing pages. + Used form_group()s for the profile administration page. + Fixed bug in database/updates.inc.
* - Patch #6406 by TDobes: fixed typos in profile/user module.Dries Buytaert2004-03-15
|
* - Added a CVS IdDries Buytaert2004-03-13
|
* - Rewrote the profile module:Dries Buytaert2004-03-11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | + Added a 'created' field to the users table and renamed the 'timestamp' fied to 'changed' (cfr. node table). Update.php will try to determine a 'created' timestamp for existing users. + The profile module no longer uses serialized data but has its own set of tables. Known existing profile data is migrated by these new tables. TODO: migrate the birthday field. + The profile fields can be grouped, and within each group, profile fields can be sorted using weights. + The profile pages can be themed. + The profiles can be browsed based on certain properties/settings. + Change the _user hook: (i) 'private_view' and 'public_view' are merged into 'view' as there are no private fields and (ii) 'edit_form' has been renamed to 'edit'. + Avatar handling has been refactored and is now part of the user module. The users table has a dedicted 'picture' field. + Simplified the way themes should use display/visualize pictures or avatars. + Made it possible for administrators to replace or delete avatars. + ... I hope this make for a good base to build on collectively.
* - Patch 5969 by Chris: improved the profile module's context sensitive help textDries Buytaert2004-02-21
|
* - Patch 5592 by Goba: let drupal_map_assoc() rule. :-)Dries Buytaert2004-02-15
| | | | - Renamed CHANGELOG to CHANGELOG.txt for Windows uses.
* - Batch two with profile module improvements:Dries Buytaert2004-02-07
| | | | | | + Reworked the 'account administration' page. + Fixed bug in the 'edit account' page. + Removed some dead code from the system.module.
* - First batch of profile module improvements:Dries Buytaert2004-02-07
| | | | | | | | | | | | | + Tidied up the profile configuration page: grouped form elements. + Tidied up the block configuration settings: removed hard-coded table. + Changed the profile API to return the preferred group name, and changed the user module to group settings. Modules implementing the _user hook will need to be udpated. + Removed register_form and register_validate for now.
* - Patch #5021: clean up URLs in _help texts. Patch by UnConeD.Dries Buytaert2004-01-11
|
* - XHTML improvements: <b> -> <strong>. Patch by Stefan.Dries Buytaert2003-12-29
|
* - Tidied up some inconsistencies in the code: scripts/code-style.sh is your ↵Dries Buytaert2003-12-28
| | | | friend.
* - Fixed fileuploads for nodes failing without preview.Kjartan Mannes2003-12-27
|
* - Fixed switch in file_create_url().Kjartan Mannes2003-12-27
| | | | | - Fixed profile module not extracting mime type. - Improved file matching in profile module.
* - Added file handling. Work by Kjartan.Dries Buytaert2003-12-26
|
* - Fixed incorrect filter usageSteven Wittens2003-12-01
|
* - table(...) -> theme("table", ...)Dries Buytaert2003-11-13
|
* - Committed stage 2 of the theme system improvements! Patch by CodeMonkeyX.Dries Buytaert2003-11-09
|
* - Fixed prefix problem with the book module. Patch by Moshe.Dries Buytaert2003-10-13
| | | | | | | | | | | | | | - Usability improvements to the user module: removed some redundant menu items by taking advantage of the column sorting, added status messages and so on. Patch by Moshe plus some fixes. - Made the profile module use the table() function. Patch by Moshe. - Fixed breadcrumb spacing. Patch by Moshe. - Fixed colspan problem with node overview table. Patch by Stefan. - Fixed inconsistency with table sorting. Patch 0122 by Al.
* - Fixed translation bugs with statistics module. Patch by Gabor.Dries Buytaert2003-10-12
| | | | | | - Removed 'homepage' field from user table. Patch by Gabor. - Added 'real name' field to the profile module. Patch by Gabor.
* - Help system improvements: eliminated the _system hook. Patch by Michael.Dries Buytaert2003-10-07
| | | | | | - Bloggerapi module fixes. Patch by Kjartan. - Coding style fixes. Patch by Michael.
* - Help improvements and translation improvements from Michael. Thanks!Dries Buytaert2003-10-03
|
* - Updated the profile module to use the new help system. Patch by Michael.Dries Buytaert2003-08-23
|
* - Some documentation fixes as per Charlie's suggestion: bug #2260.Dries Buytaert2003-07-14
|
* - Bugfix: fixed problem with changing themes. Didn't apply Al's patch asDries Buytaert2003-06-20
| | | | | | | | the fix was somewhat simpler. Fixes bug #2003. - Bugfix: fixed problem with voting on certain poll pages. Patch #37 by Al. - Improvement: removed stupid descriptions from profile module.
* - Improvements: XHTML-ifications. Patch by GmbH.Dries Buytaert2003-06-15
|
* - Bugfix: fixed the CREATE FUNCTION in database.mssql as it needs to be ↵Dries Buytaert2003-06-11
| | | | | | | | | | | | | | | | | | | | | | | | prefixed with GO for some obscure reason. Patch by Kjartan. - Bugfix: fixed the defaults for blocks in database.mssql so the NOT NULL fields get values. Patch by Kjartan. - Bugfix: changed check_form() to use htmlspecialchars() instead of drupal_specialchars() as this caused Drupal to emit incorrect form items in presence of quotes. Example: <input type="submit" class="form-submit" name="op" value="Submit "top nodes" block changes" /> IMO, drupal_specialchars() is better called xmlspecialchars() to avoid confusion. - Bugfix: when an anonymous user visits a site, they shouldn't see any content (except the login block, if it is enabled) unless they have the "access content" permissions. Patch by Matt Westgate. - Improvement: improved the error checking and the error messages in the profile module. Updated the code to match the Drupal coding conventions. Modified patch from Matt Westgate. - Improvement: don't generate the <base href=""> tag in the base theme; it is already emitted by theme_head(). Patch by Kristjan. - Improvement: don't execute any SQL queries when checking the permissions of user #1. Patch by Kjartan. - Improvement: made a scalable layout form that works in IE and that behaves better with narrow themes. Part of patch #51 by Al. - Improvement: removed some redundant print statements from the comment module. Modified patch from Craig Courtney.
* - Bugfix: an administrator could not edit the avator through the admin ↵Dries Buytaert2003-06-10
| | | | interface because it used the global $user object inside its functions rather then the user to be edited. Patch by Matt Westgate.