| Commit message (Collapse) | Author | Age |
|---|
| |
|
|
|
|
| |
type) configuration page.
Modified the patch to remove some redundant code, to translate strings, and to better use the menu system.
|
| |
|
|
| |
node_access_*_sql calls.
|
| |
|
|
|
|
|
|
| |
1) The different types of search, which used to be radio button options in the search form, are now subtabs of "search" (default "search/node"). This seems better from a UI point of view, but also has another advantage: modules which implement a custom search form (flexinode, project) can add it as a subtab of search. This means that all search forms will be located in the same place, and also without needing an extra api call to search.module.
2) The current code was a bit hackish, as the indexing of comments along with nodes was hardcoded in node.module. Instead, I created a nodeapi operation "update index" which allows modules to add more data for a node that is being indexed. Comments are now indexed using this mechanism and from comment.module, which is a lot cleaner.
3) The search results format was also hardcoded to include "N comments". I replaced this with a nodeapi operation "search result" and moved the comment code to comment.module where it belongs. This op is quite useful, as for example I also modified upload.module to add "N attachments" to a search result if any are present.
|
| | |
|
| |
|
|
| |
accessible.
|
| |
|
|
| |
consistency.
|
| | |
|
| |
|
|
| |
viewing/downloading. It does not make sense to only allow downloading for people who can upload themselves.
|
| |
|
|
| |
mistakenly cached when they cannot be. Attached patch fixes this as well as a reference to an undefined constant in legacy_menu().
|
| | |
|
| |
|
|
|
| |
- removing file checks for uid #1 to be consistent with the roles/permissions.
- renaming script files to .txt's to prevent accidental execution (we don't allow them by default, but you never know)
|
| |
|
|
| |
not set (e.g. nodes that don't take attachments).
|
| |
|
|
|
|
|
|
|
|
|
|
| |
Upload.module
- Fixing a bug caused by the PHP5 patches.
Beware: PHP4's array_merge() will silently accept objects and convert them to arrays. We should not depend on this behaviour in the future.
File.inc / file-using modules:
- Removing the constant FILE_SEPARATOR: forward slashes work fine on Windows, and it was being used incorrectly as an URL separator sometimes.
- Adding @ to mkdir and chmod to supress ugly PHP errors. They are already reported with drupal_set_message().
- Fixing default for variable 'file_directory_temp'.
- Clarifying the help tip for 'file_directory_temp' in admin > settings.
|
| |
|
|
| |
of each source file inside the @file comment block at the head of the file. This helps with Doxygen indexing, and also allows neophytes to see what a file does immediately on opening the source, regardless of the organization of the hooks.
|
| |
|
|
| |
added some missing t() functions).
|
| |
|
|
|
|
|
| |
- Admin - upload only shows up for 'access administration section' perms
- Users without 'upload files' perm do not see the attachments form (and cannot attach even when sending their own http request)
Note: if a user can edit a node, but not 'upload files', then the attachments are left untouched (and cannot be changed).
|
| |
|
|
|
|
| |
+ " -> '
+ Using form_set_error() instead of drupal_set_message().
+ Removed dead code.
|
| | |
|
| |
|
|
| |
This makes sense because people will expect attachments to work everywhere when they enable this module. This also matches comment.module's behaviour, where comments are allowed by default unless turned off.
|
| |
|
