| Commit message (Collapse) | Author | Age |
| |
|
|
|
|
| |
u.status < N LIMIT N, N' query.
|
|
|
|
| |
executes a query and never uses the results.
|
| |
|
| |
|
|
|
|
| |
roles assigned when the form clearly said at least one was required. The result of saving that was silently leaving the roles unchanged, which is rather bad.
|
|
|
|
| |
use /user/$uid instead of /user/$uid/edit (where possible).
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Upload.module
- Fixing a bug caused by the PHP5 patches.
Beware: PHP4's array_merge() will silently accept objects and convert them to arrays. We should not depend on this behaviour in the future.
File.inc / file-using modules:
- Removing the constant FILE_SEPARATOR: forward slashes work fine on Windows, and it was being used incorrectly as an URL separator sometimes.
- Adding @ to mkdir and chmod to supress ugly PHP errors. They are already reported with drupal_set_message().
- Fixing default for variable 'file_directory_temp'.
- Clarifying the help tip for 'file_directory_temp' in admin > settings.
|
|
|
|
| |
broken.
|
|
|
|
| |
of each source file inside the @file comment block at the head of the file. This helps with Doxygen indexing, and also allows neophytes to see what a file does immediately on opening the source, regardless of the organization of the hooks.
|
|
|
|
|
|
|
|
| |
- Changing theme('image') so the automatic image size fetching can be toggled independently from attributes. Specifying attributes and autosizing are 2 different things.
- Suppressing PHP errors from getimagesize() using @. drupal_set_message() is used to report these errors already and in a much prettier way.
- #9958: Fixing broken displaying of avatars.
- Don't show the default avatar in 'edit my account' if the user has no avatar of his/her own.
- Added ability to delete avatars (without having to replace them).
|
| |
|
|
|
|
| |
added some missing t() functions).
|
|
|
|
| |
easier to translate).
|
| |
|
|
|
|
| |
messages start with a capital letter.
|
| |
|
|
|
|
|
| |
* Refactored the "brains" of user_login() to user_authenticate($user, $pass) so that blogapi (and others) can authenticate users (including those using DistAuth) without all the html and drupal_goto calls
* Updates blogapi_validate_user to use user_authenticate.
|
|
|
|
|
| |
* Adds missing quotes around the username in "session closed" watchdog messages from user.module (session opened has quotes, but session closed does not).
* Changed "view detals" after watchdog entries to "details".
|
|
|
|
| |
I had some trouble adding this feature but realized that the "who's online" block is a geek think, and therefore it won't hurt to add some more geekiness. If you don't know what "offline users" means, you would not have understood "online users" in the first place. Either way, I think most people who have the block enabled, will find this an interesting addition.
|
| |
|
| |
|
| |
|
|
|
|
| |
Replaced the use of ucfirst() with a CSS-based solution.
|
|
|
|
| |
password.
|
|
|
|
| |
"delete foo," and "view foo" links into simply "edit," "delete," and "view".
|
|
|
|
| |
left-overs.
|
|
|
|
| |
able to use this patch too.
|
| |
|
| |
|
| |
|
|
|
|
| |
else's account.
|
| |
|
| |
|
|
|
|
| |
later.
|
| |
|
|
|
|
| |
not have the 'access users' permission set.
|
|
|
|
|
|
|
|
| |
system is now using form_set_error() and friends like the rest of Drupal does. This makes for both a consistent user experience and consistent code. It simplifies the forms and validation code, however, it does change the node API slightly:
* The _validate hook and the _nodeapi('validate') hook of the node API (1) no longer take an 'error' parameter and (2) should no longer return an error array. To set an error, call form_set_error().
* The _form hook of the node module no longer takes a form hook and should not worry about displaying errors. Ditto for _nodeapi('form_post') and _nodeapi('form_pre').
|
|
|
|
| |
seems to need. It generates an error under php5. Found by redLED.
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
it.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
$ diffstat user.patch
database/database.mysql | 4
database/database.pgsql | 2
database/updates.inc | 10 -
modules/block.module | 20 +-
modules/locale.module | 9
modules/profile.module | 108 +++++++----
modules/system.module | 8
modules/user.module | 456 +++++++++++++++++++-----------------------------
8 files changed, 289 insertions(+), 328 deletions(-)
More functionality, less code. Here is a list of the changes:
- Some user API changes:
+ When $type is 'form', you have to return an associative array of groups. In turn, each group is an array with a 'title', 'data' and 'weight'.
+ A new $type has been added, namely 'categories'. User settings can be organized in categories. Categories can be sorted, as can the groups within a category. (Ordering 'categories' is somewhat broken due to a bug in the menu system.)
- The 'my account > edit' page will use subtabs for each 'category'. Read: you can break down the account settings into multiple subpages.
- Profile module improvements:
+ Added support for private fields to the profile module!
+ Improved workflow of profile administration pages.
+ Improved the form descriptions.
- Code improvements:
+ Unified user_edit() and user_admin_edit().
+ Unified and cleaned up the validation code. Fixed some validation glitches too.
|
|
|
|
| |
profile fields of users.
|