Commit message (Collapse) | Author | Age | |
---|---|---|---|
* | - Patch #45530 by Morbus: filter_form shouldn't default to #weight 0 | Dries Buytaert | 2006-01-20 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | When a form element doesn't specify a #weight, it is assumed internally as #weight 0. However, to ensure that our form elements display visually *as they were defined in the array* we, in form_builder, count the number of elements, divide by 1000, and set that as the weight: # Assign a decimal placeholder weight to preserve original array order if (!isset($form[$key]['#weight'])) { $form[$key]['#weight'] = $count/1000; } The above code will set the #weights of elements that have not defined a weight to something like 0 (first element in array definition), 0.001, 0.002, and so on. However, anytime a form element *explicitly* defines a #weight of 0, that #weight is kept at exactly 0, which would cause that form element to appear BEFORE the elements that didn't have a #weight defined (and thus received a #weight such as 0.002). Consider the following pseudo example: $form['game_title'] = array( '#type' => 'textfield', ... ); $form['game_description'] = array( '#type' => 'textarea', ... ); $form['game_format'] = filter_form(variable_get('game_format', NULL)); return $form; Here, we're not definiing weights on our two textfields. We then add an filter_form. The second parameter of the filter_form is $weight, which defaults to 0. After this $form hits form_builder, we have weights 0 (game_title), 0.001 (game_description), and 0 (filter_form) respectively. This is then sorted by weight, which causes filter_form (the third element in the array) to appear BEFORE game_description (0 is lighter than 0.001). The short lesson is: explicitly defining #weight 0 for a form element is probably a bad idea. This patch changes the default #weight of filter_form to NULL, instead of 0, and also removes any other explicit setting of #weight to 0 in core. | ||
* | - Patch #45312 by Robin and Zen: made theme_user_list() more like ↵ | Dries Buytaert | 2006-01-20 |
| | | | | theme_item_list(), made it robust for empty lists. | ||
* | - Patch #44754 by Zen: fixed "Who's new" block inaccuracy. | Dries Buytaert | 2006-01-17 |
| | |||
* | - Patch #44767 by jvandyk: small (code) improvements | Dries Buytaert | 2006-01-15 |
| | |||
* | - Patch #44210 by DriesK: made it possible to edit blocked users. | Dries Buytaert | 2006-01-13 |
| | |||
* | - Added trailing point. | Dries Buytaert | 2006-01-13 |
| | |||
* | - Patch #44507 by DriesK: consistency: email -> e-mail. | Dries Buytaert | 2006-01-13 |
| | |||
* | - Patch #44261 by Kobus/Zen: drupal -> Drupal. | Dries Buytaert | 2006-01-12 |
| | |||
* | - Patch #40401 by driesk: fixed incorrect form conversion. | Dries Buytaert | 2006-01-12 |
| | |||
* | - Patch #44373 by m3avrck: improved generated HTML/CSS. | Dries Buytaert | 2006-01-12 |
| | |||
* | - Modified patch #44156 by Zen: '%s' -> %d. | Dries Buytaert | 2006-01-10 |
| | |||
* | - Patch #36716 by m3vrick: made deleting user accounts work. | Dries Buytaert | 2006-01-09 |
| | |||
* | - Patch #43668 by chx: fixed warning. | Dries Buytaert | 2006-01-09 |
| | |||
* | - Patch #43668 by chx: fixed problem with changing usernames. | Dries Buytaert | 2006-01-09 |
| | |||
* | - Patch #43833 by killes: give the first user a default role. | Dries Buytaert | 2006-01-08 |
| | |||
* | - Patch #39639 by Richard: 'users' appearing twice in menu. | Dries Buytaert | 2006-01-06 |
| | |||
* | - Patch #42541 by merlinofchaos: critical bug fix: public user registrations ↵ | Dries Buytaert | 2006-01-05 |
| | | | | not always working. | ||
* | - Patch #42057 by hunmonk and chx: made saving user accounts work again. | Dries Buytaert | 2006-01-02 |
| | |||
* | - Patch 42115 by Cvbge/ m3avrck: improved performance of session loading. | Dries Buytaert | 2005-12-31 |
| | |||
* | - Patch 41169 by Chris: got rid of expensvie object 2 array casts. | Dries Buytaert | 2005-12-31 |
| | |||
* | - Patch #41305 by chx: user edit form submit model rewrite. | Dries Buytaert | 2005-12-19 |
| | |||
* | - Patch #29060 by tostinne/ax: added tabindex to user login page. | Dries Buytaert | 2005-12-11 |
| | |||
* | - Patch #40583 by canen: make user_autocomplete function work with PostgreSQL. | Dries Buytaert | 2005-12-10 |
| | |||
* | - Patch #40341 by Neil: fixed problems with database schema versions. | Dries Buytaert | 2005-12-08 |
| | | | | | | | - When user #1 creates an account (we can assume this happens only once), system.module's schema version is set to the latest availiable. - system_get_files_database() now includes a 'schema_version' child of each file object. - That new information is re-saved when Drupal re-populates the system table. - An array of newly-enabled modules is built, module_list() is reloaded, and the schema versions of each newly-enabled module are set to the most recent availiable. If the schema version is already set (presumably from a previous installation) it is not changed. | ||
* | - Patch #26641 by Uwe: tabs disappear in user.module settings after saving a ↵ | Dries Buytaert | 2005-12-06 |
| | | | | role. | ||
* | - Patch #39576 by chx: rename '_execute' to '_submit' and '#execute' to ↵ | Dries Buytaert | 2005-12-02 |
| | | | | '#submit'. | ||
* | - Patch #39547 by saerdna et al.: added a 'change own username' permission. | Dries Buytaert | 2005-12-02 |
| | |||
* | - Patch #38981 by Robert: add permission to enable/disbale theme switching ↵ | Dries Buytaert | 2005-11-30 |
| | | | | by users. | ||
* | - Patch #38945 by wtanaka: made the login block redirect back to the ↵ | Dries Buytaert | 2005-11-28 |
| | | | | original page. | ||
* | - Patch #38412 by m3avrck: fixed problem with creating first account. | Dries Buytaert | 2005-11-22 |
| | |||
* | - Patch #37416 by Zen: make auto-completion of usernames work with short names. | Dries Buytaert | 2005-11-21 |
| | |||
* | - Patch #38248 by hunkmonk: updated the user login form to the forms API's ↵ | Dries Buytaert | 2005-11-21 |
| | | | | _execute model. | ||
* | - Patch #37738 by Junyor: fixed problem with Drupal not properly unsetting ↵ | Dries Buytaert | 2005-11-15 |
| | | | | $user on logout. | ||
* | - Patch #32669 by DriesK: split blocking users from 'adminsiter access'. | Dries Buytaert | 2005-11-14 |
| | |||
* | - Patch #35644 by webchick: forms API simplificiations. | Dries Buytaert | 2005-11-12 |
| | |||
* | - Patch #26249 by Morbus: improved handling of temporary files/directory. | Dries Buytaert | 2005-11-12 |
| | | | | | | | | If your module uses variable_get('file_directory_temp', ...) or variable_get('file_directory_path', ...) please update it to use the new API. A list of affected modules is available at http://drupal.org/node/26249#comment-54194. | ||
* | - SQL query maintenance: '%d' -> %d. | Dries Buytaert | 2005-11-12 |
| | |||
* | - Patch #26139 by webchick / Kieran / documentation team: improved admin ↵ | Dries Buytaert | 2005-11-01 |
| | | | | help of core modules! / | ||
* | - Patch #35648 by asimmonds: fixed permissions page. | Dries Buytaert | 2005-10-31 |
| | |||
* | - #35440: Fix user 1 login bug after forms api | Steven Wittens | 2005-10-28 |
| | |||
* | - Patch #30930 by m3avrck/deekayen: cured PHP5 warnings. | Dries Buytaert | 2005-10-22 |
| | |||
* | - Modified patch #34472 by Moshe: uid=1 does not redirect to edit page after ↵ | Dries Buytaert | 2005-10-21 |
| | | | | registration. | ||
* | - Patch #34031 by drewish: delete button on the edit user account form ↵ | Dries Buytaert | 2005-10-21 |
| | | | | should be after the submit button. | ||
* | - Modified version of patch #33348 by wolff: clean URL emitted when creating ↵ | Dries Buytaert | 2005-10-13 |
| | | | | first user. | ||
* | - #33433: More form API fixes, and error handling improvements by Chx. | Steven Wittens | 2005-10-13 |
| | |||
* | - Restore user login block alignment (form api patch undid some recent ↵ | Steven Wittens | 2005-10-11 |
| | | | | class/id changes) | ||
* | - Patch #33752 by chx, adrian, et al: another batch of form API changes/fixes. | Dries Buytaert | 2005-10-11 |
| | |||
* | - Second batch of form API fixes by chx. | Dries Buytaert | 2005-10-09 |
| | |||
* | - Patch #31341 by kbahey: delete a user's session when the user is deleted. | Dries Buytaert | 2005-10-07 |
| | |||
* | - Patch #29465: new form API by Adrian et al. | Dries Buytaert | 2005-10-07 |
| | | | | | | | TODO: + The contact.module was broken; a new patch for contact.module is needed. + Documentation is needed. + The most important modules need to be updated ASAP. |