Commit message (Collapse) | Author | Age | |
---|---|---|---|
* | - Patch #46388 by m3avrck: removed some dead code. Yay. | Dries Buytaert | 2006-01-26 |
| | |||
* | - Patch #45076 by m3avrck: fix bad markup and title for some watchdog warnings. | Dries Buytaert | 2006-01-26 |
| | |||
* | - Patch #35926 by asimmonds: make required vocabularies actually required. | Dries Buytaert | 2006-01-26 |
| | |||
* | - Patch #40752 by moshe/wtanaka: login and regsiter links on each comment ↵ | Dries Buytaert | 2006-01-26 |
| | | | | don't redirect back to the topic. | ||
* | - #45742: XHTML slash fix. | Steven Wittens | 2006-01-25 |
| | |||
* | - Patch #45742 by chx: fixed problem with closed tags being filtered out. | Dries Buytaert | 2006-01-25 |
| | |||
* | - Patch #40753 by wtanaka/killes: #comment-form has disappeared from ↵ | Dries Buytaert | 2006-01-25 |
| | | | | comment.module | ||
* | - Patch #23538 by Zen: mark required fields are being required. The new ↵ | Dries Buytaert | 2006-01-25 |
| | | | | forms API will enforce this too. :) | ||
* | - Patch #45665 by wtanaka/moshe: removed dead code! w00t! | Dries Buytaert | 2006-01-24 |
| | |||
* | - Patch #45845 by jaza/chx: set default value of weight-selectors to 0 for ↵ | Dries Buytaert | 2006-01-24 |
| | | | | consistency with Drupal 4.6. | ||
* | - Patch #45793 by chx: fixed bug in user.module that results in storing ↵ | Dries Buytaert | 2006-01-24 |
| | | | | plain text passwords. | ||
* | - Patch #46106 by markus: usability improvement: moved the block description ↵ | Dries Buytaert | 2006-01-24 |
| | | | | textfield up. | ||
* | - Modified patch #37754 by Thomas: made the status message show up. | Dries Buytaert | 2006-01-24 |
| | |||
* | - Patch #45706 by markus: keep up with CSS improvements. | Dries Buytaert | 2006-01-24 |
| | |||
* | - Patch #33861 by Morbus et al: clean up the watchdog view. | Dries Buytaert | 2006-01-24 |
| | |||
* | - Patch #45729 by markus, jvandyk, moshe: fixed problem with permission ↵ | Dries Buytaert | 2006-01-23 |
| | | | | checking. | ||
* | - Patch #44828 by chx/Crell: make sure the url/path is properly initialized ↵ | Dries Buytaert | 2006-01-23 |
| | | | | in statistics_exit(). | ||
* | - Patch #45320 by Zen: improved usability of off-line mode. | Dries Buytaert | 2006-01-22 |
| | |||
* | - Patch #45697 by fgm: removed some useless global. | Dries Buytaert | 2006-01-22 |
| | |||
* | - Patch #33102 by Kobus et al: show dates properly. | Dries Buytaert | 2006-01-22 |
| | |||
* | - Patch #45706 by markus: keeping up with CSS improvements. | Dries Buytaert | 2006-01-22 |
| | |||
* | - Patch #45684 by wtanaka: added missing ''s | Dries Buytaert | 2006-01-22 |
| | |||
* | - Patch #44101 by Cvbge: deleting a comment creates incorrect entry in ↵ | Dries Buytaert | 2006-01-22 |
| | | | | node_comment_statistics. | ||
* | - Patch #45843 by markus: roles are no longer required. | Dries Buytaert | 2006-01-22 |
| | |||
* | - Patch #44379 by Moshe: code improvements: always grant the 'authenticated ↵ | Dries Buytaert | 2006-01-21 |
| | | | | user' role to authenticated users. Fixed glitch with udpate path. | ||
* | - #40515: Ensure UTF-8 character set on the database side (and include ↵ | Steven Wittens | 2006-01-21 |
| | | | | upgrade path for incorrectly set up databases) | ||
* | - Patch #42137 by Richard: deleting non existent user blocks the whole ↵ | Dries Buytaert | 2006-01-20 |
| | | | | drupal site. | ||
* | - Patch #45380 by Neil: usability improvement: disable anonymous commenting ↵ | Dries Buytaert | 2006-01-20 |
| | | | | options when anonymous people can't comment. | ||
* | - Patch #45228 and patch #45025 by m3avrck and Uwe: aggregator module ↵ | Dries Buytaert | 2006-01-20 |
| | | | | HTML/CSS cleanups. | ||
* | - Patch #45530 by Morbus: filter_form shouldn't default to #weight 0 | Dries Buytaert | 2006-01-20 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | When a form element doesn't specify a #weight, it is assumed internally as #weight 0. However, to ensure that our form elements display visually *as they were defined in the array* we, in form_builder, count the number of elements, divide by 1000, and set that as the weight: # Assign a decimal placeholder weight to preserve original array order if (!isset($form[$key]['#weight'])) { $form[$key]['#weight'] = $count/1000; } The above code will set the #weights of elements that have not defined a weight to something like 0 (first element in array definition), 0.001, 0.002, and so on. However, anytime a form element *explicitly* defines a #weight of 0, that #weight is kept at exactly 0, which would cause that form element to appear BEFORE the elements that didn't have a #weight defined (and thus received a #weight such as 0.002). Consider the following pseudo example: $form['game_title'] = array( '#type' => 'textfield', ... ); $form['game_description'] = array( '#type' => 'textarea', ... ); $form['game_format'] = filter_form(variable_get('game_format', NULL)); return $form; Here, we're not definiing weights on our two textfields. We then add an filter_form. The second parameter of the filter_form is $weight, which defaults to 0. After this $form hits form_builder, we have weights 0 (game_title), 0.001 (game_description), and 0 (filter_form) respectively. This is then sorted by weight, which causes filter_form (the third element in the array) to appear BEFORE game_description (0 is lighter than 0.001). The short lesson is: explicitly defining #weight 0 for a form element is probably a bad idea. This patch changes the default #weight of filter_form to NULL, instead of 0, and also removes any other explicit setting of #weight to 0 in core. | ||
* | - Patch #45312 by Robin and Zen: made theme_user_list() more like ↵ | Dries Buytaert | 2006-01-20 |
| | | | | theme_item_list(), made it robust for empty lists. | ||
* | - Patch #45281 by chx: made categories with forum topics work again. | Dries Buytaert | 2006-01-19 |
| | |||
* | - Patch #45336 by Ber: bugfix: removed obsolete check_plain() check causing ↵ | Dries Buytaert | 2006-01-19 |
| | | | | & problems. | ||
* | - Patch #39430 by Jaza and Richard: code improvements: improved separation ↵ | Dries Buytaert | 2006-01-19 |
| | | | | between UI and logic. | ||
* | - Patch #45349 by Morbus Iff: input filters aren't sorting correctly ↵ | Dries Buytaert | 2006-01-19 |
| | | | | infForms API. | ||
* | - #42277: Make node search indexing more robust against bad nodes and timeouts. | Steven Wittens | 2006-01-18 |
| | |||
* | - Patch #45301 by Morbus: corrected the weight of form item titles of nodes. | Dries Buytaert | 2006-01-18 |
| | |||
* | - Patch #45206 by markus: attempt at making the node filters somewhat ↵ | Dries Buytaert | 2006-01-18 |
| | | | | translatable. | ||
* | - Patch #43325 by chx/drumm/merlinofchaos: critical bugfix: made editing ↵ | Dries Buytaert | 2006-01-18 |
| | | | | comments work. | ||
* | - Patch #45259 by chx/drumm: cast to object required. | Dries Buytaert | 2006-01-18 |
| | |||
* | - Patch #42072 by m3avrck: more improvements to the node revesion overview ↵ | Dries Buytaert | 2006-01-17 |
| | | | | screen. | ||
* | - Patch #42072 by m3avrck: improved the revision overview screen. | Dries Buytaert | 2006-01-17 |
| | |||
* | - Patch #45041 by markus: rand() -> mt_rand() + removed deprecated comments. | Dries Buytaert | 2006-01-17 |
| | |||
* | - Patch #40755 by wtanaka: make the comment block themable. | Dries Buytaert | 2006-01-17 |
| | |||
* | - Critical feature #40670: made the form array accessible. | Dries Buytaert | 2006-01-17 |
| | |||
* | - Patch #44136 by riccardoR: can't enable more than one language. | Dries Buytaert | 2006-01-17 |
| | |||
* | - Patch #44381 by gerhard: improved consistency of API. Always pass an array. | Dries Buytaert | 2006-01-17 |
| | |||
* | - Patch #44754 by Zen: fixed "Who's new" block inaccuracy. | Dries Buytaert | 2006-01-17 |
| | |||
* | - Patch #39329 by markus: order sources in aggregator. | Dries Buytaert | 2006-01-15 |
| | |||
* | - Patch #44767 by jvandyk: small (code) improvements | Dries Buytaert | 2006-01-15 |
| |