Commit message (Collapse) | Author | Age | |
---|---|---|---|
* | - Patch #45228 and patch #45025 by m3avrck and Uwe: aggregator module ↵ | Dries Buytaert | 2006-01-20 |
| | | | | HTML/CSS cleanups. | ||
* | - Patch #45530 by Morbus: filter_form shouldn't default to #weight 0 | Dries Buytaert | 2006-01-20 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | When a form element doesn't specify a #weight, it is assumed internally as #weight 0. However, to ensure that our form elements display visually *as they were defined in the array* we, in form_builder, count the number of elements, divide by 1000, and set that as the weight: # Assign a decimal placeholder weight to preserve original array order if (!isset($form[$key]['#weight'])) { $form[$key]['#weight'] = $count/1000; } The above code will set the #weights of elements that have not defined a weight to something like 0 (first element in array definition), 0.001, 0.002, and so on. However, anytime a form element *explicitly* defines a #weight of 0, that #weight is kept at exactly 0, which would cause that form element to appear BEFORE the elements that didn't have a #weight defined (and thus received a #weight such as 0.002). Consider the following pseudo example: $form['game_title'] = array( '#type' => 'textfield', ... ); $form['game_description'] = array( '#type' => 'textarea', ... ); $form['game_format'] = filter_form(variable_get('game_format', NULL)); return $form; Here, we're not definiing weights on our two textfields. We then add an filter_form. The second parameter of the filter_form is $weight, which defaults to 0. After this $form hits form_builder, we have weights 0 (game_title), 0.001 (game_description), and 0 (filter_form) respectively. This is then sorted by weight, which causes filter_form (the third element in the array) to appear BEFORE game_description (0 is lighter than 0.001). The short lesson is: explicitly defining #weight 0 for a form element is probably a bad idea. This patch changes the default #weight of filter_form to NULL, instead of 0, and also removes any other explicit setting of #weight to 0 in core. | ||
* | - Patch #45312 by Robin and Zen: made theme_user_list() more like ↵ | Dries Buytaert | 2006-01-20 |
| | | | | theme_item_list(), made it robust for empty lists. | ||
* | - Patch #45281 by chx: made categories with forum topics work again. | Dries Buytaert | 2006-01-19 |
| | |||
* | - Patch #45336 by Ber: bugfix: removed obsolete check_plain() check causing ↵ | Dries Buytaert | 2006-01-19 |
| | | | | & problems. | ||
* | - Patch #39430 by Jaza and Richard: code improvements: improved separation ↵ | Dries Buytaert | 2006-01-19 |
| | | | | between UI and logic. | ||
* | - Patch #45349 by Morbus Iff: input filters aren't sorting correctly ↵ | Dries Buytaert | 2006-01-19 |
| | | | | infForms API. | ||
* | - #42277: Make node search indexing more robust against bad nodes and timeouts. | Steven Wittens | 2006-01-18 |
| | |||
* | - Patch #45301 by Morbus: corrected the weight of form item titles of nodes. | Dries Buytaert | 2006-01-18 |
| | |||
* | - Patch #45206 by markus: attempt at making the node filters somewhat ↵ | Dries Buytaert | 2006-01-18 |
| | | | | translatable. | ||
* | - Patch #43325 by chx/drumm/merlinofchaos: critical bugfix: made editing ↵ | Dries Buytaert | 2006-01-18 |
| | | | | comments work. | ||
* | - Patch #45259 by chx/drumm: cast to object required. | Dries Buytaert | 2006-01-18 |
| | |||
* | - Patch #42072 by m3avrck: more improvements to the node revesion overview ↵ | Dries Buytaert | 2006-01-17 |
| | | | | screen. | ||
* | - Patch #42072 by m3avrck: improved the revision overview screen. | Dries Buytaert | 2006-01-17 |
| | |||
* | - Patch #45041 by markus: rand() -> mt_rand() + removed deprecated comments. | Dries Buytaert | 2006-01-17 |
| | |||
* | - Patch #40755 by wtanaka: make the comment block themable. | Dries Buytaert | 2006-01-17 |
| | |||
* | - Critical feature #40670: made the form array accessible. | Dries Buytaert | 2006-01-17 |
| | |||
* | - Patch #44136 by riccardoR: can't enable more than one language. | Dries Buytaert | 2006-01-17 |
| | |||
* | - Patch #44381 by gerhard: improved consistency of API. Always pass an array. | Dries Buytaert | 2006-01-17 |
| | |||
* | - Patch #44754 by Zen: fixed "Who's new" block inaccuracy. | Dries Buytaert | 2006-01-17 |
| | |||
* | - Patch #39329 by markus: order sources in aggregator. | Dries Buytaert | 2006-01-15 |
| | |||
* | - Patch #44767 by jvandyk: small (code) improvements | Dries Buytaert | 2006-01-15 |
| | |||
* | - #44772: {} -> [] (in anticipation of PHP de-deprecation) | Steven Wittens | 2006-01-15 |
| | |||
* | - Patch #39135 by Zen: various contact form improvements/fixes. | Dries Buytaert | 2006-01-14 |
| | | | | | | | | | | | | + Conversion to _validate + _submit model.. + Split replaced by explode - faster + Fixed typos: Recipient + Fixed weight defaulting to -10 + Popped mail subject formatting into a t() + Popped '--' formatting into a t() + Does a lot of documentation fixing/rewriting. + Renamed contact_user_mail form functions to contact_mail_user for consistency. + ... | ||
* | - Extended the form description for clarity. | Dries Buytaert | 2006-01-14 |
| | |||
* | - Patch #44544 by Richard: made the help text slightly more accurate. | Dries Buytaert | 2006-01-14 |
| | |||
* | - Patch #44210 by DriesK: made it possible to edit blocked users. | Dries Buytaert | 2006-01-13 |
| | |||
* | - Patch #44490 by darius: don't show blocked users on the profile pages. | Dries Buytaert | 2006-01-13 |
| | |||
* | - Added trailing point. | Dries Buytaert | 2006-01-13 |
| | |||
* | - Patch #44499 by Neil: missing quotes. | Dries Buytaert | 2006-01-13 |
| | |||
* | - Patch #44507 by DriesK: consistency: email -> e-mail. | Dries Buytaert | 2006-01-13 |
| | |||
* | - Patch #44261 by Kobus/Zen: drupal -> Drupal. | Dries Buytaert | 2006-01-12 |
| | |||
* | - Patch #40401 by driesk: fixed incorrect form conversion. | Dries Buytaert | 2006-01-12 |
| | |||
* | - Patch #33128 by Morbus: %num -> %count to make format_plural() work. | Dries Buytaert | 2006-01-12 |
| | |||
* | - Patch #42029 by drumm: correct post times for administrators posting using ↵ | Dries Buytaert | 2006-01-12 |
| | | | | a blogapi client. | ||
* | - Patch #44163 by m3avrck: fixed typo in permission and fixed incorrect ↵ | Dries Buytaert | 2006-01-12 |
| | | | | description. | ||
* | - Patch #44373 by m3avrck: improved generated HTML/CSS. | Dries Buytaert | 2006-01-12 |
| | |||
* | - Modified patch #44156 by Zen: '%s' -> %d. | Dries Buytaert | 2006-01-10 |
| | |||
* | - Patch #39672 by Ber: made the help text opion work for free tagging terms. | Dries Buytaert | 2006-01-10 |
| | |||
* | - Removed reference to comment moderation. | Dries Buytaert | 2006-01-10 |
| | |||
* | - Patch #33747 by Ber and Moshe: bugfix + code improvement: clean up some of ↵ | Dries Buytaert | 2006-01-10 |
| | | | | the taxonomy loading code. | ||
* | - Patch #43989 by darius: critical bugfix: removed debug code from profile ↵ | Dries Buytaert | 2006-01-10 |
| | | | | module. | ||
* | - Patch #36716 by m3vrick: made deleting user accounts work. | Dries Buytaert | 2006-01-09 |
| | |||
* | - Patch #43668 by chx: fixed warning. | Dries Buytaert | 2006-01-09 |
| | |||
* | - Patch #43668 by chx: fixed problem with changing usernames. | Dries Buytaert | 2006-01-09 |
| | |||
* | - Removed global . | Dries Buytaert | 2006-01-09 |
| | |||
* | - Patch #43833 by killes: give the first user a default role. | Dries Buytaert | 2006-01-08 |
| | |||
* | - Patch #42886 by chx: critical feature: allow modules to be reordered. | Dries Buytaert | 2006-01-08 |
| | |||
* | - Patch #42937 by chx: bugfix: added missing db_rewrite_sql() in ↵ | Dries Buytaert | 2006-01-08 |
| | | | | taxonomy_node_get_terms. | ||
* | - Patch #20795 by Steven: improved consistency of the code. | Dries Buytaert | 2006-01-08 |
| |