| Commit message (Collapse) | Author | Age |
|---|
| | |
|
| |
|
|
| |
db_next_id().
|
| | |
|
| |
|
|
|
|
| |
Currently pager_query() is the black sheep of the database query family, because it does not allow for printf-style arguments to be inserted in the query. This is a problem because it introduces developer confusion when moving from an unpaged query to a paged one, and it encourages substitution of variables directly into the query, which can bypass our check_query() security feature.
This patch adds this ability to pager_query(). The change is backwards-compatible, but a couple calls to the function in core have been changed to use the new capability.
|
| | |
|
| |
|
|
|
| |
- #8193: Moving the two instances of the timezone list into a function.
- #3859: Adding drupal_goto for module/theme/settings pages. Aside from general drupal_goto usability, this fixes the bug of menu items not immediately appearing after enabling a module.
|
| | |
|
| | |
|
| |
|
|
| |
else's account.
|
| |
|
|
| |
if "user_register" was set to 0.
|
| | |
|
| |
|
|
| |
by adding a items column to the categories table which acts like the same column in the feeds table.
|
| |
|
|
|
|
|
|
| |
blocks not to render any output. If I create a new menu and menu items, and then enable the block, no output from that block is visible.
This commit fixes the problem: custom menus were being defined as MENU_CUSTOM_ITEM rather than MENU_CUSTOM_MENU. It also fixes a problem in which custom menus were mistakenly given the MENU_VISIBLE_IN_BREADCRUMB bit when edited. This would cause their titles to show up in the breadcrumb (which is undesirable... only menu items should be in there).
Note that this will not fix any non-functioning custom menus you've defined since this bug appeared. You'll have to delete and recreate them or update the "type" column in the DB manually.
|
| |
|
|
| |
page when a user has submitted a comment that goes into the moderation queue. Part of the problem seemed to be that the "your comment is in the moderation queue" message was set as a theme print, as opposed to a drupal_set_message(). This patch fixes that, as well as adding a drupal_goto() to redirect the user back to where they came.
|
| |
|
|
| |
timestamp from {history}" SQL statement is executed multiple times in two different functions. This duplicated code should be placed in a function, and that's been done already with node_last_visited() - the remaining code was just never updated to use the new routine. This patch changes the old code to use node_last_visited, and also modifies node_last_visited() to cache the result of the database call.
|
| |
|
|
|
|
|
|
|
| |
modules (and all occurrances elsewhere) to match their 4.4.x equivalents. In the discussion when these permissions were introduced, it was decided that "edit own ..." was clearer, but "maintain personal ..." slipped into CVS HEAD anyway, while "edit own ..." landed in the 4.4.x branch.
Changes are as follows:
"maintain personal blog" -> "edit own blog" (aggregator.module, blog.module, blogapi.module)
"maintain personal pages" -> "edit own pages" (page.module)
"maintain personal stories" -> "edit own stories (story.module)
|
| |
|
|
|
| |
- Small usability improvement thanks to using drupal_goto() after deleting an
alias.
|
| | |
|
| |
|
|
| |
menu system improvements.
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* improves the doxygentation and help text.
* deletes comment_admin and comment_page; using proper callbacks instead.
* related/modified callbacks/menus/functions were tweaked to not use arg() at all.
* the "settings" subtab was weighted to -10 so it'd appear first (in prep of JonBob's local default).
* moderation pages weren't properly showing defined votes or thresholds; fixed.
* when moderation votes or thresholds didn't exist, no error stating as such was shown; fixed.
* we show "submit votes" on the moderation votes page only when votes actually exist.
* fixes the (broken in CVS) comment/reply and comment/edit features.
* fixes the (broken in CVS) "save settings" for comment view options and comment moderation.
In addition I:
* fixed a couple warnings introduced by Morbus' patch.
* fixed a couple translation bugs.
* fixed comment_node_url().
I also found that:
* the collapsed comment views (i.e. 'threaded list - collapsed) are broken.
|
| | |
|
| |
|
|
| |
module.
|
| |
|
|
| |
pages. Useful to reduce your site's bandwidth.
|
| |
|
|
|
|
|
|
|
| |
forms using the $required argument of the form_ functions.
- Replaced all Optional's and Required's from the taxonomy forms with proper
use of the form_ functions.
Please check your contributed modules too!
|
| | |
|
| |
|
|
| |
- Renamed '... your ...' to '... my ...' (cfr. 'my account).
|
| |
|
|
|
| |
movies) using a comma. Only few users actually read the form description,
it seems ...
|
| |
|
|
|
| |
- Removed left-over instance of theme('error'): error handling is now done by
the form code.
|
| | |
|
| |
|
|
| |
- Made the blog module's submission form mark required form fields.
|
| |
|
|
| |
- Revert patch that accidentically got committed. Thanks jhriggs.
|
| | |
|
| |
|
|
| |
installations where the comment.module is turned on, $comments is never set to 0, and posts that have no comments instead get the value of the last successful comment_num_all. The attached patch corrects this ($comments is set to 0 before we do anything) and also merges the if statements.
|
| |
|
|
| |
later.
|
| |
|
|
| |
little and made the form groups use consistent titles.
|
| |
|
|
| |
'home » administer » settings" page.
|
| | |
|
| |
|
|
|
|
| |
all the commonly used ones, can handle blocks on either side, and there is no way to see the preview without saving and seeing the results on the site.
Anything else that can be removed? Less is more.
|
| |
|
|
| |
not have the 'access users' permission set.
|
| | |
|
| |
|
|
| |
should not be called.
|
| | |
|
| | |
|
| |
|
|
|
| |
- If you are allowed to vote, results are now shown on a separate node tab "node/id/results".
- Poll voting now submits to a separate URL and uses drupal_goto to go back to the poll node
|
| |
|
|
| |
- Updated node.module to use drupal_goto after submission: this allows people to refresh after submission without any problems.
|
| |
|
|
|
|
|
|
| |
system is now using form_set_error() and friends like the rest of Drupal does. This makes for both a consistent user experience and consistent code. It simplifies the forms and validation code, however, it does change the node API slightly:
* The _validate hook and the _nodeapi('validate') hook of the node API (1) no longer take an 'error' parameter and (2) should no longer return an error array. To set an error, call form_set_error().
* The _form hook of the node module no longer takes a form hook and should not worry about displaying errors. Ditto for _nodeapi('form_post') and _nodeapi('form_pre').
|
| | |
|
| |
|
|
|
|
|
| |
* slightly reorders the functions in anticipation of http://drupal.org/node/view/9010.
* reorders help definitions to match the alphabetical nature of the menu items.
* tweaked visual appearance of menu code (whitespace, etc.)
* minor tweaks to "warning" help to match style of others.
|
