| Commit message (Collapse) | Author | Age |
|---|
| |
|
|
|
|
|
|
| |
Again, a nightly commit :) The last one because tomorrow I'll be in bed at a reasonable time since the morning after school starts... I wish they had a pill for _that_ ;) I think it's ready for release. Added more stability concerning the navigation box. It should now handle all possible URL's on a drupal site. To make sure I catch them all I implemented something that check whether a value is not set to one. It is set to one when the URL matches an option in the list. I saw that we also have a ?mod=moderation (which should only be visible to people that are logged in so I couldn't put it in the list standard) and for the rest nodes. Therefore, when in moderation/a node page it displays Moderation/Node in the list, else not. If I didn't do this Main would be set to the default value... we had that problem before... I needed to use $REQUEST_URI for the modules because it gives you the whole URL, $PHP_SELF only gives you a string until the first ? in the URL... This way I couldn't make up whether you were on the diary or book page. (module.php?mod=book and module.php?mod=diary) With a substr($REQUEST_URI,12,9) I could. Dries told me today that $REQUEST_URI isn't as good as $PHP_SELF, but this is an easy way to fix it. Voila I think that's it. (now that I think of it, I don't even have to do a substr() for the book module since there isn't anything that can be put behind it. With diary for example I have to do the substring because things like &op=add can be put behind it, but that's not the case with the book...) After this change I think that everything is fixed. Oh yes I also fixed a rather flagrant allignment bug. I align the big right td centered which would cause the comment's tree to be centered too so there wasn't much left of a tree anymore. ;) Added one table that fixed this. OK, I think the theme is ready for release. The only problem still is the vertical spacer which is fat in NS 4.76. If someone knows why or finds any other bugs in my theme please let me know. But for me, it's finished, until the next block code is stable and released, I'm planning to get rid of the account box too and expand the navigation menu somewhat. with indented options etc... but that's for later... Now I am going to sleep (after some more fixes I already have in mind) Bye!
Jeroen.
(I'm not sending the mail right away, first the fixes.) OK, it's 04.32. I did some other nice thing IMO, but it's not going to work anymore one we have more than 1000 nodes... Ack.. Just click a story or comment somewhere and check out the navigation box... Goodmorning. ;)
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
it now uses the new category code, incl content bindings.
You can setup different "categories" which map on a content
type. Example:
review -> review.module
article -> story.module
column -> story.module
announc. -> story.module
addons -> file.module
themes -> file.module
- "generalised" story.module and book.module's output.
- fixed bug in includes/timer.inc
- fixed glitch in theme example.theme: it said "$how by" but
the variable $how has never been declared.
- added "drupal development settings" to display some timings
- more work on the categories/topics -> does NOT work yet
|
| |
|
|
|
|
| |
OK after a boring family 50 year marriage anniversary (what's the exact word...) of my grand-parents which lasted twelve hours (no computer in the mean time, ack) I got home and stared themeing. All I did in these three hours is fix the navigation box. In the code there was an attribute "selected" set in <option> main of the drop-down list. I copied that from linux.com... But now it seems that the option with selected appears as default in the list. So, when going to account it should be account appearing as default in the drop down list. But we load the same HTML for each page in Drupal. This caused Main to be "selected" for every page we load. That's where the problem was. So, how do we change that... After some time I went to irc.homelien.no #php (cool people by the way) and asked how I could get the URL the browser was currently on. They told me about $REQUEST_URI. OK... REQUEST_URI... Then the standard procedure followed when discovering something new. You tink that it returns the whole URL, but it doesn't only the last significant part (which is a good thing) After finding that out, you wonder why it still doesn't work, and it takes you some more time to find out that you have to globlify the variable $REQUEST_URI if you want to use it. OK, and after that it worked. :) So what I do now for every option in the list is: <?if ($REQUEST_URI == "/index.php") echo "selected"; ?> And this for every page we have. Houston we have a working drop-down list. :) Not only that I found out but also that NS 4.76 can't do CSS good. It just sucks actually, it can't even do a a:hover { color: <?php echo $color; ?> } That's one of the reasons Dries why you didn't notice much. It can't even do a a.active or a.visited either... (40 minutes and a NS 4.76-looking-nice theme later, happy Easter Dries :), it is 03.40, I should really start getting some normal hours again, school starts Tuesday...) OK Dries as you read, I added some twenty <font face="Helvetica">'s in the theme (NS 4.76 didn't seem to be able to do Arial) set the color links differently and hope that you like it a bit. I know the font is still a bit small, but if I do a +1 there it's huge in NS 6.01. But Dries, why don't you just back off from the NS 4.76 (there's a new version 4.77 btw) and get yourself something a bit more recent. You'll be astonished of how beautiful the wired actually is :) There is however still one pain in the ass. I can't the vertical spacer to be only one pixel in width. But I'll manage to get that right to eventually. OK, I am off to bed. Goodnight, and to all of you, a happy Easter (Google's cool too :))
Jeroen.
|
| |
|
|
|
|
|
| |
footer message like a copyright notice. Themes should use this!
- small improvement to example theme
- added theme_footer to theme marvin
- small improvement to database.inc
|
| |
|
|
|
|
|
| |
On a side not, I'm browsing drop.org from a Windows ME computer and came
to the conclusion that only theme UnConeD looks cool, and that the other
themes not 100%. Theme marvin's font seems to be huge and the sideboxes
wrap (which is ugly).
|
| |
|
|
|
|
|
|
| |
I am sorry UnConeD, but I really didn't find the option to commit as binary...
This is the missing square.gif.
Jeroen.
|
| |
|
|
|
|
|
|
|
|
|
| |
This is another version of my theme. I hope things will look better now, allthough UnConeD but also Dries told me that there were no/only one fat border. It was due to the DOCTYPE I added. People at irc.homelien.no #html told me that the doctype _should_ not affect the code, and that the browser _should_ ommit the doctype line. Well it looks like it doesn't always do that. Therefore I commented out <!-- --> the doctype. I don't know if w3 is going to like this but I sure hope so. For the drop down menu at the top. I know that it doesn't work, and it still doesn't I just copy pasted the code from http://linux.com/ but it doesn't seem to work. It doesn't remember the current page. If anyone knows why this would be, make sure to let me know please. They set the variable location to something in the javascript but don't do anything with it... I did a search on the linux.com code and they only use it somewhere at the top (they compare top.location.href with location.href... But I don't know what it means... Even if I copy pasted that part in my code it still didn't work. Therefore, this commit with a drop down menu that works for 95%... *snif*
I added a bit more color, as UnConeD asked with some random stuff too (you know how I love random thingies), and I changed the font-size, but already said that in another mail... All I am looking for now is a logo to go in the upper left corner... I tried some thingies, but really suck at doing logos, not only that but also the HTML didn't want to co-operate.
Jeroen.
P.S.: this can count as a bug report. When clicking a section at the main page it should give you a search of all stories of that section shouldn't it? Well it doesn't do that, nomatter what you click there are never any results...
Oh UnConeD, what do you mean with the td on the left being to wide? It's OK here in linux, it is set to 20%. Maybe you could mail me a little screenshot?
|
| |
|
|
|
|
|
|
|
| |
It's 03.40, I've had enough. HTML sucks big time. Wanna know why? Check out http://php.net and look at their purple 1-pixel-high seperator lines at the top and the bottom. Look at the source, and then look at mine. Tell me what I do wrong. Please please please please. This has been driving me nuts today... So ever fat border you see in my theme should be in fact 1 pixel high. That way it'll look a whole lot nicer. But I just can't do it. So UnConeD or anyone else knows how to? Just let me know please. Every section has it's own color. I have 8 colors at the moment. Comments have not yet been implemented. Just have a look at the main page.
I like this theme a lot more, then the one I committed yesterday, but who knows what I'll think of it tomorrow. Oh by the way, again about the seperator lines. They did seem to work in the theme I sent last night did they? I simply don't get it.
Goodnight,
Jeroen.
|
| |
|
|
|
|
| |
These are some .gifs for a new draft of a theme I tried to make.
Jeroen.
|
| |
|
|
|
|
|
|
|
|
| |
Just a theme... Guess I was kindof bored today and made a theme. I discovered the tags: topmargin="0" leftmargin="0" marginwidth="0" marginheight="0", and thought, well, how about I build a theme around those tags... And so I did. It isn't finished yet. Not even close, but when you add my theme to the array in your_hostname.conf in the includes dir (insert it as the first element, so it'd be the default theme) and load the main page locally on your computer you should see something with the color scheme of the Petit Bateau clothing line for babies. Something without gfx (Yes it sounds weird reading this from Jeroen :)) No subliminal random messages or changing graphics involved. Nothing. I especcially mention the header on the page. It says drop.org in the left upper corner. I don't want a logo there, just the text. Somehow I must find it _cool_ or so, don't know why. Mmm, now that I think of it, I might just make it http://drop.org/ too. Going to try that. Well, it's 01.40 now, I think you'll understand that I didn't really feel like implementing the whole comment function at this time... :) So, there are no comments visible yet. The layout is still crappy, and the links don't have the desired color yet.
Nevertheless, tell me what you think of it. :) Doesn't have to be good opinions. Color schemes are to be discussed, but I must've already adapted to the childish blue I think. So what do we got? A freaky, yet simple design that somehow makes the hair on my butt arise... A stupid color scheme. No graphics. No specials. Boxes only on the left while news on the right (something I haven't seen to much up untill now. Despite all of this I seem to like it :)
Goodnight,
Jeroen.
|
| |
|
|
|
|
| |
Another .gif...
Jeroen.
|
| |
|
|
|
|
| |
Just a .gif that I commit...
Jeroen.
|
| |
|
|
|
|
| |
by (1) adding a few extra features to "easify" navigation and (b)
to start using "status messages" as once suggested on the mailing
list by Jeroen
|
| |
|
|
|
|
| |
I updated my jeroen.theme. Its navigation box on the right is nicer now :), also, in that navigation box, I changed help into handbook. It looked more appropriate.
Jeroen.
|
| |
|
|
|
|
|
|
|
|
| |
- fixed update bug in book.module
- provide a log message when both adding and updating book pages
- all configurable variables are now accessed through "variable_get()":
- rewrote watchdog and submission throttle and removed watchdog.inc
- improved robustness of sections.inc
- imporved story.module
- updated ./database/database.sql
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- removed ban.inc and ban.module and integrated it in account.module
under the name "access control" --> the ban code was not really up
to standard so this has now been dealt with. This refactoring and
reintegration cuts down the code size with 100 lines too. :-)
(The ban.module code was really old and it showed.)
- added node.module and made the other modules reuse some of this
code --> cut down the code size of modules by at least 100 lines
and adds stability.
- added a status() function to admin.php to display a conform status
message where appropriate. See admin.php for usage.
- removed $theme->control() and made comments.inc handle this itself
wrapped in a $theme->box(). No need to clutter the themes with
such complexity --> updated all themes already. :-)
- some small visual changes to some administration pages to be more
consistent across different modules.
|
| | |
|
| | |
|
| | |
|
| |
|
|
| |
"na" appeared when a story didn't have "read more"
|
| |
|
|
|
|
|
| |
(reported by UnConeD)
- added "add node" link to book selection box and made it display the
current location
- removed tabs and whitespaces from themes - done automatically
|
| | |
|
| |
|
|
|
|
| |
lines)
- made node.inc more robust: it should roll-back when something goes
fubar and it should work in subdirectories
|
| | |
|
| |
|
|
| |
it's not 100% stable yet
|
| |
|
|
| |
- tidied up example.theme
|
| |
|
|
| |
(done automatically by my script)
|
| |
|
|
| |
- removed all $story->update related logic - the update field is redundant
|
| |
|
|
| |
- removed all $story->update related logic - the update field is redundant
|
| |
|
|
|
|
| |
I changed cellpadding="0" to cellpadding is="1" in the box function. I saw on http://drop.org/ that the box subjects sticked to the border. This shoud fix it.
Jeroen.
|
| |
|
|
| |
inside stylesheets relative to the page it is in, while IE/Opera resolve them relative to the path of the stylesheet.
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
| |
things are going on here.
|
| |
|
|
| |
Test it out :) (I wouldn't put it on drop.org yet)
|
| | |
|
| |
|
|
| |
- added a small 'info header' in comments... might be better for when we get more themes.
|
| |
|
|
|
| |
- removed the department stuff
- boxed the comment controls
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixed jeroen.theme.
1. comment() function only gets 2 arguments. And as I made example.theme from jeroen.theme I don't see how thread got in there.
2. That must have sneaked in while I stripped down my theme to get to example.theme.
3. Fixed, it was already done in my top-right navigation box, but I must've forgotten it at the bottom.
4. OK, no more variable timestamp but straigt in the code. :)
Jeroen.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Read them carefully because the other theme might need updating too (I
don't think so though). I could only commit it now because I didn't
had the time to write up these comments/remarks yet. So here goes:
1. the comment() function only takes 2 arguments - $thread is no longer
needed and shouldn't be used in the code either.
2. I added 2 COLSPAN's to fix a <TD> problem in the story() function.
3. <A HREF="">home</A> is will not work properly when using drupal in
a subdirectory! Simply use <A HREF="index.php">home</A> instead -
it does matters. ;-)
4. Removed the $timestamp = format_timestamp(...)'s and used them
"directly" just like this is done for format_username and others.
It's generally more consistent now. :-)
|
| |
|
|
|
|
| |
did some stupid things in my previous update. But now it's OK (I did </BR> instead of <BR>.
Jeroen.
|
| |
|
|
|
|
|
| |
OK, this is perfectionism. I had http://jeroen.drop.org/ validated once again, and noticed an error with a </P>, it said that the paragraph wasn't opened. But it occured near a story as we do <P> check_output(story->abstract) </P> I was pretty certain the paragraph was open. :) OK, so it wasn't the theme's fault, neither was it the engine. Then I went to take a look at the actual story and what did I see. It used a BLOCKQUOTE. After deleting the BLOCKQUOTE, messing around with the HTML, trying to insert it again. It always gave me the error when it was inserted... What's my conclusion? BLOCKQUOTE isn't allowed inside a paragraph...
Solution? We could take the option to use the blockquote HTML tag in a story or comment out of drupal. But I really like blockquote. So I now changed <P> check_output(story->abstract) </P> to <BR> check_output(story->abstract) </BR> because, basicly, that does the same thing. I'd advise you to do so too, I might do it for you if you please. Not that I really care about it, but lately we've got some queer w3-lovers on our back. Let's shake them off, allright? ;)
Jeroen.
|
| |
|
|
|
|
|
|
| |
If we're lucky this tiny jeroen.theme update might just save us from 5 HTML 4.01 bugs.
If we're very lucky it'll solve 7.
If we're unlucky only the code has improved.
Jeroen.
|
| |
|
|
|
|
| |
OK and this should be marvin.theme. We gained like 20 lines or so. But there aren't many graphics in marvin and a lot of stuff I'd put on several lines, Dries doesn't. Nevertheless, a good optimalization. Glad Dries came up with this. :)
Jeroen.
|
| |
|
|
|
|
|
| |
OK I fixed UnConeD's theme. Let's hope I didn't break anything. It were 256 lines and now there are 227 left. A save of 30 lines. Not too bad huh?
Let me check Dries' theme now.
Jeroen.
|
| |
|
|
|
|
| |
themes/ and in example/ there should be example.theme
Jeroen.
|
| |
|
|
|
|
|
|
| |
throught w3's HTML validator. Couldn't check it because I don't have any working webspace, so Dries, upload it and I'll check, I am pretty certain that it'll solve a whole lot of errors, since I fixed a bug in story... story being generated about ten times in the HTML code on drop's main page. I expect about 30 errors less...
Jeroen.
P.S.: I don't think I'll get unconed.theme and marvin.theme updated today. But I promise I'll do it tomorrow. Had to go eat with my family, just got back and in 2 hours I am leavin for the movies. Hope you don't mind, but it's always cooler to commit patches closer to the release date... gives you this "rush" feeling. Ahh, deliberately doing stuff on the nick of time... sweet :)
|
