| Commit message (Collapse) | Author | Age |
|---|
| ... | |
| |
|
|
|
|
|
|
| |
improvement to my theme. In one of my unentertained moments I often just browse to drop and stare at my theme for a while. ;) Then I saw that the border around my boxes was 2 pixels wide and grey. Cool. But I thought, let's try it the same way as I do the stories. With a slick 1 pixel wide black border. And so I did. And I admit, it just looks a whole lot better, slicker, smoother, professional. You probably won't notice it at all, and probably no-one would notice. But again, I'd advise you to take a look at http://jeroen.drop.org and look at the boxes before Dries updates these .gifs. Another thing, Unconed, you probably know more or this. What do you think I should use for my images? .gif or .png. What's the advantage of .png, and most of all, is it smaller in size?
Jeroen.
P.S.: another jeroen.theme is coming up. Don't even know what I changed anymore but I changed something...
|
| |
|
|
|
|
| |
I updated some things, remove some PHP lines in the comment function, that I think weren't necessary (did that in the previous commit but forgot to mention it) also I renamed all the PHP?> tags to ?>. I read in the docs at http://php.net that this is the way to go. Also I renamed all <? to <?PHP. I added a BCGOLOR again, so my theme's build up is a little nicer again. Spotted four (yes 4) bugs. I now use regular HTML to assign colors but in abstract and article, the sections were still done the old way. Fixed that now, but left them black. Oh yeah, I fixed that weird rendering of my theme I think Dries was talking about. He didn't exactly mention what was wrong but I assume that it were the links in abstract and article that didn't display at the right of the story. Because I deleted some tables I had to add COLSPAN="2". However, when I loaded my page locally on eden it displayed correct. But when I browsed to drop it didn't (in the same browser) Do you get it? I sure don't. It was the same HTML code, but seems differently parsed when coming from an outside server. Allthough I don't see why Netscape would see apache locally as something different than another one. Nevertheless, I think it's fixed.
Jeroen.
|
| |
|
|
|
|
| |
I tweaked my theme a bit, don't know if it'll help much but I was able to squeeze a table out of abstract and article. So what you'd say? Well, since the abstract function is called for every post on the main page, I thought that it'd improve it a bit. Of course it isn't much but less tables to show the same is always a good thing. Also, due of the deleted table, I could delete some backgrounds (less traffic from the server to the client) and placed them once in a TABLE header. OK, but a cool side-effect is that it's more HTML 4.01 compliant. Because BACKGROUNDs are allowed in TABLEs and I think it's a bit unclear if they can be in TD yes or no. Either way, this brought to my attention that my !DOCTYPE is strict... I started of strict though... But I think it's a better idea to switch to transitional/loose. OK I think that was it... Oh also because of the changed TABLE structure I had to delete some BGCOLORs. Again, it might be a teeny weeny bit faster, but when you see my site being build up it isn't that nice anymore. (bgcolors are displayed faster than backgrounds). Nevertheless its the result that counts not? Let's hope everything still works.
Jeroen.
|
| |
|
|
|
| |
0.5 liter box of Haagen-Dhaz (Belgian Choclate) and [b] my laptop on
my lap for drupal hacking. Life hardly can get any better than this.
|
| |
|
|
|
| |
- small "path"-fix with logo which could have triggered when running
drupal in a subdirectory
|
| |
|
|
|
|
| |
$theme->comment() only takes 2 parameters ever since the comment
system rewrite 2 months ago. Make sure to update your local tree
before you start hacking away on your themes.
|
| | |
|
| | |
|
| |
|
|
| |
(Is your theme 100% translatable or not?)
|
| |
|
|
|
|
| |
- added a couple of missing t() functions
- improved the comments module, fixed the score problem Jeroen
reported earlier -> it's slicker but I hope it won't break anything
|
| |
|
|
|
|
| |
seems to fix a little graphical glitch I somethimes have, but I could've just been lucky too when I reloaded last times. :)
Jeroen.
|
| |
|
|
|
|
| |
Another jeroen.theme commit is coming up since I made some changes to test the gif I changed and didn't undo them.
Jeroen.
|
| |
|
|
|
|
|
|
| |
i did $comment->$subject instead of $comment->subject
Ai ai.
Jeroen.
|
| |
|
|
|
|
|
|
| |
pixels can create something that smooth...". That's why I went down in my .gif archive and smoothed the drop in footerleft.gif, (the pipe with the open end in which you see a drop). It looks better now, maybe you won't see it but I do. :) I have drawn every gif pixelbased and that's why it's difficult to smoothen edges and stuff. I can't work well with the gimp and if you want certain cool effects you have to know how. Since creating a cool effect with the gimp takes like 15 weird tricks and layershuffles and filters and merges and keep transparancies and you don't get any result before you do that final step which suddenly gives you this wonderful thing. I think it's just too hard for me...
Nevertheless, here's the new footerleft.gif, you might want to check out htpp://jeroen.drop.org before Dries loads it up, otherwise you'll probably think I'm crazy :)
Jeroen.
|
| |
|
|
|
|
| |
printed like normal HTML text in the abstracts' and articles' headers...
Jeroen.
|
| |
|
|
|
|
| |
and not uneven as Dries recommended... bah! :)
I also added a small icon (like marvin.theme) to spice it up a bit.
|
| |
|
|
| |
unimplementable in NS) and added a cool icon.gif
|
| |
|
|
|
|
|
|
| |
check failure it got aborted. So here it is in short. I added the translation functionality and fixed a bug that would cause the comment's subjects not to display. Apparantly it's comment->subject instead of just subject. I also wanted to make something in the comment header a bit more clear I already changed some colors but I would want the comment's rating/score to display black. It's grey now and on a grey background it isn't so clear to read (lisible in decent english?). So I added something that I thought would paint it black, but obviously it didn't. It's still grey. I didn't remove the code, it's only two lines, because it also works this way. For the rest I don't think that anything changed.
Jeroen.
P.S.: Dries, I think we can release it tomorrow, but wait and upload it to http://jeroen.drop.org first so I can check. And at noon we'll let it out. It's yearning to, I can here it growl and make roaring noises in my laptop...
|
| |
|
|
|
|
| |
$link) are no longer needed by the engine so I decided to tidy them up -
I recommand you to do same if you feel like it (and if you haven't
already done so).
|
| |
|
|
|
|
|
| |
and (2) being logged out.
(reported by Jeroen)
- themed "Editor's note" in theme marvin.
(reported by Jeroen)
|
| |
|
|
|
|
|
|
| |
OK, now it's finished, really. Fixed a small gfx glitch, and the categories seem to be called sections now...
It's done, and ready for release. Really.
Jeroen.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I placed all the blocks left, regardless if their region was left or right, what I did was this:
theme_blocks("all", $this);
in my left <TD>.
Now I changed it to
theme_block("left", $this);
in the left <TD> and
theme_blocks("right", $this);
in the right. If everything was this easy.
OK, really, this theme is NS4.7 NS4.76 mozilla (but mozilla 0.8 cuz he's buggy as hell with the BACKGROUNDS in TDs) and IE comliant or compatible, whatever it's being called.
Jeroen. -- Happy.
|
| |
|
|
| |
Jeroen.
|
| |
|
|
|
|
|
| |
- improved comment module - code revision
- improved backend module - moreover headlines now work
- (automatically) stripped tabs and trailing whitespaces from
Jeroen's theme.
|
| |
|
|
|
|
|
|
| |
display OK now. For the weird upper-right navigation box Dries, I really wouldn't know what goes wrong. I don't have the problem. Haven't changed a thing on the boxes, My winme's IE doesn't have the problem... Maybe netscape 4.7 just displayed it wrong only once. Try it again, and if it keeps going wrong. I'll download NS 4.7 and will try to fix it. (That'll be my fourth browser then)
Jeroen.
P.S.: I think my theme is completed... Of course the code might need some cleaning up but I think it is ready to be used by droppies without giving away the code. That'll be in the next drupal release.
|
| |
|
|
|
|
| |
create borders around boxes. Nothing has changed with newsmiddle.gif so don't expect the backgrounds behind the stories' titles to differ.
Jeroen.
|
| |
|
|
|
|
|
|
| |
to fix the widths of the boxes on the sides... I don't know if it'll work, and frankly I doubt if it would... Let me elaborate... You know that I have three colums, one for the left boxes, the middle for the stories and one for the right boxes... I didn't provide a width for any of these <TD>s. That's why it chose it's width randomly. Then I set them to these values, respectively 20 60 and 20%. That went OK, but another problem occurred. We only have boxes on the main page. And on the other pages. e.g. faq, submit news, search... we only have the <user>'s account box on the right. This results in a large white border on the left (lost space). That's why I did the following... but I am afraid it won't work... I set the widths to: <no width> 100% 20% So, now, when we have boxes on the left it'll display them, when there aren't any, the middle <TD> will take up the rest op the space, being 100%, it worked fine on my computer with my browsers... But since I use the kind of browser no-one else uses (linux mozilla 0.8 which sucks and linux NS6.01) it is no reference. I would want to stress again that my theme isn't mozilla compatible or how do you say that, in fact it'd better be mozilla isn't jeroen.theme compatible, it's buggy as hell with the backrounds. OK enough for now, let's see if anything good happens to my theme.
Dries, be so kind to get my jeroen.theme working at http://jeroen.drop.org.
Jeroen.
|
| |
|
|
|
|
| |
won't show much different but the ones that know my theme a bit will se a small change. I don't use .gifs anymore to display the borders of the articles e.g. but a table in a table, so you get a small black border. It looks nicer, and you need less .gifs, which is, in my theme an improvement :) I also themed the comments, they weren't yet, and I didn't know it was my thing to do. I still ain't happy with the comment's headers, but it's a start. Just check it out at http://jeroen.drop.org . Things to do, get the footer's navigation bar display nicely and find a better way to display the comment's header. Nevertheless I think it's doable. It's 01.40 now I think I'm going to sleep. But first commit and delete some .gifs from zind.net.
Jeroen.
|
| | |
|
| | |
|
| |
|
|
| |
- removed tabs from Jeroen's theme
|
| |
|
|
|
|
|
|
|
| |
work now.
It's ready for public release and can be added the the drupal CVS releases. First however, make sure you check htpp://jeroen.drop.org first and let me know if you find any more bugs. I still have to change a bit one a .gif before my footer is correct but that won't be a problem.
And thanks to Dries for solving some theme-problems.
Jeroen
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
|
| |
"minor" box-gfx glitches, about which I will talk to Dries cuz I got them away, but then something else went wrong. It's an IMG vs. BACKGROUND thing. And if you click a read more link, I got some error in include.inc of which I don't I can help it... Well, apart from that everything should work. So try out http://jeroen.drop.org and let me know if anything weird happens...
Jeroen.
|
| |
|
|
|
|
| |
after nothing but code.
This time I redid the "category"-stuff. Categories - from now on called sections - are now maintained from the admin pages, can have their own post, dump and timout thresholds as discussed earlier (some weeks ago). By tomorrow evening users will be able to enable or disable section as well - i.e. to customize the content of drop.org.
|
| |
|
|
| |
enhancements
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
though but I think this is stable enough for public consumption and
real-life testing.
==> a first big step towards a flexible comment engine.
IMPORTANT:
- Required theme updatins:
UnConeD: check your $theme->controls() as I added a very, very
dummy implementation
- Required database updates:
alter table users modify mode tinyint(1) DEFAULT '' NOT NULL;
alter table comments change sid lid int(6) DEFAULT '0' NOT NULL;
alter table comments add link varchar(16) DEFAULT '' NOT NULL;
update comments set link = 'story';
|
| | |
|
| |
|
|
|
|
|
|
| |
it looks real buggy, at least in mozilla, so if you could (you don't have to) have a look at it in your own... I also indented differently, on one space but two each time I needed to indent. I thought it'd make it somewhat clearer with such a complicated/tabled theme as mine. Also when opening PHP I put the <? and ?> tags at the beginning of a new line. Again to make it more clear. All I have to do now it get the looks of the theme right. But do have a look at it.
Jeroen.
P.S.: I might even get this thing finished, imagine that. :)
|
| | |
|
| |
|
|
|
|
|
| |
IMPORTANT: you have to drop 2 tables "blocks" and "layout"
and you have to recreate them again with those
in database/database.mysql
- integrated the documentation written by UnConeD
|
| |
|
|
|
|
|
|
|
|
|
| |
integrated them were appropriate. It works better and the code is
more readable then it used to be:
(see http://drop.org/discussion.php?id=44&pid=0#0)
- story authors can no longer moderate their own stories
(requested by Natrak)
- fix inie-winnie small detail in theme marvin
|
| |
|
|
|
|
| |
jeroen everything should be back in order. I don't think it would be a good idea to remove all of Jeroen and commit all of jeroen, would it. :)
Now you can release rc2. :)
|
| |
|
|
|
|
|
|
| |
screenshot to all of you seperately, maybe you could just add a line for my theme in your <hostname>.conf and test it. This for example:
"Jeroen" => array(
"themes/jeroen/jeroen.theme",
"piped theme, grey/rusty, pretty nifty"));
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- configuration:
+ renamed $db_name to $db_user
+ renamed $db_base to $db_name
- fixed small diary glitch
- fixed initial-comment-score problem
- fixed comment rating bug: improved the API and updated the
themes
- removed some tabs from Steven ;)
- fixed backend warnings and improved robustness
I'm not happy yet with the headline grabber - it generates
too many SQL errors.
- some small cosmetic changes in comment.module
- fixed minor glitch in format_interval()
|
| | |
|
