From f7cf579dfb85ffb21f7870ef1c73aec4147127f9 Mon Sep 17 00:00:00 2001 From: David Rothstein Date: Mon, 3 Nov 2014 01:16:11 -0500 Subject: Issue #1069152 by droplet, alexandrezia, Mixologic, jhedstrom | ogi: Fixed Throbber in textfield is often misaligned. --- CHANGELOG.txt | 2 ++ misc/throbber-active.gif | Bin 0 -> 1233 bytes misc/throbber-inactive.png | Bin 0 -> 320 bytes modules/system/system.base-rtl.css | 4 ++-- modules/system/system.base.css | 9 +++++---- themes/bartik/css/style.css | 8 -------- themes/seven/style.css | 7 +------ 7 files changed, 10 insertions(+), 20 deletions(-) create mode 100644 misc/throbber-active.gif create mode 100644 misc/throbber-inactive.png diff --git a/CHANGELOG.txt b/CHANGELOG.txt index c332da2d5..acdf79bd0 100644 --- a/CHANGELOG.txt +++ b/CHANGELOG.txt @@ -1,6 +1,8 @@ Drupal 7.33, xxxx-xx-xx (development version) ----------------------- +- Fixed a bug which caused the Ajax progress throbber to appear misaligned in + many situatons (minor styling change). - Prevented the Bartik theme from lower-casing the "Permalink" link on comments, for improved multilingual support (minor UI change). - Added a "preferred_menu_links" tag to the database query that is used by diff --git a/misc/throbber-active.gif b/misc/throbber-active.gif new file mode 100644 index 000000000..f88bfdeb7 Binary files /dev/null and b/misc/throbber-active.gif differ diff --git a/misc/throbber-inactive.png b/misc/throbber-inactive.png new file mode 100644 index 000000000..f91466711 Binary files /dev/null and b/misc/throbber-inactive.png differ diff --git a/modules/system/system.base-rtl.css b/modules/system/system.base-rtl.css index 075cafec2..79d6302d7 100644 --- a/modules/system/system.base-rtl.css +++ b/modules/system/system.base-rtl.css @@ -9,10 +9,10 @@ */ /* Animated throbber */ html.js input.form-autocomplete { - background-position: 0% 2px; + background-position: 0% center; } html.js input.throbbing { - background-position: 0% -18px; + background-position: 0% center; } /** diff --git a/modules/system/system.base.css b/modules/system/system.base.css index 412b18a82..7e9220da0 100644 --- a/modules/system/system.base.css +++ b/modules/system/system.base.css @@ -31,12 +31,13 @@ } /* Animated throbber */ html.js input.form-autocomplete { - background-image: url(../../misc/throbber.gif); - background-position: 100% 2px; /* LTR */ + background-image: url(../../misc/throbber-inactive.png); + background-position: 100% center; /* LTR */ background-repeat: no-repeat; } html.js input.throbbing { - background-position: 100% -18px; /* LTR */ + background-image: url(../../misc/throbber-active.gif); + background-position: 100% center; /* LTR */ } /** @@ -164,7 +165,7 @@ table.sticky-header { display: inline-block; } .ajax-progress .throbber { - background: transparent url(../../misc/throbber.gif) no-repeat 0px -18px; + background: transparent url(../../misc/throbber-active.gif) no-repeat 0px center; float: left; /* LTR */ height: 15px; margin: 2px; diff --git a/themes/bartik/css/style.css b/themes/bartik/css/style.css index 1e63cbe88..8426e56ce 100644 --- a/themes/bartik/css/style.css +++ b/themes/bartik/css/style.css @@ -1325,14 +1325,6 @@ input.form-button-disabled:active, color: #717171; } -/* Animated throbber */ -html.js input.form-autocomplete { - background-position: 100% 4px; /* LTR */ -} -html.js input.throbbing { - background-position: 100% -16px; /* LTR */ -} - /* Comment form */ .comment-form label { float: left; /* LTR */ diff --git a/themes/seven/style.css b/themes/seven/style.css index 56a6094f4..c52d661d0 100644 --- a/themes/seven/style.css +++ b/themes/seven/style.css @@ -709,12 +709,7 @@ select.form-select:focus { color: #000; border-color: #ace; } -html.js input.form-autocomplete { - background-position: 100% 4px; -} -html.js input.throbbing { - background-position: 100% -16px; -} + ul.action-links { margin: 1em 0; padding: 0 20px 0 20px; /* LTR */ -- cgit v1.2.3