From 07886a84821909a48dd40819a9584aa7f483dfe0 Mon Sep 17 00:00:00 2001 From: Dries Buytaert Date: Sat, 25 Sep 2010 01:41:26 +0000 Subject: - Patch #921582 by munzirtaha: is_null() should be replaced by !isset because it's faster. --- includes/database/mysql/schema.inc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'includes/database/mysql') diff --git a/includes/database/mysql/schema.inc b/includes/database/mysql/schema.inc index 1712ca2a4..cba41eb5f 100644 --- a/includes/database/mysql/schema.inc +++ b/includes/database/mysql/schema.inc @@ -156,7 +156,7 @@ class DatabaseSchema_mysql extends DatabaseSchema { if (is_string($spec['default'])) { $spec['default'] = "'" . $spec['default'] . "'"; } - elseif (is_null($spec['default'])) { + elseif (!isset($spec['default'])) { $spec['default'] = 'NULL'; } $sql .= ' DEFAULT ' . $spec['default']; @@ -351,7 +351,7 @@ class DatabaseSchema_mysql extends DatabaseSchema { throw new DatabaseSchemaObjectDoesNotExistException(t("Cannot set default value of field %table.%field: field doesn't exist.", array('%table' => $table, '%field' => $field))); } - if (is_null($default)) { + if (!isset($default)) { $default = 'NULL'; } else { -- cgit v1.2.3