From 07886a84821909a48dd40819a9584aa7f483dfe0 Mon Sep 17 00:00:00 2001 From: Dries Buytaert Date: Sat, 25 Sep 2010 01:41:26 +0000 Subject: - Patch #921582 by munzirtaha: is_null() should be replaced by !isset because it's faster. --- includes/database/sqlite/database.inc | 2 +- includes/database/sqlite/query.inc | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) (limited to 'includes/database/sqlite') diff --git a/includes/database/sqlite/database.inc b/includes/database/sqlite/database.inc index 4b7aaa620..476876d3e 100644 --- a/includes/database/sqlite/database.inc +++ b/includes/database/sqlite/database.inc @@ -82,7 +82,7 @@ class DatabaseConnection_sqlite extends DatabaseConnection { public function sqlFunctionGreatest() { $args = func_get_args(); foreach ($args as $k => $v) { - if (is_null($v)) { + if (!isset($v)) { unset($args); } } diff --git a/includes/database/sqlite/query.inc b/includes/database/sqlite/query.inc index c79da0328..ec2b57a2c 100644 --- a/includes/database/sqlite/query.inc +++ b/includes/database/sqlite/query.inc @@ -110,7 +110,7 @@ class UpdateQuery_sqlite extends UpdateQuery { $condition->condition($field, $data['expression'], '<>'); $condition->isNull($field); } - elseif (is_null($data)) { + elseif (!isset($data)) { // The field will be set to NULL. $condition->isNull($field); } -- cgit v1.2.3