From 3213087441874cf2ad3392aa935fc8728d5955a3 Mon Sep 17 00:00:00 2001 From: Dries Buytaert Date: Sun, 8 Nov 2009 19:53:19 +0000 Subject: - Patch #623992 by sun: fixed the tests. We can re-enable the test bot now. --- includes/form.inc | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) (limited to 'includes/form.inc') diff --git a/includes/form.inc b/includes/form.inc index 9bf1ea841..7ddd6125d 100644 --- a/includes/form.inc +++ b/includes/form.inc @@ -832,7 +832,10 @@ function _form_validate($elements, &$form_state, $form_id = NULL) { // checkboxes, can return a valid value of '0'. Instead, check the // length if it's a string, and the item count if it's an array. if ($elements['#required'] && (!count($elements['#value']) || (is_string($elements['#value']) && strlen(trim($elements['#value'])) == 0))) { - form_error($elements, $t('!name field is required.', array('!name' => $elements['#title']))); + form_error($elements, $t('!name field is required.', array( + '!field_id' => $elements['#id'], + '!name' => $elements['#title'], + ))); } // Verify that the value is not longer than #maxlength. @@ -2762,14 +2765,21 @@ function theme_form_element($variables) { $output = '
' . "\n"; $required = !empty($element['#required']) ? theme('form_required_marker', array('element' => $element)) : ''; + $error = ''; + if (!empty($element['#required']) && empty($element['#value'])) { + $error = form_get_error($element) ? '' . $t('Field is required.') . '' : ''; + } + else { + $error = form_get_error($element) ? '' . filter_xss_admin(form_get_error($element)) . '' : ''; + } if (!empty($element['#title']) && empty($element['#form_element_skip_title'])) { $title = $element['#title']; if (!empty($element['#id'])) { - $output .= ' \n"; + $output .= ' \n"; } else { - $output .= ' \n"; + $output .= ' \n"; } } -- cgit v1.2.3