From 480a2daf4e2f73aaafefdeef616d912ea28ca7c6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?G=C3=A1bor=20Hojtsy?= Date: Mon, 19 Nov 2007 19:53:51 +0000 Subject: #193580 by chx: given recent improvements, Drupal does not require CREATE TEMPORARY TABLE and LOCK TABLES permissions, so do not check on install and do not advise people giving these rights --- includes/install.mysql.inc | 24 +----------------------- includes/install.mysqli.inc | 24 +----------------------- 2 files changed, 2 insertions(+), 46 deletions(-) (limited to 'includes') diff --git a/includes/install.mysql.inc b/includes/install.mysql.inc index 2b111f482..a6ebca079 100644 --- a/includes/install.mysql.inc +++ b/includes/install.mysql.inc @@ -86,28 +86,6 @@ function drupal_test_mysql($url, &$success) { $success[] = 'UPDATE'; } - // Test LOCK. - $query = 'LOCK TABLES drupal_install_test WRITE'; - $result = mysql_query($query); - if ($error = mysql_error()) { - drupal_set_message(st('Failed to lock a test table on your MySQL database server. We tried locking a table with the command %query and MySQL reported the following error: %error.', array('%query' => $query, '%error' => $error)), 'error'); - $err = TRUE; - } - else { - $success[] = 'LOCK'; - } - - // Test UNLOCK. - $query = 'UNLOCK TABLES'; - $result = mysql_query($query); - if ($error = mysql_error()) { - drupal_set_message(st('Failed to unlock a test table on your MySQL database server. We tried unlocking a table with the command %query and MySQL reported the following error: %error.', array('%query' => $query, '%error' => $error)), 'error'); - $err = TRUE; - } - else { - $success[] = 'UNLOCK'; - } - // Test DELETE. $query = 'DELETE FROM drupal_install_test'; $result = mysql_query($query); @@ -136,4 +114,4 @@ function drupal_test_mysql($url, &$success) { mysql_close($connection); return TRUE; -} \ No newline at end of file +} diff --git a/includes/install.mysqli.inc b/includes/install.mysqli.inc index f1eb23558..1a73ad292 100644 --- a/includes/install.mysqli.inc +++ b/includes/install.mysqli.inc @@ -81,28 +81,6 @@ function drupal_test_mysqli($url, &$success) { $success[] = 'UPDATE'; } - // Test LOCK. - $query = 'LOCK TABLES drupal_install_test WRITE'; - $result = mysqli_query($connection, $query); - if ($error = mysqli_error($connection)) { - drupal_set_message(st('Failed to lock a test table on your MySQL database server. We tried locking a table with the command %query and MySQL reported the following error: %error.', array('%query' => $query, '%error' => $error)), 'error'); - $err = TRUE; - } - else { - $success[] = 'LOCK'; - } - - // Test UNLOCK. - $query = 'UNLOCK TABLES'; - $result = mysqli_query($connection, $query); - if ($error = mysqli_error($connection)) { - drupal_set_message(st('Failed to unlock a test table on your MySQL database server. We tried unlocking a table with the command %query and MySQL reported the following error: %error.', array('%query' => $query, '%error' => $error)), 'error'); - $err = TRUE; - } - else { - $success[] = 'UNLOCK'; - } - // Test DELETE. $query = 'DELETE FROM drupal_install_test'; $result = mysqli_query($connection, $query); @@ -131,4 +109,4 @@ function drupal_test_mysqli($url, &$success) { mysqli_close($connection); return TRUE; -} \ No newline at end of file +} -- cgit v1.2.3