From 55018d34e910a236f409c4d91fb05a1fe4ef5f87 Mon Sep 17 00:00:00 2001 From: Dries Buytaert Date: Sat, 5 Jul 2008 18:34:29 +0000 Subject: - Patch #257537 by dopry: made file_check_directory less verbose on success. --- includes/file.inc | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) (limited to 'includes') diff --git a/includes/file.inc b/includes/file.inc index 2de64c10b..ef9989500 100644 --- a/includes/file.inc +++ b/includes/file.inc @@ -139,12 +139,12 @@ function file_check_directory(&$directory, $mode = 0, $form_item = NULL) { // Check if directory exists. if (!is_dir($directory)) { if (($mode & FILE_CREATE_DIRECTORY) && @mkdir($directory)) { - drupal_set_message(t('The directory %directory has been created.', array('%directory' => $directory))); @chmod($directory, 0775); // Necessary for non-webserver users. } else { if ($form_item) { form_set_error($form_item, t('The directory %directory does not exist.', array('%directory' => $directory))); + watchdog('file system', 'The directory %directory does not exist.', array('%directory' => $directory), WATCHDOG_ERROR); } return FALSE; } @@ -152,10 +152,7 @@ function file_check_directory(&$directory, $mode = 0, $form_item = NULL) { // Check to see if the directory is writable. if (!is_writable($directory)) { - if (($mode & FILE_MODIFY_PERMISSIONS) && @chmod($directory, 0775)) { - drupal_set_message(t('The permissions of directory %directory have been changed to make it writable.', array('%directory' => $directory))); - } - else { + if (($mode & FILE_MODIFY_PERMISSIONS) && !@chmod($directory, 0775)) { form_set_error($form_item, t('The directory %directory is not writable', array('%directory' => $directory))); watchdog('file system', 'The directory %directory is not writable, because it does not have the correct permissions set.', array('%directory' => $directory), WATCHDOG_ERROR); return FALSE; -- cgit v1.2.3