From 725481d71ba1151101b6a4f518cfeaf230d88bcc Mon Sep 17 00:00:00 2001 From: Dries Buytaert Date: Wed, 19 May 2010 19:22:24 +0000 Subject: - Patch #768490 by JohnAlbin, sign: theme_table_select_header_cell() is not really a theme function. --- includes/common.inc | 3 --- includes/form.inc | 6 ++++-- includes/theme.inc | 12 ------------ 3 files changed, 4 insertions(+), 17 deletions(-) (limited to 'includes') diff --git a/includes/common.inc b/includes/common.inc index 0190d189a..0f93e34da 100644 --- a/includes/common.inc +++ b/includes/common.inc @@ -5537,9 +5537,6 @@ function drupal_common_theme() { 'table' => array( 'variables' => array('header' => NULL, 'rows' => NULL, 'attributes' => array(), 'caption' => NULL, 'colgroups' => array(), 'sticky' => TRUE, 'empty' => ''), ), - 'table_select_header_cell' => array( - 'variables' => array(), - ), 'tablesort_indicator' => array( 'variables' => array('style' => NULL), ), diff --git a/includes/form.inc b/includes/form.inc index affd82b0e..68f24f65c 100644 --- a/includes/form.inc +++ b/includes/form.inc @@ -2542,8 +2542,10 @@ function theme_tableselect($variables) { } // Add an empty header or a "Select all" checkbox to provide room for the // checkboxes/radios in the first table column. - $first_col = $element['#js_select'] ? array(theme('table_select_header_cell')) : array(''); - $header = array_merge($first_col, $header); + if ($element['#js_select']) { + drupal_add_js('misc/tableselect.js'); + array_unshift($header, array('class' => array('select-all'))); + } } return theme('table', array('header' => $header, 'rows' => $rows, 'empty' => $element['#empty'], 'attributes' => $element['#attributes'])); } diff --git a/includes/theme.inc b/includes/theme.inc index 7ddba732b..705ba1328 100644 --- a/includes/theme.inc +++ b/includes/theme.inc @@ -1743,18 +1743,6 @@ function theme_table($variables) { return $output; } -/** - * Returns attributes for a header cell of tables with select all functionality. - * - * @return - * An array of attributes. - */ -function theme_table_select_header_cell() { - drupal_add_js('misc/tableselect.js'); - - return array('class' => array('select-all')); -} - /** * Returns HTML for a sort icon. * -- cgit v1.2.3