From 476843c25e4da2ac1c6c375b2ee6e2c0f97275ff Mon Sep 17 00:00:00 2001 From: webchick Date: Tue, 14 Feb 2012 13:46:20 -0500 Subject: Issue #1346914 by droplet: Use .length instead of jQuery.size(). --- misc/tabledrag.js | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) (limited to 'misc/tabledrag.js') diff --git a/misc/tabledrag.js b/misc/tabledrag.js index 41fd47b6e..0461491f2 100644 --- a/misc/tabledrag.js +++ b/misc/tabledrag.js @@ -123,7 +123,7 @@ Drupal.tableDrag.prototype.initColumns = function () { // Find the first field in this group. for (var d in this.tableSettings[group]) { var field = $('.' + this.tableSettings[group][d].target + ':first', this.table); - if (field.size() && this.tableSettings[group][d].hidden) { + if (field.length && this.tableSettings[group][d].hidden) { var hidden = this.tableSettings[group][d].hidden; var cell = field.parents('td:first'); break; @@ -256,7 +256,7 @@ Drupal.tableDrag.prototype.makeDraggable = function (item) { if ($('td:first .indentation:last', item).length) { $('td:first .indentation:last', item).after(handle); // Update the total width of indentation in this entire table. - self.indentCount = Math.max($('.indentation', item).size(), self.indentCount); + self.indentCount = Math.max($('.indentation', item).length, self.indentCount); } else { $('td:first', item).prepend(handle); @@ -362,7 +362,7 @@ Drupal.tableDrag.prototype.makeDraggable = function (item) { if ($(item).is('.tabledrag-root')) { // Swap with the previous top-level row. var groupHeight = 0; - while (previousRow && $('.indentation', previousRow).size()) { + while (previousRow && $('.indentation', previousRow).length) { previousRow = $(previousRow).prev('tr').get(0); groupHeight += $(previousRow).is(':hidden') ? 0 : previousRow.offsetHeight; } @@ -688,7 +688,7 @@ Drupal.tableDrag.prototype.updateField = function (changedRow, group) { var sourceRow = changedRow; if ($(previousRow).is('.draggable') && $('.' + group, previousRow).length) { if (this.indentEnabled) { - if ($('.indentations', previousRow).size() == $('.indentations', changedRow)) { + if ($('.indentations', previousRow).length == $('.indentations', changedRow)) { sourceRow = previousRow; } } @@ -698,7 +698,7 @@ Drupal.tableDrag.prototype.updateField = function (changedRow, group) { } else if ($(nextRow).is('.draggable') && $('.' + group, nextRow).length) { if (this.indentEnabled) { - if ($('.indentations', nextRow).size() == $('.indentations', changedRow)) { + if ($('.indentations', nextRow).length == $('.indentations', changedRow)) { sourceRow = nextRow; } } @@ -754,7 +754,7 @@ Drupal.tableDrag.prototype.updateField = function (changedRow, group) { switch (rowSettings.action) { case 'depth': // Get the depth of the target row. - targetElement.value = $('.indentation', $(sourceElement).parents('tr:first')).size(); + targetElement.value = $('.indentation', $(sourceElement).parents('tr:first')).length; break; case 'match': // Update the value. @@ -884,7 +884,7 @@ Drupal.tableDrag.prototype.row = function (tableRow, method, indentEnabled, maxD this.element = tableRow; this.method = method; this.group = [tableRow]; - this.groupDepth = $('.indentation', tableRow).size(); + this.groupDepth = $('.indentation', tableRow).length; this.changed = false; this.table = $(tableRow).parents('table:first').get(0); this.indentEnabled = indentEnabled; @@ -892,12 +892,12 @@ Drupal.tableDrag.prototype.row = function (tableRow, method, indentEnabled, maxD this.direction = ''; // Direction the row is being moved. if (this.indentEnabled) { - this.indents = $('.indentation', tableRow).size(); + this.indents = $('.indentation', tableRow).length; this.children = this.findChildren(addClasses); this.group = $.merge(this.group, this.children); // Find the depth of this entire group. for (var n = 0; n < this.group.length; n++) { - this.groupDepth = Math.max($('.indentation', this.group[n]).size(), this.groupDepth); + this.groupDepth = Math.max($('.indentation', this.group[n]).length, this.groupDepth); } } }; @@ -1009,7 +1009,7 @@ Drupal.tableDrag.prototype.row.prototype.validIndentInterval = function (prevRow // Minimum indentation: // Do not orphan the next row. - minIndent = nextRow ? $('.indentation', nextRow).size() : 0; + minIndent = nextRow ? $('.indentation', nextRow).length : 0; // Maximum indentation: if (!prevRow || $(prevRow).is(':not(.draggable)') || $(this.element).is('.tabledrag-root')) { @@ -1021,7 +1021,7 @@ Drupal.tableDrag.prototype.row.prototype.validIndentInterval = function (prevRow } else { // Do not go deeper than as a child of the previous row. - maxIndent = $('.indentation', prevRow).size() + ($(prevRow).is('.tabledrag-leaf') ? 0 : 1); + maxIndent = $('.indentation', prevRow).length + ($(prevRow).is('.tabledrag-leaf') ? 0 : 1); // Limit by the maximum allowed depth for the table. if (this.maxDepth) { maxIndent = Math.min(maxIndent, this.maxDepth - (this.groupDepth - this.indents)); -- cgit v1.2.3