From 30fab7007d575850b9176e926a38726a02a1d0af Mon Sep 17 00:00:00 2001 From: Jennifer Hodgdon Date: Thu, 18 Oct 2012 16:04:59 -0700 Subject: Issue #1741338 by lazysoundsystem: Remove t() from test asserts in block module --- modules/block/block.test | 130 +++++++++++++++++++++++------------------------ 1 file changed, 65 insertions(+), 65 deletions(-) (limited to 'modules/block') diff --git a/modules/block/block.test b/modules/block/block.test index 8e6e47042..11d070993 100644 --- a/modules/block/block.test +++ b/modules/block/block.test @@ -45,9 +45,9 @@ class BlockTestCase extends DrupalWebTestCase { function testCustomBlock() { // Confirm that the add block link appears on block overview pages. $this->drupalGet('admin/structure/block'); - $this->assertRaw(l('Add block', 'admin/structure/block/add'), t('Add block link is present on block overview page for default theme.')); + $this->assertRaw(l('Add block', 'admin/structure/block/add'), 'Add block link is present on block overview page for default theme.'); $this->drupalGet('admin/structure/block/list/seven'); - $this->assertRaw(l('Add block', 'admin/structure/block/list/seven/add'), t('Add block link is present on block overview page for non-default theme.')); + $this->assertRaw(l('Add block', 'admin/structure/block/list/seven/add'), 'Add block link is present on block overview page for non-default theme.'); // Confirm that hidden regions are not shown as options for block placement // when adding a new block. @@ -58,7 +58,7 @@ class BlockTestCase extends DrupalWebTestCase { if ($theme->status) { foreach ($theme->info['regions_hidden'] as $hidden_region) { $elements = $this->xpath('//select[@id=:id]//option[@value=:value]', array(':id' => 'edit-regions-' . $key, ':value' => $hidden_region)); - $this->assertFalse(isset($elements[0]), t('The hidden region @region is not available for @theme.', array('@region' => $hidden_region, '@theme' => $key))); + $this->assertFalse(isset($elements[0]), format_string('The hidden region @region is not available for @theme.', array('@region' => $hidden_region, '@theme' => $key))); } } } @@ -71,17 +71,17 @@ class BlockTestCase extends DrupalWebTestCase { $this->drupalPost('admin/structure/block/add', $custom_block, t('Save block')); // Confirm that the custom block has been created, and then query the created bid. - $this->assertText(t('The block has been created.'), t('Custom block successfully created.')); + $this->assertText(t('The block has been created.'), 'Custom block successfully created.'); $bid = db_query("SELECT bid FROM {block_custom} WHERE info = :info", array(':info' => $custom_block['info']))->fetchField(); // Check to see if the custom block was created by checking that it's in the database. - $this->assertNotNull($bid, t('Custom block found in database')); + $this->assertNotNull($bid, 'Custom block found in database'); // Check that block_block_view() returns the correct title and content. $data = block_block_view($bid); $format = db_query("SELECT format FROM {block_custom} WHERE bid = :bid", array(':bid' => $bid))->fetchField(); - $this->assertTrue(array_key_exists('subject', $data) && empty($data['subject']), t('block_block_view() provides an empty block subject, since custom blocks do not have default titles.')); - $this->assertEqual(check_markup($custom_block['body[value]'], $format), $data['content'], t('block_block_view() provides correct block content.')); + $this->assertTrue(array_key_exists('subject', $data) && empty($data['subject']), 'block_block_view() provides an empty block subject, since custom blocks do not have default titles.'); + $this->assertEqual(check_markup($custom_block['body[value]'], $format), $data['content'], 'block_block_view() provides correct block content.'); // Check whether the block can be moved to all available regions. $custom_block['module'] = 'block'; @@ -92,8 +92,8 @@ class BlockTestCase extends DrupalWebTestCase { // Verify presence of configure and delete links for custom block. $this->drupalGet('admin/structure/block'); - $this->assertLinkByHref('admin/structure/block/manage/block/' . $bid . '/configure', 0, t('Custom block configure link found.')); - $this->assertLinkByHref('admin/structure/block/manage/block/' . $bid . '/delete', 0, t('Custom block delete link found.')); + $this->assertLinkByHref('admin/structure/block/manage/block/' . $bid . '/configure', 0, 'Custom block configure link found.'); + $this->assertLinkByHref('admin/structure/block/manage/block/' . $bid . '/delete', 0, 'Custom block delete link found.'); // Set visibility only for authenticated users, to verify delete functionality. $edit = array(); @@ -103,10 +103,10 @@ class BlockTestCase extends DrupalWebTestCase { // Delete the created custom block & verify that it's been deleted and no longer appearing on the page. $this->clickLink(t('delete')); $this->drupalPost('admin/structure/block/manage/block/' . $bid . '/delete', array(), t('Delete')); - $this->assertRaw(t('The block %title has been removed.', array('%title' => $custom_block['info'])), t('Custom block successfully deleted.')); - $this->assertNoText(t($custom_block['title']), t('Custom block no longer appears on page.')); + $this->assertRaw(t('The block %title has been removed.', array('%title' => $custom_block['info'])), 'Custom block successfully deleted.'); + $this->assertNoText(t($custom_block['title']), 'Custom block no longer appears on page.'); $count = db_query("SELECT 1 FROM {block_role} WHERE module = :module AND delta = :delta", array(':module' => $custom_block['module'], ':delta' => $custom_block['delta']))->fetchField(); - $this->assertFalse($count, t('Table block_role being cleaned.')); + $this->assertFalse($count, 'Table block_role being cleaned.'); } /** @@ -130,20 +130,20 @@ class BlockTestCase extends DrupalWebTestCase { // Confirm that the custom block is being displayed using configured text format. $this->drupalGet('node'); - $this->assertRaw('

Full HTML

', t('Custom block successfully being displayed using Full HTML.')); + $this->assertRaw('

Full HTML

', 'Custom block successfully being displayed using Full HTML.'); // Confirm that a user without access to Full HTML can not see the body field, // but can still submit the form without errors. $block_admin = $this->drupalCreateUser(array('administer blocks')); $this->drupalLogin($block_admin); $this->drupalGet('admin/structure/block/manage/block/' . $bid . '/configure'); - $this->assertFieldByXPath("//textarea[@name='body[value]' and @disabled='disabled']", t('This field has been disabled because you do not have sufficient permissions to edit it.'), t('Body field contains denied message')); + $this->assertFieldByXPath("//textarea[@name='body[value]' and @disabled='disabled']", t('This field has been disabled because you do not have sufficient permissions to edit it.'), 'Body field contains denied message'); $this->drupalPost('admin/structure/block/manage/block/' . $bid . '/configure', array(), t('Save block')); $this->assertNoText(t('Ensure that each block description is unique.')); // Confirm that the custom block is still being displayed using configured text format. $this->drupalGet('node'); - $this->assertRaw('

Full HTML

', t('Custom block successfully being displayed using Full HTML.')); + $this->assertRaw('

Full HTML

', 'Custom block successfully being displayed using Full HTML.'); } /** @@ -178,18 +178,18 @@ class BlockTestCase extends DrupalWebTestCase { $this->moveBlockToRegion($block, $this->regions[1]); $this->drupalGet(''); - $this->assertText($title, t('Block was displayed on the front page.')); + $this->assertText($title, 'Block was displayed on the front page.'); $this->drupalGet('user'); - $this->assertNoText($title, t('Block was not displayed according to block visibility rules.')); + $this->assertNoText($title, 'Block was not displayed according to block visibility rules.'); $this->drupalGet('USER/' . $this->admin_user->uid); - $this->assertNoText($title, t('Block was not displayed according to block visibility rules regardless of path case.')); + $this->assertNoText($title, 'Block was not displayed according to block visibility rules regardless of path case.'); // Confirm that the block is not displayed to anonymous users. $this->drupalLogout(); $this->drupalGet(''); - $this->assertNoText($title, t('Block was not displayed to anonymous users.')); + $this->assertNoText($title, 'Block was not displayed to anonymous users.'); } /** @@ -224,15 +224,15 @@ class BlockTestCase extends DrupalWebTestCase { $this->drupalPost('admin/structure/block/manage/' . $block['module'] . '/' . $block['delta'] . '/configure', $edit, t('Save block')); $this->drupalGet(''); - $this->assertNoText($title, t('Block was not displayed according to block visibility rules.')); + $this->assertNoText($title, 'Block was not displayed according to block visibility rules.'); $this->drupalGet('user'); - $this->assertNoText($title, t('Block was not displayed according to block visibility rules regardless of path case.')); + $this->assertNoText($title, 'Block was not displayed according to block visibility rules regardless of path case.'); // Confirm that the block is not displayed to anonymous users. $this->drupalLogout(); $this->drupalGet(''); - $this->assertNoText($title, t('Block was not displayed to anonymous users.')); + $this->assertNoText($title, 'Block was not displayed to anonymous users.'); } /** @@ -270,7 +270,7 @@ class BlockTestCase extends DrupalWebTestCase { $this->drupalPost('user/' . $this->admin_user->uid . '/edit', $edit, t('Save')); $this->drupalGet(''); - $this->assertNoText($block['title'], t('Block was not displayed according to per user block visibility setting.')); + $this->assertNoText($block['title'], 'Block was not displayed according to per user block visibility setting.'); // Set the block to be customizable per user, hidden by default. $edit = array(); @@ -283,7 +283,7 @@ class BlockTestCase extends DrupalWebTestCase { $this->drupalPost('user/' . $this->admin_user->uid . '/edit', $edit, t('Save')); $this->drupalGet(''); - $this->assertText($block['title'], t('Block was displayed according to per user block visibility setting.')); + $this->assertText($block['title'], 'Block was displayed according to per user block visibility setting.'); } /** @@ -298,14 +298,14 @@ class BlockTestCase extends DrupalWebTestCase { // Set block title to confirm that interface works and override any custom titles. $this->drupalPost('admin/structure/block/manage/' . $block['module'] . '/' . $block['delta'] . '/configure', array('title' => $block['title']), t('Save block')); - $this->assertText(t('The block configuration has been saved.'), t('Block title set.')); + $this->assertText(t('The block configuration has been saved.'), 'Block title set.'); $bid = db_query("SELECT bid FROM {block} WHERE module = :module AND delta = :delta", array( ':module' => $block['module'], ':delta' => $block['delta'], ))->fetchField(); // Check to see if the block was created by checking that it's in the database. - $this->assertNotNull($bid, t('Block found in database')); + $this->assertNotNull($bid, 'Block found in database'); // Check whether the block can be moved to all available regions. foreach ($this->regions as $region) { @@ -318,21 +318,21 @@ class BlockTestCase extends DrupalWebTestCase { $this->drupalPost('admin/structure/block', $edit, t('Save blocks')); // Confirm that the block was moved to the proper region. - $this->assertText(t('The block settings have been updated.'), t('Block successfully move to disabled region.')); - $this->assertNoText(t($block['title']), t('Block no longer appears on page.')); + $this->assertText(t('The block settings have been updated.'), 'Block successfully move to disabled region.'); + $this->assertNoText(t($block['title']), 'Block no longer appears on page.'); // Confirm that the region's xpath is not available. $xpath = $this->buildXPathQuery('//div[@id=:id]/*', array(':id' => 'block-block-' . $bid)); - $this->assertNoFieldByXPath($xpath, FALSE, t('Custom block found in no regions.')); + $this->assertNoFieldByXPath($xpath, FALSE, 'Custom block found in no regions.'); // For convenience of developers, put the navigation block back. $edit = array(); $edit['blocks[' . $block['module'] . '_' . $block['delta'] . '][region]'] = $this->regions[1]; $this->drupalPost('admin/structure/block', $edit, t('Save blocks')); - $this->assertText(t('The block settings have been updated.'), t('Block successfully move to first sidebar region.')); + $this->assertText(t('The block settings have been updated.'), 'Block successfully move to first sidebar region.'); $this->drupalPost('admin/structure/block/manage/' . $block['module'] . '/' . $block['delta'] . '/configure', array('title' => 'Navigation'), t('Save block')); - $this->assertText(t('The block configuration has been saved.'), t('Block title set.')); + $this->assertText(t('The block configuration has been saved.'), 'Block title set.'); } function moveBlockToRegion($block, $region) { @@ -342,18 +342,18 @@ class BlockTestCase extends DrupalWebTestCase { $this->drupalPost('admin/structure/block', $edit, t('Save blocks')); // Confirm that the block was moved to the proper region. - $this->assertText(t('The block settings have been updated.'), t('Block successfully moved to %region_name region.', array( '%region_name' => $region))); + $this->assertText(t('The block settings have been updated.'), format_string('Block successfully moved to %region_name region.', array( '%region_name' => $region))); // Confirm that the block is being displayed. $this->drupalGet('node'); - $this->assertText(t($block['title']), t('Block successfully being displayed on the page.')); + $this->assertText(t($block['title']), 'Block successfully being displayed on the page.'); // Confirm that the custom block was found at the proper region. $xpath = $this->buildXPathQuery('//div[@class=:region-class]//div[@id=:block-id]/*', array( ':region-class' => 'region region-' . str_replace('_', '-', $region), ':block-id' => 'block-' . $block['module'] . '-' . $block['delta'], )); - $this->assertFieldByXPath($xpath, NULL, t('Custom block found in %region_name region.', array('%region_name' => $region))); + $this->assertFieldByXPath($xpath, NULL, format_string('Custom block found in %region_name region.', array('%region_name' => $region))); } /** @@ -361,14 +361,14 @@ class BlockTestCase extends DrupalWebTestCase { */ function testBlockRehash() { module_enable(array('block_test')); - $this->assertTrue(module_exists('block_test'), t('Test block module enabled.')); + $this->assertTrue(module_exists('block_test'), 'Test block module enabled.'); // Our new block should be inserted in the database when we visit the // block management page. $this->drupalGet('admin/structure/block'); // Our test block's caching should default to DRUPAL_CACHE_PER_ROLE. $current_caching = db_query("SELECT cache FROM {block} WHERE module = 'block_test' AND delta = 'test_cache'")->fetchField(); - $this->assertEqual($current_caching, DRUPAL_CACHE_PER_ROLE, t('Test block cache mode defaults to DRUPAL_CACHE_PER_ROLE.')); + $this->assertEqual($current_caching, DRUPAL_CACHE_PER_ROLE, 'Test block cache mode defaults to DRUPAL_CACHE_PER_ROLE.'); // Disable caching for this block. variable_set('block_test_caching', DRUPAL_NO_CACHE); @@ -376,7 +376,7 @@ class BlockTestCase extends DrupalWebTestCase { drupal_flush_all_caches(); // Verify that the database is updated with the new caching mode. $current_caching = db_query("SELECT cache FROM {block} WHERE module = 'block_test' AND delta = 'test_cache'")->fetchField(); - $this->assertEqual($current_caching, DRUPAL_NO_CACHE, t("Test block's database entry updated to DRUPAL_NO_CACHE.")); + $this->assertEqual($current_caching, DRUPAL_NO_CACHE, "Test block's database entry updated to DRUPAL_NO_CACHE."); } } @@ -427,7 +427,7 @@ class NewDefaultThemeBlocks extends DrupalWebTestCase { $themes['admin'] = $admin_theme; } $count = db_query_range('SELECT 1 FROM {block} WHERE theme NOT IN (:themes)', 0, 1, array(':themes' => $themes))->fetchField(); - $this->assertFalse($count, t('Only the default theme and the admin theme have blocks.')); + $this->assertFalse($count, 'Only the default theme and the admin theme have blocks.'); // Populate list of all blocks for matching against new theme. $blocks = array(); @@ -445,7 +445,7 @@ class NewDefaultThemeBlocks extends DrupalWebTestCase { $result = db_query('SELECT * FROM {block} WHERE theme = :theme', array(':theme' => 'stark')); foreach ($result as $block) { unset($block->theme, $block->bid); - $this->assertEqual($blocks[$block->module][$block->delta], $block, t('Block %name matched', array('%name' => $block->module . '-' . $block->delta))); + $this->assertEqual($blocks[$block->module][$block->delta], $block, format_string('Block %name matched', array('%name' => $block->module . '-' . $block->delta))); } } } @@ -472,13 +472,13 @@ class BlockAdminThemeTestCase extends DrupalWebTestCase { // Ensure that access to block admin page is denied when theme is disabled. $this->drupalGet('admin/structure/block/list/stark'); - $this->assertResponse(403, t('The block admin page for a disabled theme can not be accessed')); + $this->assertResponse(403, 'The block admin page for a disabled theme can not be accessed'); // Enable admin theme and confirm that tab is accessible. $edit['admin_theme'] = 'stark'; $this->drupalPost('admin/appearance', $edit, t('Save configuration')); $this->drupalGet('admin/structure/block/list/stark'); - $this->assertResponse(200, t('The block admin page for the admin theme can be accessed')); + $this->assertResponse(200, 'The block admin page for the admin theme can be accessed'); } } @@ -532,20 +532,20 @@ class BlockCacheTestCase extends DrupalWebTestCase { variable_set('block_test_content', $current_content); $this->drupalLogin($this->normal_user); $this->drupalGet(''); - $this->assertText($current_content, t('Block content displays.')); + $this->assertText($current_content, 'Block content displays.'); // Change the content, but the cached copy should still be served. $old_content = $current_content; $current_content = $this->randomName(); variable_set('block_test_content', $current_content); $this->drupalGet(''); - $this->assertText($old_content, t('Block is served from the cache.')); + $this->assertText($old_content, 'Block is served from the cache.'); // Clear the cache and verify that the stale data is no longer there. cache_clear_all(); $this->drupalGet(''); - $this->assertNoText($old_content, t('Block cache clear removes stale cache data.')); - $this->assertText($current_content, t('Fresh block content is displayed after clearing the cache.')); + $this->assertNoText($old_content, 'Block cache clear removes stale cache data.'); + $this->assertText($current_content, 'Fresh block content is displayed after clearing the cache.'); // Test whether the cached data is served for the correct users. $old_content = $current_content; @@ -553,19 +553,19 @@ class BlockCacheTestCase extends DrupalWebTestCase { variable_set('block_test_content', $current_content); $this->drupalLogout(); $this->drupalGet(''); - $this->assertNoText($old_content, t('Anonymous user does not see content cached per-role for normal user.')); + $this->assertNoText($old_content, 'Anonymous user does not see content cached per-role for normal user.'); $this->drupalLogin($this->normal_user_alt); $this->drupalGet(''); - $this->assertText($old_content, t('User with the same roles sees per-role cached content.')); + $this->assertText($old_content, 'User with the same roles sees per-role cached content.'); $this->drupalLogin($this->admin_user); $this->drupalGet(''); - $this->assertNoText($old_content, t('Admin user does not see content cached per-role for normal user.')); + $this->assertNoText($old_content, 'Admin user does not see content cached per-role for normal user.'); $this->drupalLogin($this->normal_user); $this->drupalGet(''); - $this->assertText($old_content, t('Block is served from the per-role cache.')); + $this->assertText($old_content, 'Block is served from the per-role cache.'); } /** @@ -577,7 +577,7 @@ class BlockCacheTestCase extends DrupalWebTestCase { variable_set('block_test_content', $current_content); $this->drupalGet(''); - $this->assertText($current_content, t('Block content displays.')); + $this->assertText($current_content, 'Block content displays.'); $old_content = $current_content; $current_content = $this->randomName(); @@ -585,7 +585,7 @@ class BlockCacheTestCase extends DrupalWebTestCase { $this->drupalLogout(); $this->drupalGet('user'); - $this->assertText($old_content, t('Block content served from global cache.')); + $this->assertText($old_content, 'Block content served from global cache.'); } /** @@ -598,13 +598,13 @@ class BlockCacheTestCase extends DrupalWebTestCase { // If DRUPAL_NO_CACHE has no effect, the next request would be cached. $this->drupalGet(''); - $this->assertText($current_content, t('Block content displays.')); + $this->assertText($current_content, 'Block content displays.'); // A cached copy should not be served. $current_content = $this->randomName(); variable_set('block_test_content', $current_content); $this->drupalGet(''); - $this->assertText($current_content, t('DRUPAL_NO_CACHE prevents blocks from being cached.')); + $this->assertText($current_content, 'DRUPAL_NO_CACHE prevents blocks from being cached.'); } /** @@ -617,22 +617,22 @@ class BlockCacheTestCase extends DrupalWebTestCase { $this->drupalLogin($this->normal_user); $this->drupalGet(''); - $this->assertText($current_content, t('Block content displays.')); + $this->assertText($current_content, 'Block content displays.'); $old_content = $current_content; $current_content = $this->randomName(); variable_set('block_test_content', $current_content); $this->drupalGet(''); - $this->assertText($old_content, t('Block is served from per-user cache.')); + $this->assertText($old_content, 'Block is served from per-user cache.'); $this->drupalLogin($this->normal_user_alt); $this->drupalGet(''); - $this->assertText($current_content, t('Per-user block cache is not served for other users.')); + $this->assertText($current_content, 'Per-user block cache is not served for other users.'); $this->drupalLogin($this->normal_user); $this->drupalGet(''); - $this->assertText($old_content, t('Per-user block cache is persistent.')); + $this->assertText($old_content, 'Per-user block cache is persistent.'); } /** @@ -644,16 +644,16 @@ class BlockCacheTestCase extends DrupalWebTestCase { variable_set('block_test_content', $current_content); $this->drupalGet('node'); - $this->assertText($current_content, t('Block content displays on the node page.')); + $this->assertText($current_content, 'Block content displays on the node page.'); $old_content = $current_content; $current_content = $this->randomName(); variable_set('block_test_content', $current_content); $this->drupalGet('user'); - $this->assertNoText($old_content, t('Block content cached for the node page does not show up for the user page.')); + $this->assertNoText($old_content, 'Block content cached for the node page does not show up for the user page.'); $this->drupalGet('node'); - $this->assertText($old_content, t('Block content cached for the node page.')); + $this->assertText($old_content, 'Block content cached for the node page.'); } /** @@ -706,7 +706,7 @@ class BlockHTMLIdTestCase extends DrupalWebTestCase { */ function testHTMLId() { $this->drupalGet(''); - $this->assertRaw('block-block-test-test-html-id', t('HTML id for test block is valid.')); + $this->assertRaw('block-block-test-test-html-id', 'HTML id for test block is valid.'); } } @@ -736,7 +736,7 @@ class BlockTemplateSuggestionsUnitTest extends DrupalUnitTestCase { $variables1['elements']['#block'] = $block1; $variables1['elements']['#children'] = ''; template_preprocess_block($variables1); - $this->assertEqual($variables1['theme_hook_suggestions'], array('block__footer', 'block__block', 'block__block__underscore_test'), t('Found expected block suggestions for delta with underscore')); + $this->assertEqual($variables1['theme_hook_suggestions'], array('block__footer', 'block__block', 'block__block__underscore_test'), 'Found expected block suggestions for delta with underscore'); // Define block delta with hyphens to be preprocessed. Hyphens should be // replaced with underscores. @@ -748,7 +748,7 @@ class BlockTemplateSuggestionsUnitTest extends DrupalUnitTestCase { $variables2['elements']['#block'] = $block2; $variables2['elements']['#children'] = ''; template_preprocess_block($variables2); - $this->assertEqual($variables2['theme_hook_suggestions'], array('block__footer', 'block__block', 'block__block__hyphen_test'), t('Hyphens (-) in block delta were replaced by underscore (_)')); + $this->assertEqual($variables2['theme_hook_suggestions'], array('block__footer', 'block__block', 'block__block__hyphen_test'), 'Hyphens (-) in block delta were replaced by underscore (_)'); } } @@ -784,11 +784,11 @@ class BlockHiddenRegionTestCase extends DrupalWebTestCase { // Ensure that "block_test_theme" is set as the default theme. $this->drupalGet('admin/structure/block'); - $this->assertText('Block test theme(' . t('active tab') . ')', t('Default local task on blocks admin page is the block test theme.')); + $this->assertText('Block test theme(' . t('active tab') . ')', 'Default local task on blocks admin page is the block test theme.'); // Ensure that the search form block is displayed. $this->drupalGet(''); - $this->assertText('Search form', t('Block was displayed on the front page.')); + $this->assertText('Search form', 'Block was displayed on the front page.'); } } -- cgit v1.2.3