From c5aa55b38ef944eae0b36f4354fa2e8c33fb59c9 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?G=C3=A1bor=20Hojtsy?= <gabor@hojtsy.hu>
Date: Thu, 10 Jan 2008 15:03:53 +0000
Subject: #204705 by pwolanin: abort user_save on SQL errors, to avoid data
 corruption

---
 modules/comment/comment.module | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

(limited to 'modules/comment/comment.module')

diff --git a/modules/comment/comment.module b/modules/comment/comment.module
index 2cc44455c..222164351 100644
--- a/modules/comment/comment.module
+++ b/modules/comment/comment.module
@@ -1652,7 +1652,13 @@ function comment_controls_submit($form, &$form_state) {
   $comments_per_page = $form_state['values']['comments_per_page'];
 
   if ($user->uid) {
-    $user = user_save($user, array('mode' => $mode, 'sort' => $order, 'comments_per_page' => $comments_per_page));
+    $account = user_save($user, array('mode' => $mode, 'sort' => $order, 'comments_per_page' => $comments_per_page));
+    // Terminate if an error occured during user_save().
+    if (!$account) {
+      drupal_set_message(t("Error saving user account."), 'error');
+      return;
+    }
+    $user = $account;
   }
   else {
     $_SESSION['comment_mode'] = $mode;
-- 
cgit v1.2.3